From: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Richard Cochran <richardcochran@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Subject: [PATCH net-next v4 00/10] net: stmmac: qcom-ethqos: add Shikra EMAC support
Date: Tue, 17 Nov 2026 14:15:20 +0530 [thread overview]
Message-ID: <20261117-shikra_ethernet-v4-0-c41902e5f2fa@oss.qualcomm.com> (raw)
This series incorporates feedback from the RFC and adds the dt-bindings
and driver changes required to enable Gigabit Ethernet support on the
Qualcomm Shikra SoC. DTS changes will be sent out separately.
The series has grown from the RFC and can be broadly divided into three
areas: PHY power supply management, proper support for RGMII ID mode in
the Qualcomm ETHQOS driver, and Shikra specific clock dependencies
required for NOC access.
1. Shikra EVK boards use a GPIO-gated regulator for the DP83867 PHY
power supply. Patches 1 and 2 add supply management to the DP83867
driver so the PHY driver holds the regulator vote at probe. These
changes are largely inspired by similar work done for the QCA8081 PHY:
https://lore.kernel.org/netdev/20261015143849.483339-1-elder@riscstar.com/
2. The generic RGMII fixes from the RFC remain. As suggested, the new
flow to use phy managed delays is protected by a platform specific
boolean to ensure that it affects only tested hardware. Legacy boards
will remain unaffected. Some other optimizations are carried forward
(initial link clock to SPEED_10, common structure for custom
dwmac4_addrs).
3. NOC clock voting (patch 8) now uses dev_pm_opp_set_opp() so the
required VDD_CX performance state can be propagated through the clock
controller. The Shikra binding (patch 3) is updated accordingly: an
if/else block constrains Shikra to exactly six clocks and requires
operating-points-v2 and power-domains.
Testing:
The following boards have been tested with this new (proper) handling
for RGMII ID:
- Shikra CQ/IQ variants (with the TI DP83867 PHY)
- QCS615 Ride (with the Micrel KSZ9031 PHY)
- Talos EVK (again with the Micrel KSZ9031 PHY)
- Talos Lyra EVK (TI DP83867 PHY, this board also has a GPIO-gated
regulator for the PHY power supply)
Changes in v4:
- Re-added the bindings patch for DP83867 PHY regulators which was
accidentally dropped in v3.
- Skip dp83867_power_on() if CONFIG_REGULATOR is disabled to avoid
unintentional delay due to its code stub: Sashiko.
- Moved operating-points description to the top-level of ethqos
bindings: Krzysztof.
- Added power-domains as a required property for Shikra due to its OPP
dependency: Sashiko.
- Protect the phy-managed delay sequence with a platform specific
boolean to avoid impact on legacy hardware: Andrew.
- Dropped "net: stmmac: qcom-ethqos: warn about legacy RGMII PHY modes"
since only Shikra and QCS615 are going to use the RGMII-ID mode.
- Added additional details to some commit messages to clarify Sashiko
queries.
- Since QCS615/Talos was also tested, a new patch adds its platform
descriptor with phy_managed_delays set to true.
- Link to v3: https://lore.kernel.org/netdev/20261017-shikra_ethernet-v3-0-26a8beb44b8f@oss.qualcomm.com/
Changes in v3:
- Remove #ifdef CONFIG_OF from the dp83867_power_on() function. This is
a result of the recent discussion regarding similar handling in the
qca808x driver:
https://lore.kernel.org/netdev/atCSWZQAyqvz62_K@aspen.lan/
- Clean up the -ENODEV handling in dp83867_power_on() and use a boolean
to identify if supplies are provided -- Lorenzo.
- Patch 7's commit message now says set_clk_tx_rate instead of
fix_mac_speed -- Sashiko.
- Add a new patch to abstract away the common dwma4_addrs for different
versions of ethqos rather than duplicating them -- Lorenzo.
- Use OPP table to set both the required clock rates and power state,
update ethqos bindings accordingly to specify how the clock rates are
described in DTS -- Konrad, Lorenzo.
- Link to v2: https://lore.kernel.org/r/20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com
Changes in v2:
- Collected Maxime's Reviewed-by tags.
- Updated Patch 9's commit message to explain the double enable vote
on the "stmmaceth" clock. Open to discussion on how best to handle
this.
- Wrapped regulator vote for dp83867 inside an #ifdef CONFIG_OF check
to avoid adding an unnecessary 200 ms delay on systems where
devm_regulator_get_enable_optional() would return 0. The change now
mirrors the QCA8081 patch -- Sashiko.
- Fixed ethqos_set_clk_tx_rate() to double the rate for all PHY modes
other than RGMII-ID -- Sashiko.
- Moved warning about the use of non RGMII-ID mode to probe instead
of fix_mac_speed to avoid spamming during each link up event --
Sashiko.
- Fixed error unwind drops OPP before stopping link_clk -- Sashiko.
- Fixed OPP vote set in probe not cleaned up on error -- Sashiko.
- Link to v1: https://lore.kernel.org/netdev/20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com/#t
Changes since RFC:
- Two new patches add supply management for the DP83867, replacing
the gpio-hog approach for PHY power -- Konrad, Andrew.
- Use dev_pm_opp_set_rate() for the NOC AXI clock and require
operating-points-v2 for Shikra -- Konrad.
- Warn on legacy "rgmii"/"rgmii-txid" to encourage DTB migration --
Andrew, Maxime.
- Updated binding document for qcom,ethqos and snps,dwmac.
- Drop the duplicate "axi" clock from Shikra's DT; use "axi-noc" and
"pcie-tile-axi-noc" as the only additional clock-names.
- Initialise RGMII link clock at SPEED_10 rather than SPEED_1000 on
probe.
- Link to RFC: https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-0-f0f4a1d19929@oss.qualcomm.com/
Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
---
Mohd Ayaan Anwar (10):
dt-bindings: net: ti,dp83867: add supply properties
net: phy: dp83867: add regulator supply management
dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible
net: stmmac: qcom-ethqos: convert ethqos_rgmii_macro_init() to void
net: stmmac: qcom-ethqos: add DLL-bypass for PHY-managed RGMII delays
net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed
net: stmmac: qcom-ethqos: share common GMAC4 address table
net: stmmac: qcom-ethqos: add per-platform NOC clock voting
net: stmmac: qcom-ethqos: add Shikra EMAC support
net: stmmac: qcom-ethqos: add QCS615 EMAC support
.../devicetree/bindings/net/qcom,ethqos.yaml | 54 +++-
.../devicetree/bindings/net/snps,dwmac.yaml | 2 +
.../devicetree/bindings/net/ti,dp83867.yaml | 14 +
drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 +
.../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 286 ++++++++++++++++-----
drivers/net/phy/dp83867.c | 35 +++
6 files changed, 327 insertions(+), 65 deletions(-)
---
base-commit: 6964ff21c5d8b75649211a52dbfd92753e605649
change-id: 20260903-shikra_ethernet-ae7bee5e804e
Best regards,
--
Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
next reply other threads:[~2026-11-17 8:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 8:45 Mohd Ayaan Anwar [this message]
2026-11-17 8:45 ` [PATCH net-next v4 01/10] dt-bindings: net: ti,dp83867: add supply properties Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 02/10] net: phy: dp83867: add regulator supply management Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 03/10] dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 04/10] net: stmmac: qcom-ethqos: convert ethqos_rgmii_macro_init() to void Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 05/10] net: stmmac: qcom-ethqos: add DLL-bypass for PHY-managed RGMII delays Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 06/10] net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 07/10] net: stmmac: qcom-ethqos: share common GMAC4 address table Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 08/10] net: stmmac: qcom-ethqos: add per-platform NOC clock voting Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 09/10] net: stmmac: qcom-ethqos: add Shikra EMAC support Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 10/10] net: stmmac: qcom-ethqos: add QCS615 " Mohd Ayaan Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117-shikra_ethernet-v4-0-c41902e5f2fa@oss.qualcomm.com \
--to=mohd.anwar@oss.qualcomm.com \
--cc=afd@ti.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®