From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794905192; b=SR5WrvniY7Ow07nHB/Hgzt9pgWzE4my7tmSEuw8WZ6iZy5kEYmqHzCHXV6liUe92/OOf gOze5Y8uFkmYziKmDHKrV0iKcHhRx8A1mYujZC1iT2wByPnJTt0sgO/7BaXRNktp3hpjL fL+rLd8IJqRx+r4ZUxfsjQiiZoAi7NiRrw8pNnFmda3sD5Oh4r9lMQ+KREthH4CeuJvZ1 kPkyf+Z6+KAGyL2ag4MjJu10Gb0g3IDiZgiDbDC/bBXf5XLNliagb4/chnUAl4jqLXjHw 22KDF9F88RmqGDWEt2aJItKDZM32yt4KVtMgvlDX4wN9lT561KbKuAGxUEY2h7Gzg3A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794905192; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Proofpoint-Spam-Details-Enc: X-Authority-Analysis:X-Proofpoint-ORIG-GUID:X-Proofpoint-GUID: X-Proofpoint-Spam-Info:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=axGLWmtidPhO3L+75bMr1aFJDxlJul/pLSoRq58+U1g=; b=nHGTGxVxAw3/gDc3eGRZoI3aTuXk5gWJAB6DMMrDIB+8JWF+9e+iCt5eKD2pLZHLKrTR tuj9UOItUJUPilD5bxy0ELOKpjlWbp9VNXkEryjZWGihS7K8Kr2eZaHRRNtiBdEhqy8sb Q0N+/oIyZYNi/yv6RLTc+mjFxs1cBuglNZ+TgrlCXe+C0teaN11GghlGoaqCbMvKt9Rn1 kZ+Cci3pUtPTnmGxaaKKMZw21/gjLZatkDHNvKDukgruKp6MDIrOGypP8GX3j/MjIGeW1 oWQ69zOF+Uiar05FurDqihpjpHFbsqnlSyniRKUbtAcFdNfbqwgQAq3w+23ah7pjFcA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=WXp8YkAf; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=A5159sHG; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6754960A2600 for ; Tue, 17 Nov 2026 08:46:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6754960A2600 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=WXp8YkAf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=A5159sHG Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AH4X0xp1758802 for ; Tue, 17 Nov 2026 08:46:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= axGLWmtidPhO3L+75bMr1aFJDxlJul/pLSoRq58+U1g=; b=WXp8YkAfLNdBX102 2b3V5vWFXZCOY1QzwlnF/dlNFGn9Le1yo2w7uog/MdPNGYyLa5yVO1vsOorCAu21 U9DhTd5Isbqzba9iodGbWVYpsPvOhTyudhvNDdL5S030XsW3hWlEPrcHROOubwle qzNWy/Cj01rXlBF0mP9a0luAWjc1+9rz2fbdhx+Y2lVVYrDV6426qIX4nNhYzmlm IEZVoKxZEu48vXxDTP11ckc76eJi8ONs4n4vBDYDuo9j7V6aWVN8nIRHYs7VB4Ym 0pKljB80K+DxUk7OKlUVeICnMZXxiXcgBn/5zgdZQ+neoF1rKtdgcf4ALPHJv8Ki ZQA1TA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j0fjugyns-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Nov 2026 08:46:29 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cdd48746a49so2575712a12.0 for ; Tue, 17 Nov 2026 00:46:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794905188; x=1795509988; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=axGLWmtidPhO3L+75bMr1aFJDxlJul/pLSoRq58+U1g=; b=A5159sHGM2cxzEd05P4xfNynbUYrSI0jqhG/O4z1Ux/Re0lvYzHOM7cxQit9lHVBuV e5tLOfemBr4SGjATifWrUEZ3M6+uZfjbOVNq7MccR3kcKbGtE6eD41jclFyw2DAGDrvP jWC5T1UAEh+Tbfz4gKSUvuWarPb3bL/QMEUjbWH4gWOb0pdKaeeCAVHYHgbZHP7P29pW K0FIOKo5uhDHPhb9eiQalAmxH/YJO6YlkNSTBZhAb7JyM6hJnymRUMEOiSC0DKXsqdlD BG/WGuOFBYor8kDhBWOyPq/srLq8py0MvQYmDDOPlnFtgapxY6r5dtHhbkpKhkkqNdVn v4dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794905188; x=1795509988; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=axGLWmtidPhO3L+75bMr1aFJDxlJul/pLSoRq58+U1g=; b=TBqcoChiX8hxfqf8ozr28hwBUsecJrEUBgKX129iiSD/4pVEVILwH8rx3KcM0jU+SK FCCB7WlEn885gP5SRsxmsPjPMLqZ+WM62w6h4gAVusZeWR1e+KXOcVH94iPwgQR27deE 5ETlbvirClJTXYWx6jpbH+PikX3JXVsy2HOhN74jyN34QKwMaW4/d70Gd/3mH41xLr+R phxeDYrBFyhqxH3oJ1CkHyo7wtoH5N618XYwxMsFvoXiRcDpI+GCfdSy714rKaDGvJGY st4GH8elKlpPgnGT1trpkhavhRqcKNbA9BApV0+J3FqUeYf2NRRAD1iccqk1XBiKCIdA QL5A== X-Forwarded-Encrypted: i=1; AL+hErH1mBCT1xq87Z3FXMU+nlSjQ1nECEUwJRPCUSMqMGWuiLi9QY3Kmpe25XenUEVuBFn8PPX6v4dswTeNGxM=@vger.kernel.org X-Gm-Message-State: APuU4Z8xEGP2mhEIfJ/4cjy/IqcBko9WdDLxr+tDWboFfnt+TNx3TYBa o0FqASw0Ms1bpNg6i1fa2lustmhWBSU6Z+xAXvMM1qTP/U86vWUhGe+EcPcUn7cVhwi5vuSVdn5 qpzUDeCt8CcoTOYf7c0fs2LCrEtPbmNcQD0srHpfqGsCzB2JyXsktNiDCxU2dhkPYCdY= X-Gm-Gg: AYBFou2HUZDhLt8l1RIdemdbwOK61XoGlYgT0wjn3p4TKd3e7CrmJ+TYv6BbJG6QdiT Rmn9NKyKxA3oDZiZiERh2nNdgpmj7zrLV6IB/HF2C58ToUmlpOOBCX8IKFWrEtMe6QnLIQ/VIvN 2KAxKTF5BN2gxaATEsEAw5PEqj44sFk0faXqsQszQuAbS3yS62Jms7ZolSgnTh6jAp3ryWy2wMt f1PF79SjON2xj0HBrwPyi4kAhE3arQF70tqY1zCpwignzMpaa08PBneWsZBekEaJtJWIy3xriEV qI+b4Oa21vm+Bj9xD+Z8Or+pp/LYay9nC3Uqd3dj2CGFJfKOPRUzuotWpSDTOx38y+m5DWwlEPE YBtN9EmSpcUBH+gkpWeaivFNYj2ZJNKlBJr2cAlfUOsGsfY63onTaIeRfyEG7tL4vZeBz7h/KB9 LJzg== X-Received: by 2002:a05:6a20:da11:b0:3f9:a6b6:e16f with SMTP id adf61e73a8af0-3f9a6b6e4eemr8182575637.65.1794905188158; Tue, 17 Nov 2026 00:46:28 -0800 (PST) X-Received: by 2002:a05:6a20:da11:b0:3f9:a6b6:e16f with SMTP id adf61e73a8af0-3f9a6b6e4eemr8182547637.65.1794905187603; Tue, 17 Nov 2026 00:46:27 -0800 (PST) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cddc18736b3sm5699585a12.7.2026.11.17.00.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 00:46:27 -0800 (PST) From: Mohd Ayaan Anwar Date: Tue, 17 Nov 2026 14:15:24 +0530 Subject: [PATCH net-next v4 04/10] net: stmmac: qcom-ethqos: convert ethqos_rgmii_macro_init() to void X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261117-shikra_ethernet-v4-4-c41902e5f2fa@oss.qualcomm.com> References: <20261117-shikra_ethernet-v4-0-c41902e5f2fa@oss.qualcomm.com> In-Reply-To: <20261117-shikra_ethernet-v4-0-c41902e5f2fa@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , Lorenzo Bianconi Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1794905144; l=1924; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=h8iKXwGfP4z+zw3C5X6I1w9ChDSEwoK8RxfNrBe96t8=; b=kQD6/F8/rCLDa03R5m7H9YJ6yMZIibUFFYNTVT4Zn796GNjmnhaMoEYXuxPnHy634R57WVUR/ DSZdcFderHwDrShBS9akj317sJ08LUX1Z6LInvVrBAUvzLKN23VSJ0p X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE3MDAzNCBTYWx0ZWRfX2gKGxFukSWwb 62zi067iQ2XyYXPEao0aIF/yVDDWWC6SwxJsVVPPTvPy/yOaFrRY5x08TNcDd9hphHIifdldK7l Dmi8DUS526/x8nOlViOOnGaElFsaZJvkgVosb44PtFY4oj2P6PTKZn1L36IhHMpxmZzm5LdDUXc WFUu5gtGTx0bMAdK8ykxDerorhvBex2oOJGOgMiV5+BgSA3DzTxBL2CiXAFSDj889je8z1TSQ6H ZKaOqUQhbHd+Gw3LKZZVyD4pBxYhasxtEjl1oeXpePT4FxI940lhUbVTMjQeJxTCtNq8bAxguaY yrMeBx12udGgKj3X/o7duoq4vNBo8R1uolW6d0KS0aaoeyy2gAj311xewGtdkR7ncAxj5l4QYik nfcl3KtYKkh5ixn20Qm9G2jkKtr4bcBFuG3z5BhHldscoAbO+lltRf5zSRfqlnZ3wgQ9WrEGpXL PklQy7wwl/6QIJL5OUA== X-Authority-Analysis: v=2.4 cv=JfIpPkKV c=1 sm=1 tr=0 ts=6afc1465 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=Vjzh3eGJV6Wj_RHhdNYA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: bYfpjw5CIgZyQIsRKJeF4-QAmOTtOSaA X-Proofpoint-GUID: bYfpjw5CIgZyQIsRKJeF4-QAmOTtOSaA X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE3MDAzNCBTYWx0ZWRfXziwqfrLQ5qOP UzvFqStIhyI+Lkp7I1/FMwriwBDeGp4h7JSTryYscPSKQ1feikqQzqOYL5F8KnSvQo4ZypKQ9Hf +CBCATBf69/+kaGgFKL501sWGh3pQD4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-17_01,2026-11-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611170034 The return value is never checked by its sole caller and the speed validation duplicates a check higher up the call stack. Convert to void and remove the dead code. Reviewed-by: Maxime Chevallier Acked-by: Lorenzo Bianconi Signed-off-by: Mohd Ayaan Anwar --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index d24509a4b4d7..f2428f0467bb 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -411,9 +411,8 @@ static int ethqos_dll_configure(struct qcom_ethqos *ethqos) return 0; } -static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) +static void ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) { - struct device *dev = ðqos->pdev->dev; unsigned int prg_rclk_dly, loopback; unsigned int phase_shift; @@ -424,11 +423,6 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) /* Select RGMII, write 0 to interface select */ rgmii_clrmask(ethqos, RGMII_CONFIG_INTF_SEL, RGMII_IO_MACRO_CONFIG); - if (speed != SPEED_1000 && speed != SPEED_100 && speed != SPEED_10) { - dev_err(dev, "Invalid speed %d\n", speed); - return -EINVAL; - } - rgmii_setmask(ethqos, RGMII_CONFIG_DDR_MODE, RGMII_IO_MACRO_CONFIG); if (speed == SPEED_1000) { @@ -519,8 +513,6 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, loopback, RGMII_IO_MACRO_CONFIG); - - return 0; } static void ethqos_fix_mac_speed_rgmii(void *bsp_priv, -- 2.34.1