From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794905208; b=FlMQNx2oDdZtmoEw/9JSmnrKoMusBWvCnasP+dxBLu8nS8G0SgsQ2pHDEtqqFzpIMtNC p1yxqxNpxbHOtFIzivV2g+sHVGrqtzymrx/1gTCjXpvJJ9yzxmjTgGANiRrpBxl7t/h7a oHVZ7GJ/nTAMmgpiT5kMIXPHX8KqXiNdarjzZq6/FC5qBYBJNzWtYSxOknCCthkkXkZhy YHvOfLJeSmJ1feBVFPWyr2roeRjVEWazeLk6dRAaJxrVfVUgnvCkdwLwomOT3TqfmfyVU T+qMSMPLaulOnB56Lr0fTcG+iHYf3s1ygMrp7AGbyUaWGEnctaXPE0lItnWUFI1eFOw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794905208; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Proofpoint-Spam-Info: X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID:X-Authority-Analysis: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=YdIbBZ4ULQRqJJDrxiHRWIiIa4SEEoe3KYPpLWdtKrY=; b=A6QCsjDeoN6Dxb1isijuhvDKe0Ge9Dl98YJKuvLQBBaaYCdSWyOmNU7lDxaJFJ/A4eSP fsqHmrKEtHT2ifjQG4PIHavj5/N7+ClZr2fdwUswrliqxK1CmjbWq5xXmu9yIXZ3YZ6s9 25vARWe0pGGGU7MXm43lKVj/TCCUb+Ve3OtA93xjsd9EAKbkYG/fv9wppeKvSrtxEeBvU wdHOKdsj+hO0S+9z2J0V2r77bJ7vMp5aKzTHCBnCpY+vz3vntm4y4wlBbOPjEQGFDuuux RI+I0nVqZmv2//R5oGcot8NisbK2JS0GJwjEJu8z5IJn/kfK70K6k4gT/zIj+FtmLFA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=PTeIORmf; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b="URJIJk/C"; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9A4060A2605 for ; Tue, 17 Nov 2026 08:46:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B9A4060A2605 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=PTeIORmf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=URJIJk/C Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AH6ex2g2998571 for ; Tue, 17 Nov 2026 08:46:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YdIbBZ4ULQRqJJDrxiHRWIiIa4SEEoe3KYPpLWdtKrY=; b=PTeIORmfxb5eviGY z3VBVE5lWYUwUurjpxAvW/aDrAqS+NYE06SX37iEiOvSK9zoJCR1Odxwh7LqcHZF B3Dttx1axsU1BPhRXcYNJ4xt3j1ChYFhnzoK6V9yGEJDIYCawZ0HRSPBHjdarVvi 2kAcCRbNxzg1861zDQ5Q42knEwSoxYAvIOsUVIjAxg843OI0r4v65RVLWofrKIFX eQcRgGxEASubP4AuQ63v/EH5adsuFvNx44AIRsCaBDME/nUU0WaKj/uxsizDDkHx 7MHnlrfFpV9DkBeD1Ft/zymg2eZMZpgfOVPa646ZJTcDIP0boEbghbIfDXHNXh2p SqiZmw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j0hve0g2v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Nov 2026 08:46:45 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cdd97f89731so500036a12.1 for ; Tue, 17 Nov 2026 00:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794905205; x=1795510005; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YdIbBZ4ULQRqJJDrxiHRWIiIa4SEEoe3KYPpLWdtKrY=; b=URJIJk/CTmhVRLQ2uJzFw6FrGers+XgrWZX5KCQsvfTxmh9HjUFhTilXIL8k2Mqw8/ 09pQCXmvgJXq9hShC928b5E8fC4/bQzQ1fVC7t8+Bal+u7dKqaj+1Plf6yaqXGbixPYB ZoMDdkQWDDNWcajOn9CkuZRmdBwVYeSL4tHIDRc2fNKWORy1P0RzHI3gMXlWUWLclRN4 pCMhH4S0SJTxePYgelrP1kSNa59BqjD5Pmrv7NOl3o0EQPyzhFkD7jL13oZKzsrOXbdp gU1VcOAV1tpA5ys0H/Ny6XjabxzwKedBCCcpZichGFkMA5unS17zjtMjJkTF4Imc9FWe Mpog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794905205; x=1795510005; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YdIbBZ4ULQRqJJDrxiHRWIiIa4SEEoe3KYPpLWdtKrY=; b=KRYWLl/CXg/NmxhpCplOaXw3jL5QaYY1Udw9UiMCBvhzOm7h8v8iks08BpOVxoZkIl SISN/hmAb/DtXoETXBQrZhw+Thq2HhAlDADhUyrrfMZHZnzLs2xffM7qIRFiDFMR7cCF e/U4GNJV4O53Bt7tVr12EEUwCdeIN+bmLwnwQquxfI94wrYpfNDyrJvDk26JN2JY12oH ucPKsxYlmsfb0fkFBaO7ZLtuCspwZOPkfRX7jfZ2ZIBevhSf6W02+eaYaKBGMZb2IZHA mvOCDMsYMxQJZ+++RMHu+lNB7auKFfcFDrMBUmhzH99LRBcWZCXcj1uWPqhC4RTY4A98 W03Q== X-Forwarded-Encrypted: i=1; AL+hErF1iugVg4tUS1/PSMNpmEnaE/TKsSBge1iccb2bcziDfKgPe3Y7HIPZhkw4z/l7iMRVBQEG1Cx6kMCNTuE=@vger.kernel.org X-Gm-Message-State: APuU4Z+hPYZMkAcVMyPxlLsmCsthpoA5+oEAZAZGN5i36yHWRZqyHlBB vRRGHktV+pKnecGJN+KIQKGWGnrwZlPOSZmOZE9vQtoONiXpaq1EDPyrwjThGu3OlgfH+Yc9ED6 lsmKTowH1d1Q1KRu0KKTWFuhVwMS9ry2SOmm9MyCb7Xo+mli808+GrnW44lqeXoG0x/k= X-Gm-Gg: AYBFou2Isu5cTg/fyjqcm1CDDTT4jL6KypLC/OuXDq/UFJhfizrqGo49f8fafP5CGYE Lc4fp7PQW0Wetp1b5hLY0BfOxJqn9ok4/s9CYX6cLxL5TJ1QxH9xVtJe+b9UBMBJuLGAxPsMoAv epXF1+Y92LWWURonqs0Y7sLbHz5PuDcB6JZX5vSFC/FLPtRxrTULCNNNyZ+e3CMMFbIbqBZUFHS LPX6sZkLlQhn6nD1ESHdDXZkeU2d81RViI6ueEXxpdXpwyNs1U97irJipX+CtSai3VUHFy1LkgV NNoasrDWIGaSxRDWsl/Sn7DaO9lVAySfOMcMohSR68Nswy6wbcb2IC9BFh5k0883VoEQHj89Ce7 zJaYWzdX4JU9lCHV/bEXWH8t78L7F0gqsiUOMZlRzkx0Sa57FGFGCxR3YyUvf38Gr9uLZtznDkY qABg== X-Received: by 2002:a05:6a20:9146:b0:3fa:2f3c:b00c with SMTP id adf61e73a8af0-3fd2e2ba1d9mr1539550637.24.1794905205187; Tue, 17 Nov 2026 00:46:45 -0800 (PST) X-Received: by 2002:a05:6a20:9146:b0:3fa:2f3c:b00c with SMTP id adf61e73a8af0-3fd2e2ba1d9mr1539524637.24.1794905204643; Tue, 17 Nov 2026 00:46:44 -0800 (PST) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cddc18736b3sm5699585a12.7.2026.11.17.00.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 00:46:44 -0800 (PST) From: Mohd Ayaan Anwar Date: Tue, 17 Nov 2026 14:15:26 +0530 Subject: [PATCH net-next v4 06/10] net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261117-shikra_ethernet-v4-6-c41902e5f2fa@oss.qualcomm.com> References: <20261117-shikra_ethernet-v4-0-c41902e5f2fa@oss.qualcomm.com> In-Reply-To: <20261117-shikra_ethernet-v4-0-c41902e5f2fa@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , Lorenzo Bianconi Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1794905144; l=1511; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=RpifxHIohWwcF3nhiLIn3gCgfBa+VybjsdQk7Cx2Trk=; b=LRDHro7v7JC89pC7fis0z3esT5dgan4Jacy+s0RcqgazDgOabVUBiBt+r1r07PWd7aQcMyYNo yu5IWG77AJ9AOFi6+o5QTuBYwU8+Jpd5ORfpMUbcU48Qf7jWKisFg7B X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE3MDAzNCBTYWx0ZWRfX+MsyzJwlIAgg knMZFsSkHHmNxE5xWUkVwJaEeOD60EZpujswYqq3sgG2ygkU31V7EEgGkhHXtQMbwF7dySQsjcy +mZ/UKk+2mIMueMnVbtakYGiUBvsm6I= X-Proofpoint-GUID: avt_bTk9tSEWiK3YqhrRrm3B-_pI4fNr X-Proofpoint-ORIG-GUID: avt_bTk9tSEWiK3YqhrRrm3B-_pI4fNr X-Authority-Analysis: v=2.4 cv=dqhOmFg4 c=1 sm=1 tr=0 ts=6afc1475 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=pwD1iIOGdNV7nma60yEA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE3MDAzNCBTYWx0ZWRfX0as7RNjy0lQx 49aPuwlt96qVKgXAE3+EfYJQaSN787xsTkA3SsinlDT/gs/FId2C7IMsxJJ+UTtB8rxD1XqzzpU 1SOXLQPYUcGdPAh5I6C1RAY4O0J2UJsPLnF/thL+vD5FTFWl9o491tQTjKOB6115P1iR1dDlch7 dDHO9xghmHgZ39F/wrFyg/n9GSzniGHDtNIAa3es4Od3fQ+0RouJ5BsnJX9PGpc2s3GcF7n3QRp PeNR/Dy8851mdIyVlZRfZ61gO4AgoyZck4ot221j6fQLrb2is2skQr+taR441ny9LRo8Jgx7TID k9Z5ZmPaI/dKRiquSHAc8uhRhCmbrM4peO2mlqnkGuPd1olxR5zNRheckJTZIr7YUksKDzXf1Cg y72iIt2Afpjbppx7F/7pXqTsp4WGEpuXbYDD1AXOxPwKKJ9RzCe3Hm7kpr2dXTz3pBlsnQo5Gu/ i+Ekn23+v64czcbNhqw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-17_01,2026-11-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611170034 On probe the RGMII link clock is initialised at SPEED_1000, which translates to a 250 MHz source clock even when no PHY link is present, drawing unnecessary power. Initialise at SPEED_10 instead; set_clk_tx_rate updates the rate once a link is established. The DLL locking is not affected by the current clock rate. This has been confirmed with actual hardware testing as well as the fact that the existing code performs the DLL lock first before changing the clock rate when the link speed changes. Reviewed-by: Maxime Chevallier Signed-off-by: Mohd Ayaan Anwar --- v4: add some details in the commit message to address concerns raised by Sashiko. --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 99ea7e0cfb00..192788e00dfa 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -828,7 +828,7 @@ static int ethqos_hlos_setup(struct qcom_ethqos *ethqos, if (ret) return ret; - ethqos_set_clk_tx_rate(ethqos, NULL, plat_dat->phy_interface, SPEED_1000); + ethqos_set_clk_tx_rate(ethqos, NULL, plat_dat->phy_interface, SPEED_10); qcom_ethqos_set_sgmii_loopback(ethqos, true); ethqos_set_func_clk_en(ethqos); -- 2.34.1