From: Neil Armstrong <neil.armstrong@linaro.org>
To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: [PATCH 0/2] media: qcom: iris: gen2 encoder picture type subscription and operating rate fixups
Date: Tue, 17 Nov 2026 16:21:22 +0100 [thread overview]
Message-ID: <20261117-topic-iris-encoder-fixes-v1-0-169ce990d12d@linaro.org> (raw)
Two fixups for the Qualcomm iris encoder:
- subscribe to the picture type on the encoder instance
Add encoder input and output property tables (HFI_PROP_NO_OUTPUT on the
input queue, HFI_PROP_PICTURE_TYPE on the output queue) for all gen2
firmware data tables.
- venc: drop operating rate to match spec
Per the V4L2 Stateful Encoder UAPI, the frame interval is set via S_PARAM
on the OUTPUT queue; drop the unused operating_rate so S_PARAM on OUTPUT
sets frame_rate directly, as FFmpeg and GStreamer expect.
Tested on the SM8650 platform for encode using both FFmpeg and
GStreamer, checking that the frame rate is properly applied and the
firmware reports the expected picture types.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Neil Armstrong (2):
media: qcom: iris: gen2: subscribe to the picture type on the encoder instance
media: qcom: iris: venc: drop operating rate to match spec
drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 23 ++++++++++
.../platform/qcom/iris/iris_hfi_gen2_command.c | 15 ++++--
drivers/media/platform/qcom/iris/iris_instance.h | 2 -
.../platform/qcom/iris/iris_platform_common.h | 6 ++-
.../media/platform/qcom/iris/iris_platform_milos.h | 1 -
.../platform/qcom/iris/iris_platform_qcs8300.h | 1 -
.../platform/qcom/iris/iris_platform_sm8550.h | 1 -
.../media/platform/qcom/iris/iris_platform_vpu2.c | 1 -
.../platform/qcom/iris/iris_platform_vpu_ar50lt.c | 1 -
drivers/media/platform/qcom/iris/iris_utils.c | 8 ++--
drivers/media/platform/qcom/iris/iris_venc.c | 53 ++++++----------------
11 files changed, 56 insertions(+), 56 deletions(-)
---
base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
change-id: 20261117-topic-iris-encoder-fixes-9f13c6ec765d
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
next reply other threads:[~2026-11-17 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 15:21 Neil Armstrong [this message]
2026-11-17 15:21 ` [PATCH 1/2] media: qcom: iris: gen2: subscribe to the picture type on the encoder instance Neil Armstrong
2026-11-17 15:21 ` [PATCH 2/2] media: qcom: iris: venc: drop operating rate to match spec Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117-topic-iris-encoder-fixes-v1-0-169ce990d12d@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®