From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.222.169 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794873921; b=qhc//kab/ynqhtfuG1+EtE3A8m+X/trapLurCPHn87BluzK2koI5XjnGy0PHKODmVrnb ghT3+is03rxJa/3CTrrpqu8J5rORrNMAwhRmsMAPr0yKGNXFAiRaGyHe0ZQWYTB9Ub09q QcHMUmeFrq1uPzKAy1AAHPfcOfByXSNtR3Wfsmips/SRgClmjLZAYWKN7W3tgFscw6YKL zD/163+lKZvWe9z03vGRjevBXJn/v+Q/MaKvEJYErtD3g7Za0B63qaDM3WFXudBwKhND8 plcLd1UkCsbYOagQb1VKGCpOWiMhZP4OlI3CnAevE5Z5KNOyKE4PI1td2qzc+D5pPEQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794873921; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=eMx+CTkXv1VoOtSvi+6D1nYsmWu0vpvPd8N8huVVt6c=; b=1fqRjH9EM4SOcRaOCf1D/FDxCERa5p6/Ilw5b5ZZWCgJoWqi4fooQYhRTUhCXiljjCLn pfufbmAV6+/SYT3uULGqsjJsnyqsQLjMXoeBpDn+DULl4jhp3T8eMID48qnh6Py7OHdjE 2NzJa7cNS/fXkvqfR2SQLwsX/N633PZwAyiQ7ZhMraqSjEK1NgKAFBjGAFiaNJcCaUQgu +zuzjdS/L++NUtafrsFdaA+bSGyHoWH3twcVAaKUgFQDUvWZ2JUADulZIs/Go1MykRlA3 jCqvzb30i2enmwNLvqRfeNsDxrfn06zjLgfzUDqK4aHxHEDK3/xoMovuvMbDAnKtEQA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=o+1molFf; arc=none smtp.remote-ip=209.85.222.169 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A4A8606A332 for ; Tue, 17 Nov 2026 00:05:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2A4A8606A332 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=o+1molFf Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-9496400270fso262763385a.1 for ; Mon, 16 Nov 2026 16:05:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1794873920; x=1795478720; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=eMx+CTkXv1VoOtSvi+6D1nYsmWu0vpvPd8N8huVVt6c=; b=o+1molFffc9e6T9ddIDnNeseSjzEf2bQKujHs4vpOVw4OzSSGS4YQo8BJrSN9kd667 k9JFBOotGGRYa0PkAFx2E0FiQp1pgsnwgn6pcnUL3Eya4+1ObVIZXwVWtTnGOXsLpAKM Qm4w4F5jBIoZdwaJAnrycuNhvr/nMKvlaRPWeoY+KemZwqtCHlIRV3pKlOZAan8ZiPyk dg+rWFVtziAEodqueYjujOY8FQIiLOIqi0nCOki4SNuEx/vo4myxz/px2YhfTxnQyYx8 5SnT2fX1BMMsw9KBqqyDMrnK6kEETUe11lAAN+nPzvpxO9VlnJiaiLVZSGU+NSdcdbag q8ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794873920; x=1795478720; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eMx+CTkXv1VoOtSvi+6D1nYsmWu0vpvPd8N8huVVt6c=; b=j+evp1e+03/i1k/zUJ/mZcI1t+cgxeO98E8jTlFQCOpK0XP66UEZXyQ9wtGGWayDM1 1cdd4KCQAlcsTDlOTAw+FDBNv/XCNoTkYoM4PRJK89ak1wpzUqY1vpiNqdf98HRC8LJC yxQT2/HYBVM0V9L3NXGMam5F+K+hExkbBz8OpyBcQcmZ9LXbhuwbkkBBt4WZHiKZn3Ax Qip6wzjEXkPhCUEicEPge1KoYX4O/dAymLL57ExVV75AODQfy/JITflo77cX5GRcWqJd 8JxFGLmq/wgcFwxJkMAHMUzL4QoLqT2dqOj0O1Lqx+9BtlG+TEXlPzyyhP4TEqamwHpa G9Ew== X-Forwarded-Encrypted: i=1; AL+hErHDkUrFmzdepRERoF8mCuNuILxBB0UMoqVjFd1UWP72kf+ygmQCy2bgkLu7MWGUrRLXRjMZZfeszSzmdgI=@vger.kernel.org X-Gm-Message-State: APuU4Z9rH0z+f+bjFAaDtCcFJV9PrVwDsLDX/uZgzHlEtuM37XHMlJfw HIVNuqclIj3rawNBZJDUOACDRbMWeQ7izS7HVGxisnOME+Wz7q7l+0ztg0b7055I01w= X-Gm-Gg: AYBFou37VFePcZRjx4vjPGkKMbBaBJhG76uBAcpC/OKq+FqauMCJVLJ3Xqo4BJpk1Em T94Jcz3lQxH20IoKIyvscO8jPdd6LaSEz23Lqbclm/zcoY+tjiBRdLMbS0fjarknqnAiV6zhsSO m7vQZvmKfHycsioqgD4tOC/NwdbpUl5XFlOgyOjNEZ0AahdSYb2Qej1QPve0zXZZpU2TQyzeuDv vBOaZs5YFrLiKT85AAUGHYCtv7+s4geJqBCBTtvNWq7G7jZp2WtXC0TY9VfxFpVXXro28zFunUY PEmWuZvEuloacdfy0u5q4+oX6Ns3Vhuk93psamTAKBTkcOyF0LJiK46iUa085Ro7jDvVzl2O9sw qrtI6VFXZUhNUdkpfJt5lPiSw/aa6f3jj73a9TPqOh6kwzP5GUseMlJBpBZNVd6/z5V68WvNYWF PJpEKWYvsdCrWoxB5rVg2Ub0luKzepw51b4x3Jrb4SEaS8sLiq1OY1uum5DiojWw0Au3MMCFnBv VdLF+tGEoNVB3YPqK1zRHm2XTr65P8E7sKlDuea3uiJfTaz6jcXP9WU6neZMCZvN1cuqqmSwy0+ KqY9Rg== X-Received: by 2002:a05:620a:aa0b:b0:949:7473:b1a5 with SMTP id af79cd13be357-9497473c077mr807892285a.55.1794873920005; Mon, 16 Nov 2026 16:05:20 -0800 (PST) Received: from ziepe.ca ([142.166.156.71]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9494c8b889csm969866585a.32.2026.11.16.16.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 16:05:10 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xT6h7-0000000Apgy-1pGN; Mon, 16 Nov 2026 20:05:05 -0400 Date: Mon, 16 Nov 2026 20:05:05 -0400 From: Jason Gunthorpe To: Robin Murphy Cc: Leon Romanovsky , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Torokhov , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Berg , Jonathan Corbet , Shuah Khan , Randy Dunlap , Bjorn Helgaas , "Joerg Roedel (AMD)" , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , David Woodhouse , Lu Baolu , Johan Hovold , Eric Dumazet , Marcel Holtmann , Luiz Augusto von Dentz , Nipun Gupta , Nikhil Agarwal , Pieter Jansen van Vuuren , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, iommu@lists.linux.dev Subject: Re: [PATCH v2 18/19] PCI: Replace untrusted state with device trust Message-ID: <20261117000505.GA2488304@ziepe.ca> References: <20261109-device-trust-core-v2-0-3b12d9a9f861@nvidia.com> <20261109-device-trust-core-v2-18-3b12d9a9f861@nvidia.com> <20261110122237.GG8635@unreal> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 16, 2026 at 05:13:59PM +0000, Robin Murphy wrote: > Even with the slightly dubious argument that this series only intends to > shuffle the existing PCI code around rather than fully introduce the generic > abstraction that it claims to, if the PCI behaviour is still just based on > propagating the internal "untrusted" flag plus the new global override, both > of which *are* known at add_device time into the common trust state, then > there seems little excuse for not doing that up-front so that the new API > *can* just work as expected. The desired iommu flow is to start out as blocking and create the default domain only right before driver binding when we have the correct trust level. If we try to do that without this series then we have to do it all the time, which I'm really scared will break some embedded thing that expects scanout to work or something like that. My hope was this becomes opt-in based on the new command line stuff in this series. On the other hand this series works properly on systems without an iommu, which is pretty much all CC VMs today. There are probably around 15 series to complete all of this PCI device attestation. Without everything it isn't really usable, IMHO. I'm not that worried about the series ordering. > > We have two levels: policy - that describes the default of all devices > > for that bus. level - actual decision on how that device is going to be > > operated. > > > > "Disabled" prevents driver probing until the device is authorized, > > "Adversary" permits probing and requests the available protections > > for operating an untrusted device. > > > > Both need conservative initial IOMMU setup: a disabled device may later > > be authorized as adversary, and authorization does not rebuild its IOMMU > > domain. > > Urgh, I can be absolutely certain I'm not the only one who is going to be > confused this way... I see "disabled" and instinctively take it to mean > disabling the device_trust *mechanism*, as the logical thing that people > will reach for in terms of "I don't care what this new thing is, just get it > out of my way and let my drivers work like they always used to; I want to > disable the new thing." Maybe "isolated" is a better word? Jason