From: Wilson Felipe Pereira <wfelipe@google.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Song Liu <song@kernel.org>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Dylan Hatch <dylanbhatch@google.com>, Yi Zhu <chuyee@google.com>,
Wilson Felipe Pereira <wfelipe@google.com>
Subject: [PATCH 0/2] objtool/klp: Fix sympos for global/local symbol collisions
Date: Tue, 17 Nov 2026 00:08:30 +0000 [thread overview]
Message-ID: <20261117000835.1992893-1-wfelipe@google.com> (raw)
When a defined STB_GLOBAL symbol in one translation unit shares its name
with a static (STB_LOCAL) symbol in another translation unit (for
example, cgroup_storage_lookup in kernel/bpf/local_storage.c vs
kernel/bpf/bpf_cgrp_storage.c), runtime kallsyms lookup counts both
symbols together. Emitting sympos 0 for the global symbol causes module
load to fail in klp_find_object_symbol() with "unresolvable ambiguity
for symbol".
Patch 1 disambiguates defined non-local symbols across .klp.symid
generation, klp_find_sympos(), and clone_reloc_klp() (while preserving
sympos 0 when unique). Patch 2 adds tests covering both module (.symtab
order) and vmlinux (.klp.symid address order) paths, including
EXPORT_SYMBOL_FOR_MODULES() exports.
Wilson Felipe Pereira (2):
objtool/klp: Disambiguate global symbols colliding with local symbols
objtool/klp: Add test for global/local symbol name collisions
tools/objtool/klp-diff.c | 11 +++
tools/objtool/klp-symid.c | 2 +-
tools/objtool/klp-sympos.c | 9 +-
.../tests/generic/fixtures/sympos_vmlinux.c | 6 ++
.../tests/generic/test-sympos-global-dup.sh | 99 +++++++++++++++++++
5 files changed, 123 insertions(+), 4 deletions(-)
create mode 100755 tools/objtool/tests/generic/test-sympos-global-dup.sh
base-commit: 141b164bbe186423e295b139e40e8e2d11cf1341
--
2.56.1.703.gf848ed807c-goog
next reply other threads:[~2026-11-17 0:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 0:08 Wilson Felipe Pereira [this message]
2026-11-17 0:08 ` [PATCH 1/2] objtool/klp: Disambiguate global symbols colliding with local symbols Wilson Felipe Pereira
2026-11-17 0:08 ` [PATCH 2/2] objtool/klp: Add test for global/local symbol name collisions Wilson Felipe Pereira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117000835.1992893-1-wfelipe@google.com \
--to=wfelipe@google.com \
--cc=chuyee@google.com \
--cc=dylanbhatch@google.com \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®