mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Anisa Su <anisa.su887@gmail.com>
Cc: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev,
	linux-kernel@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Ira Weiny <iweiny@kernel.org>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Fan Ni <nifan.cxl@gmail.com>, Li Ming <ming.li@zohomail.com>,
	Benjamin Cheatham <benjamin.cheatham@amd.com>,
	Gregory Price <gourry@gourry.net>,
	Richard Cheng <icheng@nvidia.com>,
	Anisa Su <anisa.su@samsung.com>
Subject: Re: [PATCH v1 02/14] cxl/port: Add dynamic capacity options to endpoint decoder mode
Date: Tue, 17 Nov 2026 02:22:28 +0000	[thread overview]
Message-ID: <20261117022228.43725ce7@jic23-hlaptop> (raw)
In-Reply-To: <20261104230445.66625-3-anisa.su@samsung.com>

On Thu,  5 Nov 2026 08:02:26 +0900
Anisa Su <anisa.su887@gmail.com> wrote:

> Endpoints can now carry a dynamic ram partition following the
> persistent memory partition. A DC partition is further described by
> two properties reported in its CDAT DSMAS entry: shareable and
> read-only.
> 
> Expand the decoder mode to accept 'dynamic_ram', 'dynamic_ram_shared',
Time to argue about bikeshed colors.

So we want the subtle distinction between shared and shareable?
Shared implies it is happening, shareable that it might.

I don't really care either way.

> 'dynamic_ram_ro' and 'dynamic_ram_shared_ro'. cxl_dpa_set_part()
> selects the first dynamic ram partition whose properties match exactly.
> 
> DCD may be disabled during validation after the DC partition(s) were
> added to the DPA layout, so a decoder may only be assigned to a DC
> partition while DCD is enabled for its memdev. Add a helper,
> cxled_dcd_enabled(), to check cxl_dcd_supported().
> 
> Signed-off-by: Anisa Su <anisa.su@samsung.com>
> Tested-by: Wonjae Lee <wj28.lee@samsung.com>
> Tested-by: Junhee Park <jh9934.park@samsung.com>
> Tested-by: Heesoo Kim <habil.kim@samsung.com>
> ---
>  Documentation/ABI/testing/sysfs-bus-cxl | 25 +++++++----
>  drivers/cxl/core/core.h                 | 23 ++++++++++-
>  drivers/cxl/core/hdm.c                  | 21 ++++++++--
>  drivers/cxl/core/port.c                 | 55 ++++++++++++++++++++++---
>  4 files changed, 105 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl
> index 7352dbd70bc7..bcbc44fea6db 100644
> --- a/Documentation/ABI/testing/sysfs-bus-cxl
> +++ b/Documentation/ABI/testing/sysfs-bus-cxl
> @@ -339,22 +339,29 @@ Description:
>  
>  
>  What:		/sys/bus/cxl/devices/decoderX.Y/mode
> -Date:		May, 2022
> -KernelVersion:	v6.0
> +Date:		May, 2022, November, 2026
> +KernelVersion:	v6.0, v7.5 (dynamic_ram)
>  Contact:	linux-cxl@vger.kernel.org
>  Description:
>  		(RW) When a CXL decoder is of devtype "cxl_decoder_endpoint" it
>  		translates from a host physical address range, to a device
>  		local address range. Device-local address ranges are further
> -		split into a 'ram' (volatile memory) range and 'pmem'
> -		(persistent memory) range. The 'mode' attribute emits one of
> -		'ram', 'pmem', or 'none'. The 'none' indicates the decoder is
> -		not actively decoding, or no DPA allocation policy has been
> -		set.
> +		split into a 'ram' (volatile memory) range, 'pmem' (persistent
> +		memory) range, and dynamic capacity ranges. The 'mode'
> +		attribute emits one of 'ram', 'pmem', 'none', or a dynamic
> +		capacity selector: 'dynamic_ram', 'dynamic_ram_shared',
> +		'dynamic_ram_ro' or 'dynamic_ram_shared_ro', composed from the
> +		shareable and read-only properties of the partition the decoder
> +		points at. The 'none' indicates the decoder is not actively
> +		decoding, or no DPA allocation policy has been set.
>  
>  		'mode' can be written, when the decoder is in the 'disabled'
> -		state, with either 'ram' or 'pmem' to set the boundaries for the
> -		next allocation.
> +		state, with 'ram', 'pmem', or one of the dynamic capacity
> +		selectors to set the boundaries for the next allocation. A
> +		selector picks the first dynamic capacity partition whose
> +		shareable and read-only properties match it exactly, and is
> +		accepted only while the driver has dynamic capacity enabled
> +		for the device.
>  
>  
>  What:		/sys/bus/cxl/devices/decoderX.Y/dpa_resource
> diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h
> index 8a81be004d00..24fbb5718abc 100644
> --- a/drivers/cxl/core/core.h
> +++ b/drivers/cxl/core/core.h
> @@ -6,6 +6,7 @@
>  
>  #include <cxl/mailbox.h>
>  #include <linux/rwsem.h>
> +#include <cxlmem.h>
>  
>  extern const struct device_type cxl_nvdimm_bridge_type;
>  extern const struct device_type cxl_nvdimm_type;
> @@ -18,6 +19,25 @@ enum cxl_detach_mode {
>  	DETACH_INVALIDATE,
>  };
>  
> +static inline struct cxl_memdev_state *
> +cxled_to_mds(struct cxl_endpoint_decoder *cxled)
> +{
> +	struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);
> +
> +	return to_cxl_memdev_state(cxlmd->cxlds);
> +}
> +
> +/* Type-2 devices have no memdev state; nothing else leaves @cxlds NULL here */

Seems like an odd comment given cxlds isn't visibly used in here.
Perhaps needs to refer to it via a specific path?

> +static inline bool cxled_dcd_enabled(struct cxl_endpoint_decoder *cxled)
> +{
> +	struct cxl_memdev_state *mds = cxled_to_mds(cxled);
> +
> +	return mds && cxl_dcd_supported(mds);
> +}


> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index f3705ea44db7..9b71b58d4e36 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -203,6 +203,40 @@ static ssize_t target_list_show(struct device *dev,
>  }
>  static DEVICE_ATTR_RO(target_list);
>  
> +/* Dynamic capacity selectors: the flags name one kind of DC partition */
> +static const struct {
> +	const char *name;
> +	bool shareable;
> +	bool read_only;
> +} cxl_dc_modes[] = {
> +	{ "dynamic_ram",		false,	false },
> +	{ "dynamic_ram_shared",		true,	false },

This rather highlights the disconnect in naming. 

> +	{ "dynamic_ram_ro",		false,	true },
> +	{ "dynamic_ram_shared_ro",	true,	true },
> +};
> +



  reply	other threads:[~2026-11-17  2:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 23:02 [PATCH v1 00/14] DCD CXL Series: Dynamic Capacity extent handling Anisa Su
2026-11-04 23:02 ` [PATCH v1 01/14] cxl/core: Return endpoint decoder information from region search Anisa Su
2026-11-04 23:02 ` [PATCH v1 02/14] cxl/port: Add dynamic capacity options to endpoint decoder mode Anisa Su
2026-11-17  2:22   ` Jonathan Cameron [this message]
2026-11-04 23:02 ` [PATCH v1 03/14] cxl/region: Add dynamic DAX region support Anisa Su
2026-11-17  2:32   ` Jonathan Cameron
2026-11-04 23:02 ` [PATCH v1 04/14] cxl/mem: Introduce DC event handlers Anisa Su
2026-11-17  2:54   ` Jonathan Cameron
2026-11-04 23:02 ` [PATCH v1 05/14] cxl/mem: Add 20 second timeout for stalled DC event chains Anisa Su
2026-11-17  3:00   ` Jonathan Cameron
2026-11-04 23:02 ` [PATCH v1 06/14] cxl/extent: Handle DC Add Capacity events Anisa Su
2026-11-12  3:34   ` Richard Cheng
2026-11-16 21:53     ` Anisa Su
2026-11-04 23:02 ` [PATCH v1 07/14] cxl/mem: Drop misaligned DCD extent groups Anisa Su
2026-11-04 23:02 ` [PATCH v1 08/14] cxl/extent: Validate DC extent partition Anisa Su
2026-11-04 23:02 ` [PATCH v1 09/14] cxl/mem: Enforce tag-group semantics Anisa Su
2026-11-04 23:02 ` [PATCH v1 10/14] cxl/extent: Enforce cross-region tag uniqueness Anisa Su
2026-11-04 23:02 ` [PATCH v1 11/14] cxl/extent: Handle DC Release Capacity events Anisa Su
2026-11-12  7:34   ` Richard Cheng
2026-11-04 23:02 ` [PATCH v1 12/14] cxl/region: Read existing extents on region creation Anisa Su
2026-11-04 23:02 ` [PATCH v1 13/14] cxl/mem: Trace Dynamic capacity Event Record Anisa Su
2026-11-04 23:02 ` [PATCH v1 14/14] Documentation/cxl: Document DCD extent handling Anisa Su

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117022228.43725ce7@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=alison.schofield@intel.com \
    --cc=anisa.su887@gmail.com \
    --cc=anisa.su@samsung.com \
    --cc=benjamin.cheatham@amd.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=gourry@gourry.net \
    --cc=icheng@nvidia.com \
    --cc=iweiny@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=nifan.cxl@gmail.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®