From: SJ Park <sj@kernel.org>
To: Mattathias Pinchover via B4 Relay
<devnull+mattathias.pinchover.uber.com@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Mattathias Pinchover <mattathias.pinchover@uber.com>
Subject: Re: [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat
Date: Mon, 16 Nov 2026 18:42:31 -0800 [thread overview]
Message-ID: <20261117024231.113721-1-sj@kernel.org> (raw)
In-Reply-To: <20261116-damon-sz-ops-b4-v1-0-1cffe7227e6d@uber.com>
Hello Mattathias,
On Mon, 16 Nov 2026 19:10:03 +0000 Mattathias Pinchover via B4 Relay <devnull+mattathias.pinchover.uber.com@kernel.org> wrote:
> DAMOS stat sz_ops_filter_passed shows the total bytes that passed
> operations layer-handled DAMOS filters, accumulated from the beginning
> of the scheme's execution. Users who want the amount for only the
> latest apply interval, e.g., the size of a workload's anonymous memory
> that is cold as of now, have to keep the previous value in user space
> and compute the difference. To know how many apply intervals a
> difference covers, they have to rely on nr_snapshots. But nr_snapshots
> is increased once per target per apply interval, so the computation is
> complicated for contexts having multiple targets.
>
> This series introduces a new DAMOS stat, sz_ops_filter_passed_last. It
> shows the amount of sz_ops_filter_passed increase in the last apply
> interval of the scheme. It is updated at the end of each apply
> interval, and kept unchanged until the next apply interval is
> completed. Like the other DAMOS stats, it is exposed under the stats/
> directory of the scheme in the DAMON sysfs interface, and refreshed
> together with the other stats when refresh_ms expires or
> update_schemes_stats is written.
Thank you for this series!
>
> Patches sequence
> ================
>
> Patch 1 introduces the stat to the DAMON core. Patch 2 exposes it via
> the DAMON sysfs interface. Patch 3 adds a kunit test. Patches 4-6
> update the design, usage, and ABI documents, respectively.
I left a few comments. Maybe patch 3 needs a change that might deserve
respinning. Could you please address all the comments?
>
> Tests
> =====
[...]
> Tool use
> ========
>
> Claude (Anthropic) assisted with the code, kunit test, documents, and
> changelogs of this series, as noted by the Assisted-by: tags. I
> reviewed all of it and ran the tests listed above.
Knowing what tests are already passed and what tool is used is helpful for
reviewing. Thank you for sharing those, Mattathias. FWIW, Assisted-by: tag is
no more required [1]. I don't mind having it, though.
[1] 1e035297ffda ("docs: remove Assisted-by references")
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-11-17 2:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:10 Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 1/6] mm/damon/core: introduce sz_ops_filter_passed_last stat Mattathias Pinchover via B4 Relay
2026-11-17 2:03 ` SJ Park
2026-11-16 19:10 ` [PATCH 2/6] mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file Mattathias Pinchover via B4 Relay
2026-11-17 2:10 ` SJ Park
2026-11-16 19:10 ` [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-17 2:22 ` SJ Park
2026-11-16 19:10 ` [PATCH 4/6] Docs/mm/damon/design: update for sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-17 2:25 ` SJ Park
2026-11-16 19:10 ` [PATCH 5/6] Docs/admin-guide/mm/damon/usage: " Mattathias Pinchover via B4 Relay
2026-11-17 2:29 ` SJ Park
2026-11-16 19:10 ` [PATCH 6/6] Docs/ABI/damon: " Mattathias Pinchover via B4 Relay
2026-11-17 2:31 ` SJ Park
2026-11-17 2:42 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117024231.113721-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=devnull+mattathias.pinchover.uber.com@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mattathias.pinchover@uber.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®