mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Luo Yifan <luoyifan@cmss.chinamobile.com>
Cc: linux-iio@vger.kernel.org, Eugen Hristev <ehristev@kernel.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: pl022: handle clk_prepare_enable() failure on runtime resume
Date: Tue, 17 Nov 2026 03:02:58 +0000	[thread overview]
Message-ID: <20261117030258.364ba429@jic23-hlaptop> (raw)
In-Reply-To: <20261117020711.20158-1-luoyifan@cmss.chinamobile.com>

On Tue, 17 Nov 2026 10:07:11 +0800
Luo Yifan <luoyifan@cmss.chinamobile.com> wrote:

> pl022_runtime_resume() ignores the return value of clk_prepare_enable()
> and always returns 0.  A failed runtime resume is therefore reported as
> success and the controller is used with its clock off.
> 
> Return the error from clk_prepare_enable().
> 
> Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>

You should probably resend including linux-spi and appropriate maintainers
and dropping IIO folk.

> ---
>  drivers/spi/spi-pl022.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index f52130465a..64bf9c4b0a 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -2067,9 +2067,8 @@ static int pl022_runtime_resume(struct device *dev)
>  	struct pl022 *pl022 = dev_get_drvdata(dev);
>  
>  	pinctrl_pm_select_default_state(dev);
> -	clk_prepare_enable(pl022->clk);
>  
> -	return 0;
> +	return clk_prepare_enable(pl022->clk);
>  }
>  
>  static const struct dev_pm_ops pl022_dev_pm_ops = {


      reply	other threads:[~2026-11-17  3:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  2:07 Luo Yifan
2026-11-17  3:02 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117030258.364ba429@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=ehristev@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luoyifan@cmss.chinamobile.com \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®