mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yifan Feng <evanfengff@gmail.com>
To: David Sterba <dsterba@suse.com>
Cc: Chris Mason <mason@kernel.org>,
	Naohiro Aota <naohiro.aota@wdc.com>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yifan Feng <evanfengff@gmail.com>
Subject: [PATCH] btrfs: tests: zoned: fix NULL check of the active bitmap
Date: Mon, 16 Nov 2026 19:51:55 -0800	[thread overview]
Message-ID: <20261117035155.86323-1-evanfengff@gmail.com> (raw)

test_load_zone_info() allocates the active bitmap with bitmap_zalloc()
but then tests zone_info, which was already checked a few lines above.
A failed allocation is not detected, and the NULL bitmap is then used
by __set_bit() and by btrfs_load_block_group_by_raid_type().

Check the active bitmap instead.

Tested in QEMU with the bitmap size temporarily changed to UINT_MAX so
that the allocation fails. Without this patch the kernel oopses in
btrfs_test_zoned() with a NULL pointer dereference. With it the test
prints "cannot allocate active bitmap" and fails cleanly.

Found by searching for a NULL check that tests a different pointer than
the one just allocated, with the help of an AI coding assistant
(Claude).

Fixes: 1ba19a6ea9f2 ("btrfs: tests: zoned: add tests cases for zoned code")
Signed-off-by: Yifan Feng <evanfengff@gmail.com>
---
 fs/btrfs/tests/zoned-tests.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/tests/zoned-tests.c b/fs/btrfs/tests/zoned-tests.c
index 2bc3b14baa41..bb9969210444 100644
--- a/fs/btrfs/tests/zoned-tests.c
+++ b/fs/btrfs/tests/zoned-tests.c
@@ -65,7 +65,7 @@ static int test_load_zone_info(struct btrfs_fs_info *fs_info,
 	}
 
 	active = bitmap_zalloc(test->num_stripes, GFP_KERNEL);
-	if (!zone_info) {
+	if (!active) {
 		test_err("cannot allocate active bitmap");
 		return -ENOMEM;
 	}

base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
-- 
2.39.3 (Apple Git-146)


                 reply	other threads:[~2026-11-17  3:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117035155.86323-1-evanfengff@gmail.com \
    --to=evanfengff@gmail.com \
    --cc=dsterba@suse.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@kernel.org \
    --cc=naohiro.aota@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®