From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kees Cook <kees+treewide@kernel.org>,
Jihed Chaibi <jihed.chaibi.dev@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 1/2] ASoC: cirrus: ep93xx-i2s: Simplify platform_get_irq() error check
Date: Tue, 17 Nov 2026 11:21:01 +0700 [thread overview]
Message-ID: <20261117042102.12442-2-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261117042102.12442-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
platform_get_irq() is documented to return a non-zero IRQ number on
success and a negative error number on failure. Drop the special
handling of a zero return value and check only for irq < 0.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/cirrus/ep93xx-i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/cirrus/ep93xx-i2s.c b/sound/soc/cirrus/ep93xx-i2s.c
index 97816fb75368..8dcfc6717e19 100644
--- a/sound/soc/cirrus/ep93xx-i2s.c
+++ b/sound/soc/cirrus/ep93xx-i2s.c
@@ -462,8 +462,8 @@ static int ep93xx_i2s_probe(struct platform_device *pdev)
if (IS_ENABLED(CONFIG_SND_EP93XX_SOC_I2S_WATCHDOG)) {
int irq = platform_get_irq(pdev, 0);
- if (irq <= 0)
- return irq < 0 ? irq : -ENODEV;
+ if (irq < 0)
+ return irq;
err = devm_request_irq(&pdev->dev, irq, ep93xx_i2s_interrupt, 0,
pdev->name, info);
--
2.43.0
next prev parent reply other threads:[~2026-11-17 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 4:21 [PATCH 0/2] ASoC: cirrus: ep93xx-i2s: Clean up resource management phucduc.bui
2026-11-17 4:21 ` phucduc.bui [this message]
2026-11-17 4:21 ` [PATCH 2/2] ASoC: cirrus: ep93xx-i2s: Use devm_clk_get() phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117042102.12442-2-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=broonie@kernel.org \
--cc=jihed.chaibi.dev@gmail.com \
--cc=kees+treewide@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®