From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Seiji Nishikawa <snishika@redhat.com>,
Mian Yousaf Kaukab <ykaukab@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] sched/rt: Do not account migrate-disabled tasks as pushable
Date: Tue, 17 Nov 2026 10:25:54 -0500 [thread overview]
Message-ID: <20261117102554.402cbab8@gandalf.local.home> (raw)
In-Reply-To: <20261117152026.GI1813469@noisy.programming.kicks-ass.net>
On Tue, 17 Nov 2026 16:20:26 +0100
Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > static void enqueue_pushable_task(struct rq *rq, struct task_struct *p)
> > {
> > + if (p->nr_cpus_allowed <= 1)
> > + return;
> > +#ifdef HAVE_RT_PUSH_IPI
> > + if (sched_feat(RT_PUSH_IPI) && is_migration_disabled(p))
> > + return;
> > +#endif
> > +
>
> if (p->nr_cpus_allowed <= 1 || is_migration_disabled(p))
> return;
>
> for both RT and DL. Sure, we might get an extra load, but is that really
> going to be noticable? Lots of scheduler code already looks at the
> migrate disable thing anyway.
>
> I don't see why it should depend on RT_PUSH_IPI, it never is actually
> migratable, and so it never makes sense to have on the pushable list.
When I took a look at this, I was thinking the same thing. That there's no
need to have the HAVE_RT_PUSH_IPI check here and always do the test.
>
> But perhaps I'm missing something; the above seems to suggest that is a
> theme today.
I'm still trying to dig myself out of the tracing patches backlog to spend
time on looking at this :-p
-- Steve
prev parent reply other threads:[~2026-11-17 15:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 16:06 Mel Gorman
2026-11-17 14:27 ` Mel Gorman
2026-11-17 15:10 ` Peter Zijlstra
2026-11-17 15:20 ` Peter Zijlstra
2026-11-17 15:24 ` Peter Zijlstra
2026-11-18 10:05 ` Mel Gorman
2026-11-19 12:06 ` Mel Gorman
2026-11-19 15:08 ` Peter Zijlstra
2026-11-19 15:17 ` Peter Zijlstra
2026-11-19 15:28 ` Peter Zijlstra
2026-11-19 16:40 ` Peter Zijlstra
2026-11-19 23:34 ` Mel Gorman
2026-11-19 16:53 ` Mel Gorman
2026-11-17 15:25 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117102554.402cbab8@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=snishika@redhat.com \
--cc=vincent.guittot@linaro.org \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®