From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794913415; b=quIoxDXnAUa53yqQ4/Znywi+P1SjOMvT+pxd8YIySz2PYf2CP1tTgugU67do43vywtSO jq33hnv4jPxDymcc8EGCtDkx2+5wbumAoyhqcicHrqHCvRxYsBv4R3DpDL3YgKm8wPUqJ FM2soVB1w/cAHwDf13m1okA7mxMPNV7xvSl4xRkdrMfvkcPOHm+h4gEyFCxP2fhEHuiZL f0Uv73BEJQ+3ovf1ckEFkKlAzbS0oN5CT0XRF8WYGwa55kkc+GR0himzSUiFNBbdr2Ho8 VEKo8+cj7LTxkx95Wg3OTIeReJ4z/Bt9ZVqDySm59t6G4+iziqyCWigwwy1ZgKQE3dg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794913415; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=pBP2YxVQh3ontLZCFQlFA3EEOT/EhtaV+AKjxMibSVc=; b=pmopMF27t6HCbrbBA141AFO07ujjVp21aaugsjHxDMd8xGDzGTfc/VOvEGie7rVZK2JW q2bQNFEcw03xcd9ay/g1opNWk5enZ37BngMxkFbqbQ594YENEDkihe5v2YMpe31OA77/b OIowOHMK9FDTQJnF9kJRjiE3wlSjXzxELtlbxg9HgTzVqFGV00+ctcIDpDMOgI9Wdmp7N zWenYGNVQYGnCmZBNaLMS7T1kEkaA6mpJaTGBEu73DE6YBnweqtZVb2dvqoEwrYo8u3Hk coAX24PaOH1s6+62YIfTzpmmyUu9KiBNi0bmNwOpDTWCKJoURfigekaOElda/rMXQtQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=pF61gJfK; arc=none smtp.remote-ip=74.125.82.53 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DBF0606A323 for ; Tue, 17 Nov 2026 11:03:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6DBF0606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=pF61gJfK Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-1aefd1bf74aso632532c88.1 for ; Tue, 17 Nov 2026 03:03:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794913414; x=1795518214; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=pBP2YxVQh3ontLZCFQlFA3EEOT/EhtaV+AKjxMibSVc=; b=pF61gJfKJ82vwmSaya6jxWXA610wiYhVQsAj/HvXjfpTHVeax7PbmHAte2c/h1w1mv reDfDdZzjY3MBA9fwLSs+zrj2yqW9lM/K7Q4Trsu/9pSH/qcg6lOXeDEeXAJB/G1Hi0R DKcM0nSXVkx3hEIGq2RMIYO23o2lFgVAoFAcfe1cnGmSCPx5Ldy9keqCt/4T1GFV8uKE UWMO5Gz4VzOwUTNUHJmHue/NXA1Wh7qdppzBBO3XXQaVSse7AZasMovdxMxfh5vrocmJ gotAmVGsD5MOk+r1ZtO8ks4CfEqrBCSDYFKholpwb0Cpi2tmKm/H5JsnezACSW1T7O7n cKZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794913414; x=1795518214; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pBP2YxVQh3ontLZCFQlFA3EEOT/EhtaV+AKjxMibSVc=; b=aLhDEMqgkoXpka0BjWs3m6Yz6XXg/iQPBOUEysFJHAn4hFXcZN2HPxX8lEzP/KPpFE nanALj1sc+24wy6UuXzpKGzC8AX1f5NFX7KhUFOc9l4H1K9fECEH3bHLjO9aLpY7hXP2 KClni1MKIi+Nn6CI0Ph07mo07vv7QNUMuVbO1lP//5fp6u+RgbxUEpyYAF/m3uAWuPC2 1EVjzkMGpp5Kh8qry2X2imrzXJuxfHhc5nU1O5t/o8W0FMB/XEjpXiC96AVFOAkUNgfs 59vgg4BZQ95cglAiPjwaGRyAVqWC4a7l1orAciaCgxaiBGtFWGa5zMkKo/WjHe9qi4b0 NFmA== X-Forwarded-Encrypted: i=1; AL+hErG0LsjLTUllOKLOBW/AhWPmfwTxjeKCZfmzrxAYZCSF/hQhkEkftryyO1KAmLdfQpia4ZGTLXzEyGg7XzY=@vger.kernel.org X-Gm-Message-State: APuU4Z8GWwaQIVDchtQIYKaOT/kI7SCiAs0lvOveliZjPh4fi9BPQu/s fV1AxeyzMySB0bt4L/A4H34PoRLG/KG2VqMDH60juU/0iPLUw4VlEjPf X-Gm-Gg: AYBFou2pTuaS7FZTimUzZAIhAr84itgaM1oX84wINF25P8U3eUxPX2MgnpGA7pjd0E/ 55PwXo5Xd09jFA+BcyQDS9eXhqACJFbtRwqfWo6TmVN4ZWWRMQbRhOUErvCR9ghveuHULlFyuBS D/JLPNDzd1/0tJ5fx4+Gzpgr5+6W03wZTUeSXc7IJlHE7vwPIFFx2UiMWM6amcWuZj4JMtAup+X p7ns9mmeBX/sM+F9sCt9qclOojmmxj39fOuncHbKqs+NvBzQgclReESEsoEufQiT7OgiYSXtici lnh3BN1MGAgiGK7Fqp4aT0X3igO+xfKyHMdL8Hba46+EVdxa4qNk+eD+t011GRxVk/vEx6aXJH7 IpUaMPSkIaI+Hs2hgAtyQmSSVPeV4VyvksvSkULMA5rSQln8H2CTQR8ZVifZdx2qAkx7GP3hkc4 t8bhbIevSgIwfB2srz0YQYM0Nckit8wLmmLCXfEOgguydOm1s6E3H0NkxGljbTDsgHtZ+lj2jYs R3CbFs9QLxqYqAIljMXvJc1/x0F49FAhgyGzI7di+ddzW7LfnMIJ59wqUsQyzSXJVwol20Cu1UO Q5vFUX8vnW+SMq95DcsMsWtD45W/rcCLmRg+AD2VdQ4JxW1VS9N7v+neFKUDvITkFUs4dIwX23M Fz9DZ2cC1uKZwGOOzZuqqcsvxv7zuYrvvIN0lXSO6QG3ohk13bRbxxBg9UDNK3LWfWllnEXFeJX N4nDVmYte2rDxD1fLyG8XNB13Gk6Qpvx4zZL6pqswaAQ== X-Received: by 2002:a05:701a:8458:10b0:1a7:77ae:11f6 with SMTP id a92af1059eb24-1b53a3e47dcmr1951148c88.17.1794913414396; Tue, 17 Nov 2026 03:03:34 -0800 (PST) Received: from kapoor.iiserb.ac.in ([203.18.51.239]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b50316d9c2sm36604525c88.7.2026.11.17.03.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 03:03:33 -0800 (PST) From: Arnav Kapoor To: Jonathan Cameron Cc: Mudit Sharma , Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Arnav Kapoor Subject: [PATCH v2] iio: light: bh1745: fix 16-bit register accesses Date: Tue, 17 Nov 2026 16:33:25 +0530 Message-ID: <20261117110327.198084-1-kapoorarnav43@gmail.com> X-Mailer: git-send-email 2.53.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The 16-bit colour data and threshold registers are little-endian LSB/MSB pairs, but the driver accesses them through regmap_bulk_read() and regmap_bulk_write() with an int or u16 buffer and no byte-order conversion: - bh1745_read_raw() reads 2 bytes into an uninitialised int, so the upper 16 bits returned to user space are stack contents. - bh1745_read_thresh() reads 2 bytes straight into *val, which the IIO core leaves uninitialised, with the same result for the event threshold attributes. - bh1745_write_thresh() writes the first 2 bytes of an int, which are the upper (zero) bytes on big-endian. - bh1745_trigger_handler() pushes the raw register bytes, which are little-endian, in a u16 to a buffer whose scan type is IIO_CPU, so user space gets the samples byte-swapped on big-endian. Use an __le16 buffer for all of them and convert with le16_to_cpu() / cpu_to_le16(). Fixes: eab35358aae7 ("iio: light: ROHM BH1745 colour sensor") Reviewed-by: Andy Shevchenko Signed-off-by: Arnav Kapoor --- Changes in v2: - Include asm/byteorder.h for le16_to_cpu() / cpu_to_le16() (Andy) - Reword the trigger handler bullet: the samples are byte-swapped on big-endian because the scan type is IIO_CPU (Andy) - Add Andy's Reviewed-by v1: https://lore.kernel.org/all/20261116194214.45174-1-kapoorarnav43@gmail.com/ Compile-tested only (W=1, checkpatch --strict clean); I don't have BH1745 hardware. drivers/iio/light/bh1745.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/iio/light/bh1745.c b/drivers/iio/light/bh1745.c index 2b8ff36071b8..e2c03cd0d1e3 100644 --- a/drivers/iio/light/bh1745.c +++ b/drivers/iio/light/bh1745.c @@ -17,6 +17,8 @@ #include #include +#include + #include #include #include @@ -421,19 +423,20 @@ static int bh1745_read_raw(struct iio_dev *indio_dev, int *val, int *val2, long mask) { struct bh1745_data *data = iio_priv(indio_dev); + __le16 value; int ret; - int value; switch (mask) { case IIO_CHAN_INFO_RAW: if (!iio_device_claim_direct(indio_dev)) return -EBUSY; - ret = regmap_bulk_read(data->regmap, chan->address, &value, 2); + ret = regmap_bulk_read(data->regmap, chan->address, &value, + sizeof(value)); iio_device_release_direct(indio_dev); if (ret) return ret; - *val = value; + *val = le16_to_cpu(value); return IIO_VAL_INT; @@ -503,6 +506,7 @@ static int bh1745_read_thresh(struct iio_dev *indio_dev, enum iio_event_info info, int *val, int *val2) { struct bh1745_data *data = iio_priv(indio_dev); + __le16 value; int ret; switch (info) { @@ -510,18 +514,22 @@ static int bh1745_read_thresh(struct iio_dev *indio_dev, switch (dir) { case IIO_EV_DIR_RISING: ret = regmap_bulk_read(data->regmap, BH1745_TH_LSB, - val, 2); + &value, sizeof(value)); if (ret) return ret; + *val = le16_to_cpu(value); + return IIO_VAL_INT; case IIO_EV_DIR_FALLING: ret = regmap_bulk_read(data->regmap, BH1745_TL_LSB, - val, 2); + &value, sizeof(value)); if (ret) return ret; + *val = le16_to_cpu(value); + return IIO_VAL_INT; default: @@ -547,6 +555,7 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev, enum iio_event_info info, int val, int val2) { struct bh1745_data *data = iio_priv(indio_dev); + __le16 value; int ret; switch (info) { @@ -554,10 +563,12 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev, if (val < 0x0 || val > 0xFFFF) return -EINVAL; + value = cpu_to_le16(val); + switch (dir) { case IIO_EV_DIR_RISING: ret = regmap_bulk_write(data->regmap, BH1745_TH_LSB, - &val, 2); + &value, sizeof(value)); if (ret) return ret; @@ -565,7 +576,7 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev, case IIO_EV_DIR_FALLING: ret = regmap_bulk_write(data->regmap, BH1745_TL_LSB, - &val, 2); + &value, sizeof(value)); if (ret) return ret; @@ -741,18 +752,18 @@ static irqreturn_t bh1745_trigger_handler(int interrupt, void *p) u16 chans[4]; aligned_s64 timestamp; } scan = { }; - u16 value; + __le16 value; int ret; int i; int j = 0; iio_for_each_active_channel(indio_dev, i) { ret = regmap_bulk_read(data->regmap, BH1745_RED_LSB + 2 * i, - &value, 2); + &value, sizeof(value)); if (ret) goto err; - scan.chans[j++] = value; + scan.chans[j++] = le16_to_cpu(value); } iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan), base-commit: a6d9114f68c4b5507b2d945bd6d1e37415f913c5 -- 2.53.0