From: Rupesh Majhi <zoone.rupert@gmail.com>
To: jic23@kernel.org
Cc: "Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Eddie James" <eajames@linux.ibm.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <jonathan.cameron@oss.qualcomm.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>,
"Arnav Kapoor" <kapoorarnav43@gmail.com>
Subject: Re: [PATCH v2] iio: pressure: dps310: don't wait for new temperature in trigger handler
Date: Tue, 17 Nov 2026 13:07:34 +0200 [thread overview]
Message-ID: <20261117110735.46400-1-zoone.rupert@gmail.com> (raw)
In-Reply-To: <20261117033741.39724519@jic23-hlaptop>
On Tue, 17 Nov 2026 03:37:41 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> > I actually looked at what was messing up this time. It was just that
> > int rc; had been dropped. It's just used locally in this patch so I
> > put a declaration in.
On testing (d922ed738439) temperature read ended up in
dps310_fifo_interval() instead of probe. That runs with data->lock
held, so enabling the buffer without a trigger hangs on the board.
Diff below on top of testing moves it to probe, tested on the board.
Thanks,
Rupesh
diff --git a/drivers/iio/pressure/dps310.c b/drivers/iio/pressure/dps310.c
index 9b52cbc2372a..ebfaa67a6b91 100644
--- a/drivers/iio/pressure/dps310.c
+++ b/drivers/iio/pressure/dps310.c
@@ -1058,16 +1058,9 @@ static unsigned int dps310_fifo_interval(struct dps310_data *data,
{
unsigned int drain_interval_ms, fill_ms, want_ms;
int scan_rate;
- int rc;
fill_ms = MSEC_PER_SEC * DPS310_FIFO_DEPTH / (prs_rate + tmp_rate);
- /* Pressure compensation needs a temperature from the start */
- scoped_guard(mutex, &data->lock)
- rc = dps310_read_temp_raw_locked(data);
- if (rc)
- return rc;
-
/*
* There is no hardware watermark, so take it as the number of scans
* the user will wait for and drain at that rate. Scans come from
@@ -1478,6 +1471,12 @@ static int dps310_probe(struct i2c_client *client)
if (rc)
return rc;
+ /* Pressure compensation needs a temperature from the start */
+ scoped_guard(mutex, &data->lock)
+ rc = dps310_read_temp_raw_locked(data);
+ if (rc)
+ return rc;
+
/*
* The device measures continuously in background mode, so a triggered
* capture is just a read of the latest results. The setup ops run the
prev parent reply other threads:[~2026-11-17 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 23:02 Rupesh Majhi
2026-11-14 1:38 ` Jonathan Cameron
2026-11-14 8:35 ` Rupesh Majhi
2026-11-15 1:02 ` Jonathan Cameron
2026-11-15 18:39 ` Rupesh Majhi
2026-11-15 20:34 ` Jonathan Cameron
2026-11-15 22:38 ` Rupesh Majhi
2026-11-17 3:31 ` Jonathan Cameron
2026-11-17 3:37 ` Jonathan Cameron
2026-11-17 11:07 ` Rupesh Majhi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117110735.46400-1-zoone.rupert@gmail.com \
--to=zoone.rupert@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=eajames@linux.ibm.com \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@oss.qualcomm.com \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®