From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794919211; b=YNZVq9Gf/xrfbo59myMtWps3e9DIAEM+PsatOG8BXVE7X3a4lWnlCZsnLNLQ8/YiIEAj kIRu6mW5EOVlbisqhVfcZQttXw6+lwao2s41qMOZMYzaI5QED8QgrHK+J1Rzrya8AB3FZ f3E7ttmQfeVt8MAVHW6eMeq5rdi57z++/g+hcOFGW4c6MbFPc7O1/vYP654sRgb0fGP7V H2Sv/zbvin5tLDZg4RxmMiGwydFraHtQM+YNiLlQkkMRXTG6sSzJsX+lHlYFpwgWDDEgc usdSX63ZxD/UHnTTfZ4HEIugueYKuHvtp6o0kZMz1kRxZUPfsW6mOgxU86Lv87bS5ow== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794919211; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=iqXUKOcy9qCieLizcJg3vkRsvwt8JgXWNmMSevngILY=; b=A15CFXEyFj0rH3QgbT9hsfnZ4PdqIJDFhcT4gosW85y18RhcxkGRZu54kgDVFCaZw/Tf gIdb+Q8ofeqskFfBy7laXNCXHfiTYxAh/W56+VFwuyU7S0ilQxr/c/v2OuBV7pT/PGfLt meFaK9gVdB+VsUdH/LNH8qt5qVgl8OCobtb1NOMiupQyV9QNxXe5FI5O4aY8kVHRuPJNh oIpS5alKzUrCoo8A92zsieBtmZmT9bHV5dWxGtMLHKPE8LzhPEnM4PYvxPE9LeFNQ+kue Io1OuPqBxaxg2AaOmmc+rDEdINCbF77aXg98gS0mS6m9NxZtcztfUSurSvke6ecg13Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=jMyWs6M3; arc=none smtp.remote-ip=209.85.128.49 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9087160A263C for ; Tue, 17 Nov 2026 12:40:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9087160A263C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=jMyWs6M3 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4a5177d78c7so47826925e9.2 for ; Tue, 17 Nov 2026 04:40:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794919210; x=1795524010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=iqXUKOcy9qCieLizcJg3vkRsvwt8JgXWNmMSevngILY=; b=jMyWs6M3HAp/JBLBUeMtu/fMax2mlkF8tJ3C2dxahv//OkxZ0P5ZXLTorHIDJJ9qr4 WNL7e0OzWViTCRcsA4kwyeIYPlju+NX6Iq3odWCMbZHojlmTPWt128tI7XpDIL8npQnj okcXI7b/NWyZJRRjjsOgVdutTOuQWWDov1HPgBwdn+TLqg5bIDBwScw2/QGSj3G3UijY T5E+DzRaIqSvuM02/yXX/JaVA49YDHQbjTWUoj2Ek0fuVLq3kL0XuczRElby+xiTEI7W dREsx78dGWW5v0uJ0nsAZ77r5VYFhX3ngpDsmL2iinXbOdlMSCRKUeA0j4Dc/1uSSjbj aYZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794919210; x=1795524010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=iqXUKOcy9qCieLizcJg3vkRsvwt8JgXWNmMSevngILY=; b=cSZ1Px6IL156ny8g5WdG7SDUNRQzRBO3bb10fzk9wq0C1EvYtj2kjlQlmoLDQ3sxt9 +VaED929/HySnbKetHZ8V1aSi5paP+bWOcQaE3P/bwl5eu+sXA07BFHP+a6gB4AgNwhL URw50kzFF9mnt8uVeGx5Kjyg1XEEBpk4X9a3/NL+6ZWiz3rk0wmzwheMKmLUz8IuBsgw oca8vrzaWPnnp4joeYhIxrLwjieKVgztapwS7EumTafqs3X4akIffMPva8LDqpKu6sLn gpGVLLZHerrt/g+ZwvbmbL6eYxLtrsRpVd1njzjXCOTk/78fS0qDyqKUp5BMvnkcnu4Z U/iw== X-Forwarded-Encrypted: i=1; AL+hErGqIXqFaQKBUQMTAhY7qrYozLAEIq9zd4YNcX1ofc4g1B+UcSTLTt50In0h4htFPWIh5kB6lTdg08MlNgM=@vger.kernel.org X-Gm-Message-State: APuU4Z/OmHNeKSFHsMI6XVRZlO8wzR8ZAO0cIkyRG3HqJEbe2Ib6AWMI c1C2gHlYTP1LdjKSAiWiLkMkay/wu/R3OjHiCyT9KXjioXoDGXx/zrbL X-Gm-Gg: AYBFou1306/jfrsFkhQ9YxRYjX8EINNBMmxen4p35mcH9m/wa8Ct/lxjgnQFn9rmWnP fj+8tgyNFjOS9mVXyrHUzqeqmH6gmODiZluxWBGJ5OR6sepP2L7rKpnxX5Bva8QYCn1gagN6WIU 2atVE7NtR21eig/Tf0r02zCaLBO3LT9DnSTn/PexLd4QjGZfdknY4YNFw82IqFpjMKcpLXK4uwi DnGv7AunQE44Uh1IitgJvYqlHoxxM13XrISnTKOSvJF/eS/gbTXOQj7GYn0vQPzL1u9xzvcwTqH YyAocw0ci7Al7kvH1HVocPUch/G1JGuxaalL7hhXhxKTgHudGo9vgyomJDqrAVA1EyC/RN9IUrh ZoazFuAuy0D5iIJy4S7kFBSepVKaWju/1fEuW0RCzErUwp8Pc4pg/7IV7mx5wOKLl0mEiEk6sbg 0EoC24xhwB5L3oMKoZsTRKP/v2VPH7spA6d8U37mHFMB1usWaUHHdpyIP/kSDCpddNgAby0HdOI rnR4gRj4xRiMnfcoFVXay7ZKSG/CKdbC52Wb3kqWFLb+xgoKhNWYw+rhs1OIfG989xR1rlNECXy q+3Zd35R4fbbcg1zd42wSx4woI6XuW2QiyS9fJvKA2MLy4bHk4l8jt7xqfXd341IwAq5vk3XayP 7rS172hiXWyZmtDvyf4nTkyHuGo3FJvj7Bw== X-Received: by 2002:a05:600c:474f:b0:4bb:76d6:1f5d with SMTP id 5b1f17b1804b1-4bb76d61fb0mr87328795e9.2.1794919209827; Tue, 17 Nov 2026 04:40:09 -0800 (PST) Received: from Ansuel-XPS24.localdomain (93-34-92-103.ip49.fastwebnet.it. [93.34.92.103]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4bb78386902sm73367065e9.1.2026.11.17.04.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 04:40:09 -0800 (PST) From: Christian Marangi To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Maxime Chevallier , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , "Russell King (Oracle)" , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v22 01/15] net: phylink: make PCS phylink instance access RCU protected Date: Tue, 17 Nov 2026 13:39:41 +0100 Message-ID: <20261117123956.11981-2-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261117123956.11981-1-ansuelsmth@gmail.com> References: <20261117123956.11981-1-ansuelsmth@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In the context of phylink_pcs_change(), phylink instance is dereferenced from the pcs pointer present in the phylink_pcs struct. There is currently a fragility where this pcs pointer is never set NULL in phylink_destroy() and would reference invalid memory after phylink instance is freed. In this scenario, if a PCS driver calls phylink_pcs_change(), invalid memory can be dereferenced and phylink_link_changed() is called on freed memory. To address this, make the phylink instance saved in phylink_pcs struct RCU protected and access it under RCU lock. Also correctly reset the phylink instance pointer on phylink_destroy() and syncronyze RCU to catch an execution of phylink_pcs_change(). Fixes: 24699cc1ff3e ("net: phylink: add support for PCS link change notifications") Signed-off-by: Christian Marangi --- drivers/net/phy/phylink.c | 17 ++++++++++++++--- include/linux/phylink.h | 2 +- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index e7734e45376c..d9d0ace2042e 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -1295,10 +1296,10 @@ static void phylink_major_config(struct phylink *pl, bool restart, phylink_pcs_disable(pl->pcs); if (pl->pcs) - pl->pcs->phylink = NULL; + rcu_assign_pointer(pl->pcs->phylink, NULL); if (pcs) - pcs->phylink = pl; + rcu_assign_pointer(pcs->phylink, pl); pl->pcs = pcs; } @@ -2137,6 +2138,11 @@ void phylink_destroy(struct phylink *pl) if (pl->link_gpio) gpiod_put(pl->link_gpio); + if (pl->pcs) { + rcu_assign_pointer(pl->pcs->phylink, NULL); + synchronize_rcu(); + } + cancel_work_sync(&pl->resolve); kfree(pl); } @@ -2601,10 +2607,15 @@ EXPORT_SYMBOL_GPL(phylink_mac_change); */ void phylink_pcs_change(struct phylink_pcs *pcs, bool up) { - struct phylink *pl = pcs->phylink; + struct phylink *pl; + + rcu_read_lock(); + pl = rcu_dereference(pcs->phylink); if (pl) phylink_link_changed(pl, up, "pcs"); + + rcu_read_unlock(); } EXPORT_SYMBOL_GPL(phylink_pcs_change); diff --git a/include/linux/phylink.h b/include/linux/phylink.h index 3a88a69882a6..4a0dc6fa8010 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -494,7 +494,7 @@ struct phylink_pcs_ops; struct phylink_pcs { DECLARE_PHY_INTERFACE_MASK(supported_interfaces); const struct phylink_pcs_ops *ops; - struct phylink *phylink; + struct phylink __rcu *phylink; bool poll; bool rxc_always_on; }; -- 2.55.0