From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794924346; b=B8QMWunSn+/AuQV8wyZWyXnCELKB7d8W/f3T9qB/fHaAvtFa0LRvaugjT+Lfdm6aiXyP GNua2GsoXx2yBhqLQi5cemhf2RWiyy8KOZeNfWN81zjJhfddxnlgED+ZbUoQwhOrqXRAn hSA20Owvcc3Q+ZVXF/2buxsUxnntMAMd1U0UpDfuwTP0T2ooErtqyL9O5Cc/nOXGLC6ib CLIuX/xpIecrfgaTRuk4YN9Z30ddzf+mQ3KA80h9mdw4I3ORoswvyToTEizuMqTPL8VTI 8kYlySZioLKh6WVl/mbXwvGEhBkf+Si41nENaSxUqDi+cCt9Imv8mN/aN2Zuw34Fvpw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794924346; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=evA50aPqc3DFC7OnsafBK/uchzbfQmhK+e2vPkGMqcw=; b=bUzNWLmBkDWP49Iu3QVQVwC/laaZJ6L2ajg6bfs3L5oK8QOglhNLEE/Y608EBFRIn1e6 txeVvVSF4fgF4RbmXs84v++sjfxheOlVgXBRqAZQR9pq7jv6PzRzokHArordSy5pl9zta G7uhunqwrahhbfxQo0ZyC8+eVTR7z2aaOJ/z2xAQx1xmpQmTD4KU5BehgPobOOyd6ijfK wqGL8rdTvCOzKm4G4qBPNRxHwWishZbad5eZ1Fl6fWOtDZ1yjw8VJ71TW/VzSGv7nfSNa GU4EOcWMcLPT7jVHMGUtKenFlnar4X45Tkjrx8EebknpzkSnaxAA+b8N/oeN+Gqjb4w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=fzeC55U9; arc=none smtp.remote-ip=209.85.221.41 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5E32606A886 for ; Tue, 17 Nov 2026 14:05:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A5E32606A886 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=fzeC55U9 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4a3e706b5dfso382201f8f.2 for ; Tue, 17 Nov 2026 06:05:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794924344; x=1795529144; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=evA50aPqc3DFC7OnsafBK/uchzbfQmhK+e2vPkGMqcw=; b=fzeC55U9iGh4cklrPvdx6XXEvtJpUKOU+2onpFZAGeHkbNUT2+n7jsdd0mi4p9lsTr B/aQWDbOhZL8xeNN3bsdyR+oEh44dvqtVOsCMd8dJL51hvYThwkraxHdaoPZEmzLWA19 a93iPMHtP/2kRXw4RCrC++dinfPkFrlH1Amnii3+/UedzqSTXMD5Wvqjfi7uJnjt5xIm FSjV0UQlQuSQr81L21cfBKtSZrxGL+Q8p3b5SIOWg1A3ozF0DLrjgw3U3bSLxnGC9HS5 i8Ri3jY5Y4beuqSx9uVBXqceU24GyvZhc4wq5ueLHgDKt7HJAOrW4WjMeVC3AiX64Dr2 ncUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794924344; x=1795529144; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=evA50aPqc3DFC7OnsafBK/uchzbfQmhK+e2vPkGMqcw=; b=KpjQttnSSPUVUkh8Y+l/7nRlR1I7SjIO4BdWmHgLUHmYBY6BEamAyoNRbta8CMqjSL lmKLKKerBAyEAgWNpA3hruRXXj/AN8UDqSR7sO2oQk+MN1yVP2xaUSEihzlmrDBg3IXW IwJkl5mfn4RyQ/q7zglCO4ROLbchghdewlMJBHhyzU2jLx74FR/SGy7wdesqmM7iwwrL pcLF6W/H/jJrwTipsPr5aOBXS3HruJwN7fLGZGowMGLxvByB3V5KGDaMS1QHB5Uz7MJC d2Lc72kt7U/nxdIhhi95WehTH5/eGp2PwnKMdfKWdAdSkcOBewndF2ytq8mYarcgzQiH hYRQ== X-Forwarded-Encrypted: i=1; AL+hErEDjyKT0eqYpjgahHqYMGCQnZuj8E0ylkMAMTA/VWVcNt5DzLsI5QVn3MP9epKDqbyMnw5qd6XMo3A4deM=@vger.kernel.org X-Gm-Message-State: APuU4Z+6iqmcxVo9Ko/fvfb6JESy5OKEbRofldKQT1MI746xVcCeSnV5 Yw+/7j1SOHf0qHymJp0fl4F8mgfePT/snYMavZXDDI7Ipk2gNz3h23IB X-Gm-Gg: AZFdTZfj58iPyeHaMSDObDkKd8M/LLXD/3KxS2mBAtAHzIRgEQPxMqI1yga/rNST9Tz daXNgA/it+Lgsz/y6EJQRy84MZd2mI+/q/jgBulB8J2VajGycCfoS/oJqW5PqqXIj68kOHGyLUE GcnN9hJJLnQrY7bVUhtfESWSP1YtCsI/9LUxS9CoRbZjLprogPO6H1yXaRuEPhOVzH2LSEQILk8 Q3P4bdsUrLUhe4ypySide9MBwQykoiV+Zs1jLO/HAmCd4uerjv2SYs8//Q7Sln8+o+DSrFxnKON 7qvRvFyJdKfL/OIqAXfZWn82WQj2veDvAVP6NhxIGFXb5JFrCpu6cHI5k0mBegwPToxMeyq+9aW ML73uRBTiz6oW+3h32Q/f7jzfEKz5TZHfVZ8XDOuBns+bpYPAduAEbGgNbeLyKnvqtKx+UuR+hg 3PuK5TdMKrTfNCiKnmU40a1u1pJAsN9S1PwAb6ECzlWILemo01ESdKKI/FDWKjQlupyowk08ata qTL4v1Oc0gP/a0cSvbuVx7k2TG+NsmP1fE7weW/nMon32sOzPzYmNArbXrAd/7muP+LThCS/ykU ZoV9QXsXIoO1s0gnBcBOE+DiALYDtc6kEXFAiQ== X-Received: by 2002:a5d:59c9:0:b0:48e:bf0:352 with SMTP id ffacd0b85a97d-49c6e68da9amr31383557f8f.5.1794924343919; Tue, 17 Nov 2026 06:05:43 -0800 (PST) Received: from fedora ([154.183.162.73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a4de4cb1c3sm2623032f8f.8.2026.11.17.06.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 06:05:42 -0800 (PST) From: Abdelnasser Hussein To: jic23@kernel.org, linux-iio@vger.kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, giorgitchankvetadze1997@gmail.com, amin.gattout@gmail.com, antoniu.miclaus@analog.com, gregkh@linuxfoundation.org, mripard@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abdelnasser Hussein Subject: [PATCH v4 1/3] iio: adc: at91_adc: fix NULL pointer dereference on trigger remove Date: Tue, 17 Nov 2026 16:05:08 +0200 Message-ID: <20261117140510.391907-2-abdelnasserhussein11@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261117140510.391907-1-abdelnasserhussein11@gmail.com> References: <20261117140510.391907-1-abdelnasserhussein11@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the "atmel,adc-use-external-triggers" property is not set in the Device Tree, at91_adc_trigger_init() skips the external trigger slots and leaves the corresponding entries in st->trig as NULL. In the error rollback path of at91_adc_trigger_init() and in at91_adc_trigger_remove(), iio_trigger_unregister() and iio_trigger_free() are called on every slot without checking for NULL, causing a NULL pointer dereference whenever an external trigger slot was skipped, either because of a partial allocation failure or because the external triggers are simply not used. Skip NULL trigger slots in both teardown loops so that only triggers that were actually allocated are unregistered and freed. Fixes: 0e589d5fb317 ("ARM: AT91: IIO: Add AT91 ADC driver.") Signed-off-by: Abdelnasser Hussein --- drivers/iio/adc/at91_adc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c index 0ac74ad92fca..c7fc06214c05 100644 --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -660,6 +660,8 @@ static int at91_adc_trigger_init(struct iio_dev *idev) error_trigger: for (i--; i >= 0; i--) { + if (!st->trig[i]) + continue; iio_trigger_unregister(st->trig[i]); iio_trigger_free(st->trig[i]); } @@ -673,6 +675,8 @@ static void at91_adc_trigger_remove(struct iio_dev *idev) int i; for (i = 0; i < st->caps->trigger_number; i++) { + if (!st->trig[i]) + continue; iio_trigger_unregister(st->trig[i]); iio_trigger_free(st->trig[i]); } -- 2.56.0