mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: Alice Ryhl <aliceryhl@google.com>,
	boqun@kernel.org, gary@garyguo.net,  lyude@redhat.com,
	daniel.almeida@collabora.com, work@onurozkan.dev,
	 ojeda@kernel.org, bjorn3_gh@protonmail.com, lossin@kernel.org,
	 a.hindborg@kernel.org, tmgross@umich.edu, tamird@kernel.org,
	 acourbot@nvidia.com, viro@zeniv.linux.org.uk,
	brauner@kernel.org,  jack@suse.cz, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org,  linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] rust: sync: condvar: use task::schedule_timeout()
Date: Tue, 17 Nov 2026 14:16:52 +0000	[thread overview]
Message-ID: <20261117141652.2992350-1-aliceryhl@google.com> (raw)
In-Reply-To: <20261117001507.1611984-5-dakr@kernel.org>

On Tue, Nov 17, 2026 at 01:14:45AM +0100, Danilo Krummrich wrote:
> @@ -122,7 +121,11 @@ fn wait_internal<T: ?Sized, B: Backend>(
>      /// [`CondVar::notify_one`] or [`CondVar::notify_all`]. Note that it may also wake up
>      /// spuriously.
>      pub fn wait<T: ?Sized, B: Backend>(&self, guard: &mut Guard<'_, T, B>) {
> -        self.wait_internal(TASK_UNINTERRUPTIBLE, guard, MAX_SCHEDULE_TIMEOUT);
> +        self.wait_internal(
> +            TASK_UNINTERRUPTIBLE,
> +            guard,
> +            Delta::from_jiffies(task::MAX_SCHEDULE_TIMEOUT),
> +        );
>      }

Now that `CondVar` uses `task::schedule_timeout()`, all remaining uses of
`task::MAX_SCHEDULE_TIMEOUT` wrap it in `Delta::from_jiffies(...)`, so we
could also change `MAX_SCHEDULE_TIMEOUT` itself to `Delta<Jiffy>` (either
if you spin a v4 or as a follow-up). Either way:

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Alice

  reply	other threads:[~2026-11-17 14:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  0:14 [PATCH v3 0/5] rust: sync: add WaitQueue infrastructure Danilo Krummrich
2026-11-17  0:14 ` [PATCH v3 1/5] rust: task: add safe schedule_timeout() wrapper Danilo Krummrich
2026-11-17  0:45   ` FUJITA Tomonori
2026-11-17 11:40     ` Gary Guo
2026-11-17 11:56       ` Danilo Krummrich
2026-11-17 12:02         ` Gary Guo
2026-11-17 13:14           ` Danilo Krummrich
2026-11-17 14:16   ` Alice Ryhl
2026-11-17  0:14 ` [PATCH v3 2/5] rust: sync: add WaitQueue infrastructure Danilo Krummrich
2026-11-17 11:59   ` Gary Guo
2026-11-17 14:16   ` Alice Ryhl
2026-11-17  0:14 ` [PATCH v3 3/5] rust: sync: convert CondVar and PollCondVar to use WaitQueue Danilo Krummrich
2026-11-17 14:16   ` Alice Ryhl
2026-11-17  0:14 ` [PATCH v3 4/5] rust: sync: condvar: use task::schedule_timeout() Danilo Krummrich
2026-11-17 14:16   ` Alice Ryhl [this message]
2026-11-17  0:14 ` [PATCH v3 5/5] rust: sync: condvar: add non-exclusive freezable waiting Danilo Krummrich
2026-11-17 14:16   ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117141652.2992350-1-aliceryhl@google.com \
    --to=aliceryhl@google.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=brauner@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®