From: Pavel Artemev <a@pavel.bz>
To: Takashi Iwai <tiwai@suse.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] ALSA: usb-audio: drive XiiSound playback volume instead of skipping it
Date: Tue, 17 Nov 2026 21:33:13 +0700 [thread overview]
Message-ID: <20261117143314.41853-2-a@pavel.bz> (raw)
In-Reply-To: <20261117143314.41853-1-a@pavel.bz>
Replace the XiiSound (040b:0897) playback feature unit workaround from
commit ba9bccdf711a ("ALSA: usb-audio: Skip broken playback feature unit
on XiiSound chips") with quirk flags that keep the unit exposed and make
its hardware volume work.
Wire-level captures (usbmon on Linux, USBPcap on the vendor's own
Windows 10 stack) show the playback feature unit is functional as a
hardware volume: per-channel SET_CUR writes apply deterministically and
independently (a fast pair CN1<-50 + CN2<-100 applies exactly; a lone
channel write does not disturb its sibling), the master channel gates
both ears symmetrically, and intermediate values are audible and graded.
The vendor's Windows driver drives exactly this unit on every slider and
hardware-button step, writing all three channels with plain 0..100 raw
values mapped linearly from its slider.
The "any volume below the maximum mutes one or both channels" behaviour
that motivated the skip is host-side, not firmware:
* the unit advertises a bogus 0.00..0.39 dB range, under which every
user-space volume at or below 0 dB - the whole normal PipeWire
range, 100% included - resolves to the raw minimum, which silences
the channel;
* the stereo volume control's GET_CUR returns a constant value, so
the sanity check classifies it as broken and init_cur_mix_raw()
writes the minimum to both channels at every mixer build;
* user space applies one logical volume change as fragmented writes
(one per channel, the first carrying the stale sibling value), and
these devices silently drop control writes in the first seconds
after enumeration, so a channel can be left behind at a stale
value that no later write corrects.
Enable three quirk flags for 040b:0897. The new
QUIRK_FLAG_MIXER_INIT_VOLUME_MAX makes init_cur_mix_raw() initialize the
channels of volume controls to the maximum instead of the minimum: it
runs exactly where the broken-GET minimum writes would, supersedes them
(also when range discovery is deferred with -EAGAIN and initialization
repeats later from mixer_ctl_feature_info()), and touches nothing else -
controls whose GET_CUR works are read, not written, and switches keep
the safe unmuted minimum. The existing MIXER_PLAYBACK_LINEAR_VOL and
MIXER_CAPTURE_LINEAR_VOL replace the bogus dB scale with a linear one,
so user-space volumes map onto the full raw range. The controls stay
writable; hardware volume then behaves like on Windows.
The create-time pin writes of the previous quirk sit inside that
post-enumeration write-loss window and are dropped along with every
other early write; the device comes up audible after a plug only
because it powers up with every volume channel at the maximum, which
the explicit init reproduces if a write ever does land. No separate
resume re-pin is needed: with the controls created, the standard mixer
resume path restores the cached values.
Testing: the same flag combination ran on the device as a locally
built DKMS module against a 7.2 tree through a wire-level verification
campaign: the initialization writes were observed on the bus at every
mixer build, the full raw range became reachable from PipeWire (route
volumes 0/13/100 for 0.0/0.5/1.00), and mute and balance track. This
exact tree also ran on the device as a DKMS module against 7.3.4: the
broken-GET stereo control is initialized to the maximum in place of
the minimum, the other controls are read but not written, and the
linear raw mapping holds (route volume restores landed as 13/100/35
on the bus for 0.5/1.0/0.7).
Closes: https://github.com/alsa-project/alsa-ucm-conf/issues/760
Closes: https://github.com/linuxmint/linuxmint/issues/822
Link: https://bugzilla.kernel.org/show_bug.cgi?id=221401
Link: https://lore.kernel.org/linux-sound/20261116153521.188570-2-a@pavel.bz
Assisted-by: LLM
Signed-off-by: Pavel Artemev <a@pavel.bz>
---
Documentation/sound/alsa-configuration.rst | 4 ++
sound/usb/mixer.c | 13 ++++-
sound/usb/mixer_maps.c | 19 -------
sound/usb/mixer_quirks.c | 59 ----------------------
sound/usb/quirks.c | 5 ++
sound/usb/usbaudio.h | 11 ++++
6 files changed, 32 insertions(+), 79 deletions(-)
diff --git a/Documentation/sound/alsa-configuration.rst b/Documentation/sound/alsa-configuration.rst
index 689eccf6a..ea7f5aa31 100644
--- a/Documentation/sound/alsa-configuration.rst
+++ b/Documentation/sound/alsa-configuration.rst
@@ -2413,6 +2413,10 @@ quirk_flags
versa (same for 88200 <-> 96000 and 176400 <-> 192000). The driver
sends the partner rate in SET_CUR so the device ends up running at the
requested one.
+ * bit 34: ``mixer_init_volume_max``
+ Initialize the volume control channels to the maximum value instead
+ of the minimum at mixer creation. For devices that silence their
+ audio path while a volume channel sits at the minimum value.
This module supports multiple devices, autoprobe and hotplugging.
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index 95209ec00..bf1d9fbf0 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -1310,7 +1310,18 @@ static void init_cur_mix_raw(struct usb_mixer_elem_info *cval, int ch, int idx)
"%d:%d: failed to get current value for ch %d (%d)\n",
cval->head.id, mixer_ctrl_intf(cval->head.mixer),
ch, err);
- snd_usb_set_cur_mix_value(cval, ch, idx, cval->min);
+ /*
+ * QUIRK_FLAG_MIXER_INIT_VOLUME_MAX: some devices silence an audio
+ * path while a volume channel sits at the minimum value, so
+ * initialize those to the maximum instead. Only volume controls:
+ * for switches the minimum is the safe (unmuted) value.
+ */
+ if ((cval->head.mixer->chip->quirk_flags &
+ QUIRK_FLAG_MIXER_INIT_VOLUME_MAX) &&
+ cval->control == UAC_FU_VOLUME)
+ snd_usb_set_cur_mix_value(cval, ch, idx, cval->max);
+ else
+ snd_usb_set_cur_mix_value(cval, ch, idx, cval->min);
}
/*
diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
index 9218ca631..98b414621 100644
--- a/sound/usb/mixer_maps.c
+++ b/sound/usb/mixer_maps.c
@@ -374,20 +374,6 @@ static const struct usbmix_name_map dell_alc4020_map[] = {
{ 0 }
};
-/*
- * Weltrend XiiSound chips (040b:0897, e.g. Redragon H878):
- * the playback feature unit is broken; its volume controls act like
- * mute switches below the maximum value and the channel mapping is
- * unreliable, so any hardware volume change mutes one or both
- * channels. Skip the unit entirely and let userspace fall back to
- * software volume; the unit is pinned to maximum/unmuted by the
- * mixer quirk in mixer_quirks.c.
- */
-static const struct usbmix_name_map xiisound_map[] = {
- { 5, NULL }, /* playback feature unit */
- { 0 }
-};
-
/*
* Corsair Virtuoso calls everything "Headset" without this, leading to
* applications moving the sidetone control instead of the main one.
@@ -804,11 +790,6 @@ static const struct usbmix_ctl_map usbmix_ctl_maps[] = {
.id = USB_ID(0x1395, 0x0025),
.map = sennheiser_pc8_map,
},
- {
- /* Weltrend XiiSound (Redragon H878) */
- .id = USB_ID(0x040b, 0x0897),
- .map = xiisound_map,
- },
{
/* Microsoft USB Link headset */
.id = USB_ID(0x045e, 0x083c),
diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
index 4c7d68311..583971944 100644
--- a/sound/usb/mixer_quirks.c
+++ b/sound/usb/mixer_quirks.c
@@ -4603,59 +4603,6 @@ static int snd_audiofuse_controls_create(struct usb_mixer_interface *mixer)
return err;
}
-/*
- * Weltrend XiiSound chips (040b:0897, e.g. Redragon H878):
- * the playback feature unit (id 5) is broken; its volume controls act like
- * mute switches below the maximum value and the channel mapping is
- * unreliable, so the unit is hidden from userspace entirely (see the
- * quirk in mixer_maps.c) and userspace falls back to software volume.
- * Pin the unit's master and channel volumes to the reported maximum
- * and unmute them, so the audio path stays fully open.
- */
-static int snd_xiisound_init_fu_pins(struct usb_mixer_interface *mixer)
-{
- struct snd_usb_audio *chip = mixer->chip;
- unsigned char buf[2];
- int ifnum, ch, err;
-
- if (mixer->protocol != UAC_VERSION_1)
- return 0;
-
- ifnum = snd_usb_ctrl_intf(chip->ctrl_intf);
-
- /* unit 5 is the playback feature unit on these chips */
- for (ch = 0; ch <= 2; ch++) {
- err = snd_usb_ctl_msg(chip->dev, usb_rcvctrlpipe(chip->dev, 0),
- UAC_GET_MAX,
- USB_DIR_IN | USB_TYPE_CLASS |
- USB_RECIP_INTERFACE,
- (UAC_FU_VOLUME << 8) | ch,
- (5 << 8) | ifnum, buf, 2);
- if (err < 2)
- return 0; /* no such unit/channels, nothing to pin */
-
- err = snd_usb_ctl_msg(chip->dev, usb_sndctrlpipe(chip->dev, 0),
- UAC_SET_CUR,
- USB_DIR_OUT | USB_TYPE_CLASS |
- USB_RECIP_INTERFACE,
- (UAC_FU_VOLUME << 8) | ch,
- (5 << 8) | ifnum, buf, 2);
- if (err < 0)
- return err;
-
- buf[0] = 0; /* unmute */
- err = snd_usb_ctl_msg(chip->dev, usb_sndctrlpipe(chip->dev, 0),
- UAC_SET_CUR,
- USB_DIR_OUT | USB_TYPE_CLASS |
- USB_RECIP_INTERFACE,
- (UAC_FU_MUTE << 8) | ch,
- (5 << 8) | ifnum, buf, 1);
- if (err < 0)
- return err;
- }
- return 0;
-}
-
int snd_usb_mixer_apply_create_quirk(struct usb_mixer_interface *mixer)
{
int err = 0;
@@ -4669,9 +4616,6 @@ int snd_usb_mixer_apply_create_quirk(struct usb_mixer_interface *mixer)
case USB_ID(0x0644, 0x8047):
err = snd_us16x08_controls_create(mixer);
break;
- case USB_ID(0x040b, 0x0897):
- err = snd_xiisound_init_fu_pins(mixer);
- break;
case USB_ID(0x041e, 0x3020):
case USB_ID(0x041e, 0x3040):
case USB_ID(0x041e, 0x3042):
@@ -4863,9 +4807,6 @@ void snd_usb_mixer_resume_quirk(struct usb_mixer_interface *mixer)
case USB_ID(0x0bda, 0x4014): /* Dell WD15 dock */
dell_dock_mixer_init(mixer);
break;
- case USB_ID(0x040b, 0x0897): /* Weltrend XiiSound (Redragon H878) */
- snd_xiisound_init_fu_pins(mixer);
- break;
}
}
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index a4eb0d0cd..6ef6d4410 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2502,6 +2502,10 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
QUIRK_FLAG_FIXED_RATE),
DEVICE_FLG(0x03f0, 0x654a, /* HP 320 FHD Webcam */
QUIRK_FLAG_GET_SAMPLE_RATE | QUIRK_FLAG_MIC_RES_16),
+ DEVICE_FLG(0x040b, 0x0897, /* XiiSound/Weltrend Temple and rebranded headsets */
+ QUIRK_FLAG_MIXER_INIT_VOLUME_MAX |
+ QUIRK_FLAG_MIXER_PLAYBACK_LINEAR_VOL |
+ QUIRK_FLAG_MIXER_CAPTURE_LINEAR_VOL),
DEVICE_FLG(0x041e, 0x3000, /* Creative SB Extigy */
QUIRK_FLAG_IGNORE_CTL_ERROR),
DEVICE_FLG(0x041e, 0x324d, /* Creative Sound Blaster Play! 3 */
@@ -2979,6 +2983,7 @@ static const char *const snd_usb_audio_quirk_flag_names[] = {
QUIRK_STRING_ENTRY(PLAYBACK_URB_FIXUP),
QUIRK_STRING_ENTRY(ALWAYS_SET_RATE),
QUIRK_STRING_ENTRY(SWAP_RATES),
+ QUIRK_STRING_ENTRY(MIXER_INIT_VOLUME_MAX),
NULL
};
diff --git a/sound/usb/usbaudio.h b/sound/usb/usbaudio.h
index c6d59218d..61794fdc4 100644
--- a/sound/usb/usbaudio.h
+++ b/sound/usb/usbaudio.h
@@ -262,6 +262,15 @@ extern bool snd_usb_skip_validation;
* The device applies a requested sample rate to the other base-rate family
* (44100 <-> 48000, 88200 <-> 96000, 176400 <-> 192000). Send the partner
* rate in SET_CUR so that the device runs at the requested rate.
+ * QUIRK_FLAG_MIXER_INIT_VOLUME_MAX
+ * A Feature Unit volume channel left at the minimum value silences its
+ * audio path on some devices; user space that does not write all
+ * channels of such a control would leave the device silent. Where
+ * GET_CUR is broken the kernel additionally discards the test values
+ * and initializes the channels to the minimum at every mixer build.
+ * Initialize the volume control channels to the maximum instead of
+ * the minimum; the controls remain writable and the hardware volume
+ * operates normally afterwards.
*/
enum {
@@ -299,6 +308,7 @@ enum {
QUIRK_TYPE_PLAYBACK_URB_FIXUP = 31,
QUIRK_TYPE_ALWAYS_SET_RATE = 32,
QUIRK_TYPE_SWAP_RATES = 33,
+ QUIRK_TYPE_MIXER_INIT_VOLUME_MAX = 34,
/* Please also edit snd_usb_audio_quirk_flag_names and alsa-configuration.rst */
};
@@ -338,5 +348,6 @@ enum {
#define QUIRK_FLAG_PLAYBACK_URB_FIXUP QUIRK_FLAG(PLAYBACK_URB_FIXUP)
#define QUIRK_FLAG_ALWAYS_SET_RATE QUIRK_FLAG(ALWAYS_SET_RATE)
#define QUIRK_FLAG_SWAP_RATES QUIRK_FLAG(SWAP_RATES)
+#define QUIRK_FLAG_MIXER_INIT_VOLUME_MAX QUIRK_FLAG(MIXER_INIT_VOLUME_MAX)
#endif /* __USBAUDIO_H */
base-commit: f930156051f6a3dcd454ff723ca36b14d49650d2
--
2.56.1
next prev parent reply other threads:[~2026-11-17 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 14:33 [RFC PATCH v5 0/2] ALSA: usb-audio: working hardware volume for XiiSound headsets (040b:0897) Pavel Artemev
2026-11-17 14:33 ` Pavel Artemev [this message]
2026-11-17 14:33 ` [PATCH 2/2] ALSA: usb-audio: add MIXER_STATE_REPUSH quirk flag Pavel Artemev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117143314.41853-2-a@pavel.bz \
--to=a@pavel.bz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®