From: Leon Romanovsky <leon@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Willy Tarreau <w@1wt.eu>, Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Theodore Ts'o <tytso@mit.edu>,
David Hildenbrand <david@kernel.org>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: submitting-patches: ask bug fixes for their user-visible impact
Date: Tue, 17 Nov 2026 17:27:21 +0200 [thread overview]
Message-ID: <20261117152721.GC162713@unreal> (raw)
In-Reply-To: <avxtxScVa9KvUH_K@laps>
On Tue, Nov 17, 2026 at 10:07:49AM -0500, Sasha Levin wrote:
> On Tue, Nov 17, 2026 at 11:27:23AM +0200, Leon Romanovsky wrote:
> > On Mon, Nov 16, 2026 at 03:05:15PM -0500, Sasha Levin wrote:
> > > "Describe your changes" already asks for the user-visible impact of a
> > > change, but changelogs for fixes still tend to say what the code does,
> > > why that's wrong and what the patch changes, and stop there. Whoever
> > > has to decide if the fix needs backporting is left to work out what
> > > the bug does to a running system.
> > >
> > > Say what that means for a bug fix, in two parts. For users who aren't
> > > looking for the bug: what a normal workload is likely to run into, and
> > > separately the worst case and what it takes to get there. For someone
> > > triggering it on purpose: whether an unprivileged user could do it and
> > > what that would take, since a race that no real workload loses can
> > > still be won by a program written to win it. Give the paragraph a
> > > label so people can be pointed at it.
> > >
> > > Coding assistants are told to commit a fix with a message that
> > > describes the problem and the solution. Add the user-visible impact to
> > > that list and point them at the section.
> > >
> > > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > > Link: https://lore.kernel.org/r/20261111171055.527b4bf3da705367bc78a64c@linux-foundation.org
> > > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > > Acked-by: Andrew Morton <akpm@linux-foundation.org>
> > > Reviewed-by: Willy Tarreau <w@1wt.eu>
> > > ---
> > > Changes since v1:
> > > - Split the bug-fix paragraph into users who aren't looking for the bug
> > > and someone triggering it on purpose (Andrew, Willy).
> > >
> > > v1: https://lore.kernel.org/r/20261116191436.188098-1-sashal@kernel.org
> > >
> > > Documentation/process/coding-assistants.rst | 6 +++--
> > > Documentation/process/submitting-patches.rst | 23 ++++++++++++++++++++
> > > 2 files changed, 27 insertions(+), 2 deletions(-)
> >
> > Sasha,
> >
> > Since you're already making changes in that area, could you add a sentence
> > asking reporters to provide the full dmesg stack trace?
>
> In this doc, we already ask them not to [1] :)
This is really bad. You assumed they would trim the logs correctly, and I,
as the recipient was expected to trust that they were accurate. They are not.
They trim everything, which makes these logs useless to me. As I said, they
include AI-generated reports, cases with reproductions that are impossible
with upstream code, and reports for completely out-of-tree code. Everything
like that was visible in original dump stack and it is lost now.
>
> > Many AI-generated patches reduce it to one or two lines, which gives no
> > indication of whether the report is genuine or fabricated. Early in the AI
> > era, I saw some completely fabricated stack traces.
>
> Is it still an issue?
I don't know about faked, but useless yes, especially in the cases where
in-kernel API is involved.
> We could add something explicit in coding-assistants.rst,
> like:
>
> Evidence
> ========
>
> Every claim an AI assistant makes about the kernel's behavior at runtime,
> including backtraces, log excerpts, test results and measurements, **MUST** be
> backed by an observation from a real run.
It won't help, they already overcome it by saying "Found by static
analysis tool ...".
Thanks
>
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n760
>
> --
> Thanks,
> Sasha
next prev parent reply other threads:[~2026-11-17 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 20:05 Sasha Levin
2026-11-17 9:00 ` Greg Kroah-Hartman
2026-11-17 9:27 ` Leon Romanovsky
2026-11-17 15:07 ` Sasha Levin
2026-11-17 15:27 ` Leon Romanovsky [this message]
2026-11-17 16:03 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117152721.GC162713@unreal \
--to=leon@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=w@1wt.eu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®