From: Sumit Gupta <sumitg@nvidia.com>
To: <rafael@kernel.org>, <viresh.kumar@linaro.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <zhongqiu.han@oss.qualcomm.com>,
<conor+dt@kernel.org>, <treding@nvidia.com>,
<jonathanh@nvidia.com>, <linux-pm@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: <bbasu@nvidia.com>, <sumitg@nvidia.com>
Subject: [PATCH v2 5/9] cpufreq: tegra194: split MMIO mapping from ACTMON offset
Date: Tue, 17 Nov 2026 21:19:50 +0530 [thread overview]
Message-ID: <20261117154954.625126-6-sumitg@nvidia.com> (raw)
In-Reply-To: <20261117154954.625126-1-sumitg@nvidia.com>
Probe maps the CCPLEX registers only when actmon_cntr_base is set. This
has worked so far because each SoC uses one interface for both
requesting and reading frequency. Tegra234/238 use MMIO, and Tegra194
uses system registers.
Tegra264 requests frequency through MMIO but reads its counters from
system registers. It needs the mapping but has no ACTMON counters.
Add a needs_mmio flag so the mapping no longer depends on
actmon_cntr_base.
No functional change.
Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
---
drivers/cpufreq/tegra194-cpufreq.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
index 1a5b78ff2c4a..e12e02d14d73 100644
--- a/drivers/cpufreq/tegra194-cpufreq.c
+++ b/drivers/cpufreq/tegra194-cpufreq.c
@@ -71,6 +71,7 @@ struct tegra_cpufreq_soc {
u64 cnt_mask;
int maxcpus_per_cluster;
unsigned int num_clusters;
+ bool needs_mmio;
phys_addr_t actmon_cntr_base;
u32 refclk_delta_min;
};
@@ -222,6 +223,7 @@ static struct tegra_cpufreq_ops tegra234_cpufreq_ops = {
static const struct tegra_cpufreq_soc tegra234_cpufreq_soc = {
.ops = &tegra234_cpufreq_ops,
.cnt_mask = U32_MAX,
+ .needs_mmio = true,
.actmon_cntr_base = 0x9000,
.maxcpus_per_cluster = 4,
.num_clusters = 3,
@@ -231,6 +233,7 @@ static const struct tegra_cpufreq_soc tegra234_cpufreq_soc = {
static const struct tegra_cpufreq_soc tegra238_cpufreq_soc = {
.ops = &tegra234_cpufreq_ops,
.cnt_mask = U32_MAX,
+ .needs_mmio = true,
.actmon_cntr_base = 0x4000,
.maxcpus_per_cluster = 8,
.num_clusters = 1,
@@ -739,8 +742,7 @@ static int tegra194_cpufreq_probe(struct platform_device *pdev)
if (!data->bpmp_luts)
return -ENOMEM;
- if (soc->actmon_cntr_base) {
- /* mmio registers are used for frequency request and re-construction */
+ if (soc->needs_mmio) {
data->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(data->regs))
return PTR_ERR(data->regs);
--
2.34.1
next prev parent reply other threads:[~2026-11-17 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 15:49 [PATCH v2 0/9] cpufreq: tegra194: add Tegra264 support Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 1/9] cpufreq: tegra194: move MPIDR read to CPU hotplug callback Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 2/9] cpufreq: tegra194: remove duplicate counter sampling loops Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 3/9] cpufreq: tegra194: add tegra_counter_delta helper Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 4/9] cpufreq: tegra194: add per-SoC counter mask Sumit Gupta
2026-11-17 15:49 ` Sumit Gupta [this message]
2026-11-17 15:49 ` [PATCH v2 6/9] dt-bindings: arm: nvidia: Document the Tegra264 CCPLEX cluster Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 7/9] cpufreq: tegra194: derive frequency domain from device tree Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 8/9] cpufreq: tegra194: Add support for Tegra264 Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 9/9] arm64: tegra: Add CCPLEX cluster node " Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117154954.625126-6-sumitg@nvidia.com \
--to=sumitg@nvidia.com \
--cc=bbasu@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=treding@nvidia.com \
--cc=viresh.kumar@linaro.org \
--cc=zhongqiu.han@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®