From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794935409; b=oIfOOXtk+1sqFkmmfZQAB9OTlIV1y/0ncj4rFYFD8MsafcjLxzdxzo4NEuZcs0MhLUan 57nSiy4xZU7jpi0x7Qp7+Cc67SCiuaAFeEgisuQ0RMlSIzdq2Nnb/OXo3mBmg0fU16x4m xs3rdfGrWlaEB7jjRS/SBv9MBlypeuea6Oy+RRkQ+x2Sc0dbLr1AiANmQwOnWebFeISJ8 w2E5nQuN4+F0GIFJSnyhBDhPfj5ItKnXUrdEi4lMhXl0YJGU0+0EHO+N5SK0Mwa+iS8xR A2et7VIqNlPFJ1npwGqs+d5ECvJmpU4hcws5wXeV2IQYlpq4cpdPPCvuisxSFj7qsUA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794935409; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=qjjJXnvyNTC6yhXiM0fu7sw9ftTlNutzFX7AfJ2F8JE=; b=NBd3XhtNJAFyiinc47xaN9Qpznbj5xyNpi3yaCWJAq5zVFhcmXpDm04CXlMfzkyWMmiX KyFqUhZdW+2SRsTGrZb3na0LQXV6g6Bgq1rITbhX8rJlpnbG+tlLsnopfKPr+Ruh/9h3o aOURgUoe/G+PeXZ00SAFQ63hOAr5ktko7NjMPsvlUPdlo+ky0NJabplKhtULWrxKsUNxM nqm7PzvnwmTm9Bx1Riwt97UAdgqHJfb1u34LydLzQbqYaIoMTDQ5EUEL9FKJk/gXZA2vz /WsBCyAZd7e1Y2pCjBLnk3gRvPapDm72ON5n/dt8muwin0e/Xab3MkasNBXtLzy4GpA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=NItphpPY; arc=none smtp.remote-ip=209.85.221.45 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEFB8606A336 for ; Tue, 17 Nov 2026 17:10:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BEFB8606A336 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=NItphpPY Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-490d59c3f0aso2106148f8f.1 for ; Tue, 17 Nov 2026 09:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794935407; x=1795540207; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qjjJXnvyNTC6yhXiM0fu7sw9ftTlNutzFX7AfJ2F8JE=; b=NItphpPYmKitsve4LK2rGhJAu79jbF6rTYkjsOEvXBvQ+nMB8l0fhbDAHahWHudihA rmY9ZtTFTXu+9eVZzeFxjH6m/GC7pnnXlMIguVpdHXS4KoxMbXzfMxD3ovOJXoNtBCUk xAIeYqC+mqd9cK/RehXH8OCI2YdF6L5e2xs4L1GvNdGhXe3LkmiS7Lqf+qlUPnXxzryy BsmbeU3bLSii6DB3wNJGUqaMIeW+MfiU1it0DZYjq6eataDwL6w9uPt/2qmA0Ay+CrWF s+FCiZpfYkbuFXWXhJ04Wy7sJEZnl5UNKgzlz0EsmqBteODRaTbdy9bgosSkfCZdrMrM LkiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794935407; x=1795540207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qjjJXnvyNTC6yhXiM0fu7sw9ftTlNutzFX7AfJ2F8JE=; b=gPBisfTu3FGRVUxQnziNjQqGDtpFf6+hhKhoxb5RfCb3zeRMXHy36prPi+tCC+ikOI OMZ1HJTa2bDfAj8Hkaxqw1AX3z9TGB4t1WS1i/I6aVsieXv7IdYFLSkLnW79JzdwTdx8 qU5f8SUO0TWNoH6rrJP1JMBx9BbsFyWFmBf55zauuLh4NobttKbV5xvhYY0yhdmEYEXR wZk/Q47y3PS78cz3lPnLg/iQ8W3cLulLtL3mlR8QlnY61rz6Hfw1uNddeP5LRqZMMZ44 qiFmv53S77yyqfSl4B4Vl9FDits+SFuF7IXNVAtNXdNFhbLSIr8rq32S1JjIa0JdC04X nrTw== X-Forwarded-Encrypted: i=1; AL+hErFK+AM9Uf1mwKvUiACEAnATc6ZAyCR5akphCI1LEX3xKr7n3MMRdfCoAqc1vAVm7wDGc4AE30hrd69cHPk=@vger.kernel.org X-Gm-Message-State: APuU4Z+8n1c/e+hapLk5HXLCswl66BOK+I/M/p1/646RALgZ24UJvf7h RIMx6Vi4i7hsW3X4ce6DQrPhiNy1PhNKCIBd2iDDEO8eGVMgB4agSCbm X-Gm-Gg: AZFdTZcHML78cBlYp9GBiWGFhxDtvp0iRbXInBvzSWO3znS5riYSb6cGwrLuPZJqeV/ qqf5o7uF9/uzUnQcRVHNFku+GT0ow5LibuUFWuXNo5qPkCznbq60UWOsCgcKPYgAAY4CfjC5whe e+FlIwRrWPgO98jWv+QHTr99q3+WqvqM/k4QJJ7uhsbjcJ46rpqtYAaJUYJQbsRcEOiuiJJKS7/ GihEjocS3ll0Z2sPtgcw/TsHBlIb72Kwvpb2GOd8cPqol1pkqF6joJH+WQXROwczudED4WVmLbV 85oTkHCQPnCunzIIcT0DppqDIf6AnWl/x+Fkn9JbDYD05JPjoDnjvCgdaEI7Biiq1YnW+ZLjIlP Wz3QgiytYq1yfHV4JQHfrbxyaMy3gW54PP5e+Ex9uOroMtD1og0NLvhVwghRs+GKZFuudVSxXm3 wVxLdxHA3wJlYvKTkbbSG/6ou4C87ADtYW8OpXNcwbS9/s0KI5zD6VtQdxX9KiHAf5i46wG+X/I J5tAVDtnDniRDFWrqeAcYWfY+WSrxuZYblRuYDBwjdUJOav6vsNQO0rNC3KE+/s8BceiLibsXp+ ynt2lFd6uahK9PQKKV1+JfSQquBlWbGfMoY= X-Received: by 2002:a05:6000:25c6:b0:49d:7e8c:e89c with SMTP id ffacd0b85a97d-4a63d985dc9mr94898f8f.42.1794935407126; Tue, 17 Nov 2026 09:10:07 -0800 (PST) Received: from deb05.proceq.com ([213.160.61.66]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49c6d079a2asm26828762f8f.16.2026.11.17.09.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 09:10:06 -0800 (PST) From: Mehmet Fide To: Ping-Ke Shih Cc: Luka Gejak , Sascha Hauer , Zong-Zhe Yang , Tzu-En Huang , Yan-Hsuan Chuang , Kalle Valo , Stanislaw Gruszka , Brian Norris , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, mehmet.fide@screeningeagle.com Subject: [PATCH rtw-next v3 2/5] wifi: rtw88: report the frames purged from the TX report queue Date: Tue, 17 Nov 2026 18:10:00 +0100 Message-ID: <20261117171003.1840491-3-mehmet.fide@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261117171003.1840491-1-mehmet.fide@gmail.com> References: <20261117171003.1840491-1-mehmet.fide@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mehmet Fide A frame whose sender asked for its TX status waits in the TX report queue for the report of the firmware. When no report comes, the purge timer frees the frames with skb_queue_purge(), and rtw_core_deinit() does the same. mac80211 is not told: the sender gets no status, and the copy mac80211 keeps for the status of a frame from user space stays in its list until ieee80211_free_hw() warns about it. On an RTL8822CE with hostapd, after a firmware crash and an unbind of the driver: rtw88_8822ce 0000:01:00.0: failed to get tx report from firmware [...] Have pending ack frames! WARNING: net/mac80211/main.c:1761 at ieee80211_free_ack_frame+0x4c/0x70 [mac80211], CPU#1: sh/24725 Call trace: ieee80211_free_ack_frame+0x4c/0x70 [mac80211] (P) idr_for_each+0x6c/0xf4 ieee80211_free_hw+0x30/0x8c [mac80211] rtw_pci_remove+0xd8/0xf0 [rtw88_pci] pci_device_remove+0x44/0xd4 Take the frames off the queue under its lock and hand them to ieee80211_purge_tx_queue(), which reports each one as not sent. Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver") Signed-off-by: Mehmet Fide Reviewed-by: Luka Gejak --- Notes: v3: no change v2: Reviewed-by Luka Gejak, no change drivers/net/wireless/realtek/rtw88/main.c | 5 +---- drivers/net/wireless/realtek/rtw88/tx.c | 20 ++++++++++++++++---- drivers/net/wireless/realtek/rtw88/tx.h | 1 + 3 files changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c index adc54b063382..ce65a1a80840 100644 --- a/drivers/net/wireless/realtek/rtw88/main.c +++ b/drivers/net/wireless/realtek/rtw88/main.c @@ -2225,7 +2225,6 @@ void rtw_core_deinit(struct rtw_dev *rtwdev) struct rtw_fw_state *fw = &rtwdev->fw; struct rtw_fw_state *wow_fw = &rtwdev->wow_fw; struct rtw_rsvd_page *rsvd_pkt, *tmp; - unsigned long flags; rtw_wait_firmware_completion(rtwdev); @@ -2237,9 +2236,7 @@ void rtw_core_deinit(struct rtw_dev *rtwdev) destroy_workqueue(rtwdev->tx_wq); timer_delete_sync(&rtwdev->tx_report.purge_timer); - spin_lock_irqsave(&rtwdev->tx_report.q_lock, flags); - skb_queue_purge(&rtwdev->tx_report.queue); - spin_unlock_irqrestore(&rtwdev->tx_report.q_lock, flags); + rtw_tx_report_purge(rtwdev); skb_queue_purge(&rtwdev->coex.queue); skb_queue_purge(&rtwdev->c2h_queue); diff --git a/drivers/net/wireless/realtek/rtw88/tx.c b/drivers/net/wireless/realtek/rtw88/tx.c index 701ed7c4f3f7..87d993282b1c 100644 --- a/drivers/net/wireless/realtek/rtw88/tx.c +++ b/drivers/net/wireless/realtek/rtw88/tx.c @@ -176,21 +176,33 @@ static void rtw_tx_report_enable(struct rtw_dev *rtwdev, pkt_info->report = true; } +void rtw_tx_report_purge(struct rtw_dev *rtwdev) +{ + struct rtw_tx_report *tx_report = &rtwdev->tx_report; + struct sk_buff_head purge; + unsigned long flags; + + __skb_queue_head_init(&purge); + + spin_lock_irqsave(&tx_report->q_lock, flags); + skb_queue_splice_init(&tx_report->queue, &purge); + spin_unlock_irqrestore(&tx_report->q_lock, flags); + + ieee80211_purge_tx_queue(rtwdev->hw, &purge); +} + void rtw_tx_report_purge_timer(struct timer_list *t) { struct rtw_dev *rtwdev = timer_container_of(rtwdev, t, tx_report.purge_timer); struct rtw_tx_report *tx_report = &rtwdev->tx_report; - unsigned long flags; if (skb_queue_len(&tx_report->queue) == 0) return; rtw_warn(rtwdev, "failed to get tx report from firmware\n"); - spin_lock_irqsave(&tx_report->q_lock, flags); - skb_queue_purge(&tx_report->queue); - spin_unlock_irqrestore(&tx_report->q_lock, flags); + rtw_tx_report_purge(rtwdev); } void rtw_tx_report_enqueue(struct rtw_dev *rtwdev, struct sk_buff *skb, u8 sn) diff --git a/drivers/net/wireless/realtek/rtw88/tx.h b/drivers/net/wireless/realtek/rtw88/tx.h index 168f48e87853..363f63525965 100644 --- a/drivers/net/wireless/realtek/rtw88/tx.h +++ b/drivers/net/wireless/realtek/rtw88/tx.h @@ -98,6 +98,7 @@ void rtw_tx_pkt_info_update(struct rtw_dev *rtwdev, struct sk_buff *skb); void rtw_tx_fill_tx_desc(struct rtw_dev *rtwdev, struct rtw_tx_pkt_info *pkt_info, struct sk_buff *skb); +void rtw_tx_report_purge(struct rtw_dev *rtwdev); void rtw_tx_report_enqueue(struct rtw_dev *rtwdev, struct sk_buff *skb, u8 sn); void rtw_tx_report_handle(struct rtw_dev *rtwdev, struct sk_buff *skb, int src); void rtw_tx_rsvd_page_pkt_info_update(struct rtw_dev *rtwdev, -- 2.56.0