From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.218.44 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794936954; b=pVZhWztw8qU0+WDJR4ZpO3a5jHs5fGY1TnOP5+xjNaRNWpH2Q8qLC1hg1SRITpzBhiky mIO1AS8MfQCg9RJP+hnq9gJIU57dx/t9VwKy8QOlTgwT547SQi9r+mHsIL0Eu8aunBTV0 ZX2sTyQk8BSLPPAClNihVyNgDwS8TdNSJL4uEdSyDUvCvTDW6X8djxE2nQdE3/swggewR inRYWAGY6PuSZoW5bKw8gh9XV7xyTGDj3qHPR8E1dV4HBjYViqXGUa2N3OMnw4y6C8dEK T+rWH3fI8lv1ZhOVHP3qRogb940PaDoqNqHn1Ieyrf2/evo1469OhmkZ12354BuI0xQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794936954; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=ehDPQMS1CgUNGIZmcAtlpOqErWJKhsWUSWC8X9QQDz4=; b=0Y3Xae+eqc1Dh0I09i0DbtzRCATM0iuWq1iylg94twUa9PhvwmELBtS8N57wZnrbjgu3 PH7jGMQwB++MDFuW7RCi2BKtpshokJVbRVpgETpZWhj8Lndyc7d/+gXwgDvirzkW62+CO E52vVVqz9PAQYFN2e7jwZ827Fv7cSHuurVX9BYUSdhNje6plopkSsWpqptGkHegwA8zfH vgZICyZdHhCM+HED2uYRdWW+Has2zpyYdbN3qxNAzUv2x+o+rYjqbA+fr7g+9vE9/JHAK YxMpVPWL+8cLBtsMzyn1H6uxY1flmb6VFvUr9+jv2C/sKyODVRQQUdeI3QIrm5YwLnw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=gpwZ0hRI; arc=none smtp.remote-ip=209.85.218.44 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB439606A32F for ; Tue, 17 Nov 2026 17:35:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BB439606A32F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=gpwZ0hRI Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c4d581da0aaso607928166b.2 for ; Tue, 17 Nov 2026 09:35:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794936952; x=1795541752; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ehDPQMS1CgUNGIZmcAtlpOqErWJKhsWUSWC8X9QQDz4=; b=gpwZ0hRIJ0pid42fGOtKDjmjtS+n1dGRHvIVeP0VJdOUEpwL+S3/+EMKHqIKY+8nVJ ZCwrjZnS3Do5vVK5klQrHrzBTZzCOAJZrqi04dVLBtdAjtfXksm2Icwsax73K9CaaP+D hgcdQwC/a37TF3bjUlYprcF1uLFRETn66xIXLjy+KiloUcJ0oFKBJudbT3nZjWkAL/CP nCt5p97NnObGwHllTgYBPz6W5H9AdOLDcAclWmvZ1VvyGJ2oz+wai3iKln/NO0QBZ7Zq EnT/k+XLPnRZkmlRRqU412/gDWlOzI31rmuU9H19XRhPH9aSIKh1xuKZalopbRABi7dN jnag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794936952; x=1795541752; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ehDPQMS1CgUNGIZmcAtlpOqErWJKhsWUSWC8X9QQDz4=; b=fEoN7LxzBQnYp9LRj3loIj6UkVW5dp/0yxTyTNe4WNsnEoaZS7R3oF1b8FgkpLT7ue dXARUudQIQK1By8+0d4912QYcusdzkywoJlw8BOO8YIaWDCCaRtFA/qsY3Yd9OqHQ6fI wmruGFSl3OoWlBTOxk8jBD2x9/RAL4Fz2uj2tZFU0p8dpT402HfPsv/JmexdQ4/KhQH5 X1Q0TyulCCHLMEfHKNsHrTEDKmwDTAbrliCc1amyP5rd6BfHJSuQqk91MnS2Q2zwcGj1 IXAjlpK7nn/xC7l0k54sDUYpw65YBpRihGJm+dvmvGM5Ro93g3eGxbChKIlRQtm+sCkb ye7Q== X-Forwarded-Encrypted: i=1; AL+hErFg67NFAUiaqGQlQn/z8BcOLvRuq7njonWKOoce/I5Nq2umxE4LSivWoRIQTEykGEV0nSUjagJy/5exmZ4=@vger.kernel.org X-Gm-Message-State: APuU4Z9M+GoFd2A+oCV9QJMdAAjGe720lWx048ShxBf01o/xXSJYMCk0 dq/4hrp0P7CNsIrtYJp2d2mUxLcZz/dgt9KT0QKd/eq3LF/BRVu1Fw8= X-Gm-Gg: AYBFou2gUU41LMYs5AukpTg5HpGOfnAVlABODtmqkFTpWEIB+b4WMdTUUV+HdLmtFsO 3t+6JocMCPbqycvxX8GXs8TCjTG6jBukhxJVy6kc1aLcY3AkiDlFv6UqcY9KQ+6dJkSg/V1lkas ylLlNBehe0BtyQsrSr5EEMPbtXd5pjwJJHphWXTUHkkQ2ec3Oq46QuRmbtSpZaKYKebb5aqddrd 5iUEiVFy75ktCzCCJGx0qXKHQ7jA7+fNMMjPdXYRPi/pR0H10RA1jVVWWCAq5yBpRapBUi3MLaV OdwJXZDGqZH1gZ89gUWq1AnpOYYevIo/rs21M1ZCsmRF472bckkOHphjTMr1EJ3IHvEy995eoE0 //rcqUZXbI3ScI4qTmJyTsh0vIGyWCVPsPgweu5hCkoHBX0zU8tcneYXy6j43CG/yWhgj8Ilm+W cjTSvH1kv1qWGYYWqPEFDUopO3QOvYr+VUptplvDrDRwgodmQI9qwH0OX2glvwpGfbn7b6VfjR4 u8sjHUX+iJacYr1twwOGgl63qr4MPBI/xl1dlYjhbGN8B7OCw/xLY9cQ3jx0U4QcaU5JecwHTZ0 4Amu7b278duR7LAgNo5iC4ybt5Wl2rqpUn4+RIZov35cTDt8gwRuYi6hxW3l3cAT93k4Vg87JqJ fwJv3PpX2oCOdQEpZ6n/n7rZtjA== X-Received: by 2002:a17:906:794c:b0:c41:7e99:c6c2 with SMTP id a640c23a62f3a-c5096409d32mr1211919466b.44.1794936951974; Tue, 17 Nov 2026 09:35:51 -0800 (PST) Received: from sohrab-omarchy.fritz.box (2a02-a44e-4ae7-1-c0e-6d5a-8ae2-915.fixed6.kpn.net. [2a02:a44e:4ae7:1:c0e:6d5a:8ae2:915]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c510ca049c7sm6863166b.20.2026.11.17.09.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 09:35:51 -0800 (PST) From: Majid Hajiheidari To: barnabas.czeman@mainlining.org Cc: andersson@kernel.org, konradybcio@kernel.org, rafael@kernel.org, viresh.kumar@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, abelvesa@kernel.org, mani@kernel.org, admin@mswin.me, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm6125: Add cpufreq-hw node Date: Tue, 17 Nov 2026 18:35:44 +0100 Message-ID: <20261117173547.1656090-1-majidhhdri@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Barnabás, thanks for the review, and for your answer on the cover letter. Both mails reached me but neither shows up on lore, so I am answering both here and quoting the relevant parts. On 2026-11-16 14:41, Barnabás Czémán wrote: >> + reg = <0x0 0x0f521000 0x0 0x1000>, >> + <0x0 0x0f523000 0x0 0x1000>; > If you check the available sources SM6125 is different from SM6115 the > size is 0x1400 instead of 0x1000. You are right. The downstream trinket device tree has 0x1400 for both regions; I took 0x1000 over from sm6115.dtsi. I will fix that in v2. >> + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, <&gcc GPLL0_OUT_EARLY>; > There is no proof GPLL0_OUT_EARLY is related to cpufreq, the driver > using the clocks for getting the initial rate from them, it is working > because this clock have similar rate but i am not sure it is logically > correct to bind a clock without proof it is related. That is why i > have made changes in the driver to make the clocks optional. Agreed that downstream does not tell us where the 300 MHz row comes from; it has OSM_INIT_RATE and XO_RATE as constants. But that is the same file and the same constants for every SoC it serves, and the mainline binding still requires both clocks ("XO Clock", "GPLL0 Clock") for all of them, SM6115 included. I followed that: - SM6115 uses <&gcc GPLL0>, which in gcc-sm6115 is the alpha PLL itself. gcc-sm6125 has no index with that name; the PLL is GPLL0_OUT_EARLY, with OUT_MAIN and OUT_AUX2 as its /2 outputs. On my phone it runs at 600 MHz, so the driver's /2 gives the 300 MHz row. - The mainline driver uses "xo" for every PLL row (xo_rate * lval), not only for the initial rate, so I think at least that one should stay a real clock rather than a constant in the driver. So with the binding as it is today the DT in this series is what the schema asks for, and a node without clocks would need a binding change first. Whether the clocks should become optional for these SoCs is something I would leave to Viresh, Konrad and Krzysztof. >From your mail on the cover letter (2026-11-15): > Also i have added a new SoC data because SM6125 and SM6115 have less > LUT entries (12) [2] and there are no throttling IRQs there. That part I agree with, the trinket fixup in downstream is clear. On laurel the generic data happens to stop at the repeated row before it gets that far, but nothing guarantees that. Would you send your soc data with lut_max_entries = 12 as a driver patch? It does not depend on the clock question. Your branch as a whole already ran fine on laurel (see my mail of 15 November), and once the patch is on the list I will boot it on top of this series and reply with a Tested-by. If the maintainers prefer that to go in first, or prefer your DT, I am fine with either and will rebase or drop my cpufreq patch accordingly. Thanks, Majid