From: Hungyu Lin <dennylin0707@gmail.com>
To: jaegeuk@kernel.org, chao@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, dennylin0707@gmail.com
Subject: [PATCH] f2fs: reject immutable and append-only files in move range
Date: Tue, 17 Nov 2026 17:37:57 +0000 [thread overview]
Message-ID: <20261117173757.15066-1-dennylin0707@gmail.com> (raw)
F2FS_IOC_MOVE_RANGE only checks that both files are open for writing. It
does not look at the inode flags, so it replaces blocks of the
destination file and punches blocks out of the source file even if the
file is append-only or immutable.
An append-only file can be opened for writing with O_APPEND, so a user
with write permission on such a file can overwrite or remove the data
that is already there, which ftruncate() and fallocate() do not allow.
For an immutable file the same works through a file descriptor that was
opened for writing before the flag was set, although f2fs_write_checks()
refuses writes through it.
Return -EPERM if either file is immutable or append-only.
Fixes: 4dd6f977fc77 ("f2fs: support an ioctl to move a range of data blocks")
Cc: stable@kernel.org
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
fs/f2fs/file.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index e2c0f5083313..9cf733954522 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3265,6 +3265,12 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
goto out;
}
+ if (IS_IMMUTABLE(src) || IS_APPEND(src) ||
+ IS_IMMUTABLE(dst) || IS_APPEND(dst)) {
+ ret = -EPERM;
+ goto out_unlock;
+ }
+
if (f2fs_compressed_file(src) || f2fs_compressed_file(dst) ||
f2fs_is_pinned_file(src) || f2fs_is_pinned_file(dst)) {
ret = -EOPNOTSUPP;
--
2.43.0
reply other threads:[~2026-11-17 17:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117173757.15066-1-dennylin0707@gmail.com \
--to=dennylin0707@gmail.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®