From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: seanjc@google.com, jmattson@google.com
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, zhao1.liu@intel.com,
chang.seok.bae@intel.com
Subject: [PATCH v9 00/20] KVM: x86: Enable APX for guest
Date: Tue, 17 Nov 2026 18:02:50 +0000 [thread overview]
Message-ID: <20261117180310.921701-1-chang.seok.bae@intel.com> (raw)
Hi all,
This revision incorporates feedback from Jim Mattson. Thanks for the
review! While he provided review tags for some patches, he also caught
something. Here's a summary of changes in each part:
Part1: Establish EGPR state management
Since EGPR storage resides outside the guest fpstate, there were two
gotchas to address:
* VCPU reset (patch3) and
* The XSTATE_BV[APX]=0 behavior in the KVM API (patch4), with a
corresponding test added in patch19. This also influenced [4].
Part2: Update VMX handlers for EGPR indices
While rebasing onto recent VMX changes, the VMX instruction
information extension needs to be hidden when using eVMCS (patch 9
and 17/18), rather than leaving it untouched.
Part3: Support emulator for REX2
There were a few smaller corrections, but one outstanding was masking
higher register bits before accessing {X,Y}MM registers (patch 12).
Another point was whether to report #UD or an emulation failure. I
took that distinguishing the two is reasonable in the front end,
although an emulation failure eventually be #UD injection in the back
end.
Part4: Expose APX features and test
The rationale for CPUID filtering to ensure forward compatibility was
bought. Then consolidated feature exposure into patch 18. There were
also a few minor test-code updates, along with a new test for
clearing APX state based on the feedback from Part1.
With these changes, I think the series in much better shape, hopefully
leaving fewer issues for Sashiko to catch. Let me check if there is
anything else.
Thanks,
Chang
References:
[1] Repository: git://github.com/intel/apx.git apx-kvm_v9 (based on github.com/kvm-x86 next)
[2] KVM unit test: https://lore.kernel.org/20260420212355.507827-1-chang.seok.bae@intel.com
[3] Previous posting, V8: https://lore.kernel.org/20260930210750.1487547-1-chang.seok.bae@intel.com
[4] x86 xstate ptrace test: https://lore.kernel.org/20261110031603.698635-1-chang.seok.bae@intel.com
Chang S. Bae (19):
KVM: x86: Extend VCPU registers for EGPRs
KVM: VMX: Save guest EGPRs in VCPU cache
KVM: x86: Support EGPRs on VCPU RESET/INIT events
KVM: x86: Support APX state for XSAVE ABI
KVM: VMX: Refactor VMX instruction information access
KVM: VMX: Refactor instruction information decoding
KVM: VMX: Remove unused control-register access defines
KVM: VMX: Refactor register index retrieval from exit qualification
KVM: VMX: Support instruction information extension
KVM: nVMX: Propagate extended instruction information
KVM: x86: Support EGPR accessing and tracking for emulator
KVM: x86: Handle EGPR index and REX2-incompatible opcodes
KVM: x86: Support REX2-prefixed opcode decode
KVM: x86: Document EVEX-prefix not implemented
KVM: x86: Guard valid XCR0.APX settings
KVM: x86: Add APX to supported XCR0
KVM: x86: Expose APX feature to userspace
KVM: selftests: Add APX state and ABI test
KVM: selftests: Add APX state handling and XCR0 sanity checks
Sean Christopherson (1):
KVM: x86: Move KVM_SUPPORTED_{XCR0,XSS} into kvm_x86_vendor_init()
arch/x86/Kconfig.assembler | 5 +
arch/x86/include/asm/cpuid/api.h | 1 +
arch/x86/include/asm/kvm_host.h | 19 ++
arch/x86/include/asm/kvm_vcpu_regs.h | 50 +++++
arch/x86/include/asm/vmx.h | 22 +-
arch/x86/kvm/Kconfig | 4 +
arch/x86/kvm/cpuid.c | 33 ++-
arch/x86/kvm/cpuid.h | 2 +
arch/x86/kvm/emulate.c | 132 ++++++++---
arch/x86/kvm/kvm_emulate.h | 21 +-
arch/x86/kvm/reverse_cpuid.h | 6 +
arch/x86/kvm/svm/svm.c | 8 +-
arch/x86/kvm/vmenter.h | 1 +
arch/x86/kvm/vmx/common.h | 5 +
arch/x86/kvm/vmx/nested.c | 72 +++---
arch/x86/kvm/vmx/nested.h | 2 +-
arch/x86/kvm/vmx/vmcs12.c | 4 +
arch/x86/kvm/vmx/vmcs12.h | 3 +-
arch/x86/kvm/vmx/vmenter.S | 31 ++-
arch/x86/kvm/vmx/vmx.c | 36 ++-
arch/x86/kvm/vmx/vmx.h | 63 +++++-
arch/x86/kvm/vmx/vmx_ops.h | 9 +
arch/x86/kvm/x86.c | 144 +++++++++---
tools/testing/selftests/kvm/Makefile.kvm | 1 +
.../selftests/kvm/include/x86/processor.h | 120 ++++++++++
tools/testing/selftests/kvm/x86/apx_test.c | 209 ++++++++++++++++++
tools/testing/selftests/kvm/x86/state_test.c | 3 +
.../selftests/kvm/x86/xcr0_cpuid_test.c | 19 ++
28 files changed, 877 insertions(+), 148 deletions(-)
create mode 100644 tools/testing/selftests/kvm/x86/apx_test.c
base-commit: cbe54fc3462b3949ab27b9ae81fb9ddb509040c7
--
2.53.0
next reply other threads:[~2026-11-17 18:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 18:02 Chang S. Bae [this message]
2026-11-17 18:02 ` [PATCH v9 01/20] KVM: x86: Extend VCPU registers for EGPRs Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 02/20] KVM: VMX: Save guest EGPRs in VCPU cache Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 03/20] KVM: x86: Support EGPRs on VCPU RESET/INIT events Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 04/20] KVM: x86: Support APX state for XSAVE ABI Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 05/20] KVM: VMX: Refactor VMX instruction information access Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 06/20] KVM: VMX: Refactor instruction information decoding Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 07/20] KVM: VMX: Remove unused control-register access defines Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 08/20] KVM: VMX: Refactor register index retrieval from exit qualification Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 09/20] KVM: VMX: Support instruction information extension Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 10/20] KVM: nVMX: Propagate extended instruction information Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 11/20] KVM: x86: Support EGPR accessing and tracking for emulator Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 12/20] KVM: x86: Handle EGPR index and REX2-incompatible opcodes Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 13/20] KVM: x86: Support REX2-prefixed opcode decode Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 14/20] KVM: x86: Document EVEX-prefix not implemented Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 15/20] KVM: x86: Move KVM_SUPPORTED_{XCR0,XSS} into kvm_x86_vendor_init() Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 16/20] KVM: x86: Guard valid XCR0.APX settings Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 17/20] KVM: x86: Add APX to supported XCR0 Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 18/20] KVM: x86: Expose APX feature to userspace Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 19/20] KVM: selftests: Add APX state and ABI test Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks Chang S. Bae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117180310.921701-1-chang.seok.bae@intel.com \
--to=chang.seok.bae@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=x86@kernel.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®