mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Linkui Xiao <xiaolinkui@126.com>
Cc: maxime.chevallier@bootlin.com, andrew@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, pabeni@redhat.com,
	horms@kernel.org, devnexen@gmail.com, sdf@fomichev.me,
	2022090917019@std.uestc.edu.cn, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Linkui Xiao <xiaolinkui@kylinos.cn>
Subject: Re: [PATCH net v2] net: ethtool: phy: warn about a phydev with no link topology
Date: Tue, 17 Nov 2026 18:49:04 -0800	[thread overview]
Message-ID: <20261117184904.27187edc@kernel.org> (raw)
In-Reply-To: <20261112075517.3904496-1-xiaolinkui@126.com>

On Thu, 12 Nov 2026 15:55:17 +0800 Linkui Xiao wrote:
> phy_prepare_data() reads reply_data->dev->link_topo and dereferences it
> without checking it:

defensive check based on a hallucination, let's not
-- 
pv-bot: slop

      parent reply	other threads:[~2026-11-18  2:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  7:55 Linkui Xiao
2026-11-12  8:02 ` netdev-bot+sinfo
2026-11-12  8:09   ` Linkui Xiao
2026-11-18  2:49 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117184904.27187edc@kernel.org \
    --to=kuba@kernel.org \
    --cc=2022090917019@std.uestc.edu.cn \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devnexen@gmail.com \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=xiaolinkui@126.com \
    --cc=xiaolinkui@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®