From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794944367; b=WfO2XUac1TJ1Qa7ZIp5jCKcvgnG6rMJs2DwnBV69WIPo1E39PhO2q+ODsE9oQdYxhkeY FrirCRnZe6BlvW3zqqTRGtfBA/i3j/SeY26LV4maIuJiDnYu1JkrUcFrI0LvlwSSgaDsQ xj/WvmAJvxBY4MxDARR9Qq2yLbyrMf95UMwgo8C6aXZETdb6SOXjJkqGgBs00sCP7jRL0 XqVdiY5VmHPR+UW7WlKERidNBPlGlINlHCGvVNkeIVcwi6wDJ5OH5pQh4JeX5EPe83Efm yNjFy3dye621rrUguSpgFrD06bQUSfmSj7KOVNfUPkXH0o18K6nvWpMfJqzVVdlkDhw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794944367; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=X24LLs2RrK+lA3rnWmeXdxswGXkvA2QXv3w3PC5997A=; b=sDPofTp1sM9xfXdW68FZ8LA1pSKuB2Idgbk4b/JbOeqfKsph5pjMUnIAfh+X7bVgRlKI 2g1oGiWJMIc4oE91LicKXXhXF6kt47o28S42mVtC8XPdxjoXGQ7shcRluk6qYBGq6afvb DsG3wBHIjFHB2SkvAvD+iCvDTHyt+1IHs3dOn9WHSPggQXF6bOVIyAhTlm89pxz9Bz3We /b4M+PqZ2GH3Yt1OwNRsBJQC6OPhaf33v7I3JDLFgNHKeTyUOWaFylTqFfLVeIzUxc0vS vNpLizVkM+Zfi/sQ1TWIR1GqXCPHRkmnFZQMgLFEeIWd415xGd+T1W2SmwyVk0sDB0w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b="buqZ4+/B"; arc=none smtp.remote-ip=209.85.221.49 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48205606A339 for ; Tue, 17 Nov 2026 19:39:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 48205606A339 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=buqZ4+/B Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-49412eb1474so72434f8f.3 for ; Tue, 17 Nov 2026 11:39:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794944365; x=1795549165; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=X24LLs2RrK+lA3rnWmeXdxswGXkvA2QXv3w3PC5997A=; b=buqZ4+/Bo9e+N24UUPYC17NFKAdU3HfgJsD6u3noM8uJiz3iiLUQLrQBL+vSAdZ/Ra WfwGpt1XKwdl5lYtJsKqbbK5BmFxy75q3DltcusAgIVFGfLOkyDgk8d74cha8JP30ISD BMGD7+qjDyXsPM1hS6JILeVssoE1Ff5GR46SCwdyMIPpXR1uES33HO64Dm4vnBC2ECVp up4jkuUIywG2HoR3dVY+Gmq2TINJ7632YJ7jQ2EijqYnIQihOG9GQhXHiIjk6wcwnuIF ny691NFOEJ0w072ZWJjLPFA176HpyPJp0C9HxKvn0htH4bFJ/G9P/PXHNYb621/z98dj f7Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794944365; x=1795549165; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=X24LLs2RrK+lA3rnWmeXdxswGXkvA2QXv3w3PC5997A=; b=yNg5HX3TlY9kGVuBckJBACxKj6b9FER2AZhgetqjQGOjU0oWHkkb55TRxXOwqSPOsK tjGqg3Ejr0ND4eRQO31O36nfpMcIdcLXz2zR6rq0NG2suRs8dLY7tRsbWGB0Cd6/Z1c8 w5JPTyJuZWHtZA1DQxQNqxV1hJDpkdROWBydkzssS86zseqHOByRAv+OAEN7VlaQcOZ+ cnowis8AZ8Ln3bAFFI9GHefRf3izqhejSiGxwmIa1ai0ahzYdYriubT8neNxkFNCcuSf aCtQbT8WANoDpmztOMctuTzz/cv7un1Y/aQ2I42Nj7RCAZL4n2ULY1lefjd609vvacqN Blxw== X-Forwarded-Encrypted: i=1; AL+hErHZepV4wkDXy+T7QV3nKs6c3+kDcF/hD8gM9Een1/FdS/ZwBE/TYRspXOTL9EPsCVhKkc2OWi6C/33317k=@vger.kernel.org X-Gm-Message-State: APuU4Z/8hxej34UyYDJ4RbK72MrzPf/CrxY5ZgkpZYBbJx4A6aaayN6O j1tUfOeiIJtX8rX/Zk7dVnQgfLBKSOLeuhhNR4CKXfIXncmVnzyjvcrNB0c82zjS X-Gm-Gg: AZFdTZcKWu2t635967vG6KdOrvKFQRDll0R28mr+4hPY6PS4KAM6UvVdKmOh0u0ZCwX FTZFbnrtEEgx0/vUiQijxXOh4cIlyOQkx3q6pYutDCtxDrF2En77YVMgDl8ikUAAzZ2OUp3yzzY s37qcwkM3xz3is4OiBEA4pmNqH21f9lbGf0SLo0vOhhBLNwiFAdSSbsWH9fnhxO8tHFwpY3kkzT hJ6xtY1iSTn6y58yB5f/HKmUDptzK22gfKae1FTB+7MgncRhRdukQzyyxIr0zcyinmh+0YNOWeg jiixwCDq02UW+KnpoFs51f9TpfBtsULQ0Y7e4jCETfNSwDxzi8MO9S9Fl9qoGrMHqf2qVtsMv+n jMdTerMQgJprPSq7I8iTf3jTFJBZ/lTkKZ02aU9VrrQakBpk7tlyboE5cTqRA91TmpMleUO/YIy v5Pkwwjfus3ksYKcBHD/KsxEEbWuHrDwg81zY58+IUrUjQIibas/I4uVqAY6y6b3ink3G9PZQS7 mmiKObfhmj95q8x9bqdpkrA+FuVOolADIF5Ioxqnr5PJ4E2nJBYJqvHfFdF839yDgClYt5rvJTo W9zKhrGYI2OnNREIu622jj+vd6ASCba6yYCgtJNpq3GkY9bZ2DlInRcNVVVV/xm2GQ== X-Received: by 2002:a05:6000:200c:b0:48e:bf0:352 with SMTP id ffacd0b85a97d-4a6346da7e2mr1023911f8f.5.1794944365440; Tue, 17 Nov 2026 11:39:25 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a656c1145esm424374f8f.52.2026.11.17.11.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 11:39:25 -0800 (PST) Date: Tue, 17 Nov 2026 19:39:23 +0000 From: David Laight To: Al Viro Cc: Theodore Tso , Gabriel Krisman Bertazi , Sarthak Kukreti , Jaegeuk Kim , Chao Yu , Christian Brauner , Gabriel Krisman Bertazi , Eric Biggers , Dmitry Torokhov , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] libfs: reject casefolded names that fold to ".", "..", or empty Message-ID: <20261117193923.795e6129@pumpkin> In-Reply-To: <20261117175917.GO989762@ZenIV> References: <20261113065332.929085-1-sarthakkukreti@google.com> <20261113065332.929085-2-sarthakkukreti@google.com> <878q2swoxp.fsf@cartola> <20261117084727.0cfa196a@pumpkin> <20261117175917.GO989762@ZenIV> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 17 Nov 2026 17:59:17 +0000 Al Viro wrote: > On Tue, Nov 17, 2026 at 09:54:32AM -0500, Theodore Tso wrote: > > On Tue, Nov 17, 2026 at 08:47:27AM -0500, David Laight wrote: > > > > Sigh... I really think these characters are *evil*. I wonder if we > > > > should simply drop those code points unconditionally when they are fed > > > > to the kernel --- not only folding to themselves, but *not* preserving > > > > them when a misguided application tries to create a file with one of > > > > these misbegotten Unicode charactesr. > > > > > > Doesn't that assume that filenames are UTF8 rather than just sequences > > > of bytes with everything except '\0' and '/' being valid. > > > Casefolding is itself so evil/impossible it shouldn't have been allowed. > > > > We would only do this if casefolding is enabled. > > Which is to say, on any distro kernel. Besides, it's not just a matter of > filtering that dreck out on getname() and friends (syscall boundary won't > do at all due to the things like binfmt_misc opening files, etc.) - you'd > need to scan what you get upon ->get_link() as well. I also hope it is a mount option? So you could cross mountpoints several times (in both directions) to and from fs with utf8 casefold un/supported while processing a single pathname. > > For better or for > > worse, it's better than what it replaced which was this terrible > > wrapfs hack that was a trivial to trigger deadlocks using fsstress --- > > which was even more evil. > > > > The other way we can deal with this is that if case folding is > > enabled, we change the VFS to call the case-folding for incoming > > filename *before* it does its special case checking for '.' and '..' > > if casefolding is enabled. > > That would penalize every pathname resolution, whether that misfeature is > stepped into or not; hash_name() is fairly hot. > > '.' and '..' should be recognized only as literal octet sequences 0x2e > and 0x2e 0x2e; if some misguided filesystem decides to treat something > else as equivalent to those, it bloody well ought to recognize and reject > that something else in its ->lookup() (or ->d_hash(), for that matter). I remember when "." and ".." weren't actually special. You could have great 'fun' using the 'link' system call to make them refer to unexpected places. David