From: kernel test robot <lkp@intel.com>
To: xu.xin@linux.dev, David Hildenbrand <david@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Donet Tom <donettom@linux.ibm.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org, Xu Xin <xu.xin@linux.dev>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/ksm: do not inherit ksm_zero_pages counter or PTE markers on fork
Date: Tue, 17 Nov 2026 20:27:32 +0800 [thread overview]
Message-ID: <202611172040.LO8S0kBo-lkp@intel.com> (raw)
In-Reply-To: <20261117081821.7211-1-xu.xin@linux.dev>
Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/xu-xin-linux-dev/mm-ksm-do-not-inherit-ksm_zero_pages-counter-or-PTE-markers-on-fork/20261117-161821
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20261117081821.7211-1-xu.xin%40linux.dev
patch subject: [PATCH] mm/ksm: do not inherit ksm_zero_pages counter or PTE markers on fork
config: hexagon-allnoconfig (https://download.01.org/0day-ci/archive/20261117/202611172040.LO8S0kBo-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project a69be15ed58ed48738a69ec4c7d0f3e8c7dbe4ce)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261117/202611172040.LO8S0kBo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611172040.LO8S0kBo-lkp@intel.com/
All errors (new ones prefixed by >>):
>> mm/memory.c:1168:6: error: call to undeclared function 'is_ksm_zero_pte'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1168 | if (is_ksm_zero_pte(pte))
| ^
1 error generated.
vim +/is_ksm_zero_pte +1168 mm/memory.c
1123
1124 static __always_inline void __copy_present_ptes(struct vm_area_struct *dst_vma,
1125 struct vm_area_struct *src_vma, pte_t *dst_pte, pte_t *src_pte,
1126 pte_t pte, unsigned long addr, int nr)
1127 {
1128 struct mm_struct *src_mm = src_vma->vm_mm;
1129 bool writable;
1130
1131 /*
1132 * Snapshot writability before the RWP-disarm rewrite below: when the
1133 * child is not RWP-armed, pte_modify(pte, dst_vma->vm_page_prot) can
1134 * silently drop _PAGE_RW from a resolved (no-marker) writable PTE,
1135 * so a later pte_write(pte) check would skip the COW wrprotect and
1136 * leave the parent writable over a folio shared with the child.
1137 */
1138 writable = pte_write(pte);
1139
1140 /*
1141 * Child is not RWP-armed: restore accessible protection so the
1142 * inherited PAGE_NONE does not cost a fault on first read. Gate on
1143 * pte_uffd(pte) so unrelated PAGE_NONE markers (e.g. NUMA balancing)
1144 * are not normalised away.
1145 */
1146 if (!userfaultfd_protected(dst_vma)) {
1147 if (userfaultfd_rwp(src_vma) && pte_uffd(pte))
1148 pte = pte_modify(pte, dst_vma->vm_page_prot);
1149 pte = pte_clear_uffd(pte);
1150 }
1151
1152 /* If it's a COW mapping, write protect it both processes. */
1153 if (vma_is_cow_mapping(src_vma) && writable) {
1154 wrprotect_ptes(src_mm, addr, src_pte, nr);
1155 pte = pte_wrprotect(pte);
1156 }
1157
1158 /* If it's a shared mapping, mark it clean in the child. */
1159 if (src_vma->vm_flags & VM_SHARED)
1160 pte = pte_mkclean(pte);
1161 pte = pte_mkold(pte);
1162
1163 /*
1164 * Clear the dirty-bit marker on KSM-placed zero-page PTEs in the
1165 * child so inherited mappings are not accounted against the child or
1166 * unshared by MADV_UNMERGEABLE. Special PTEs always have nr == 1.
1167 */
> 1168 if (is_ksm_zero_pte(pte))
1169 pte = pte_mkclean(pte);
1170
1171 set_ptes(dst_vma->vm_mm, addr, dst_pte, pte, nr);
1172 }
1173
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2026-11-17 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 8:18 xu.xin
2026-11-17 9:51 ` David Hildenbrand (Arm)
2026-11-17 12:27 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202611172040.LO8S0kBo-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=david@kernel.org \
--cc=donettom@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=xu.xin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®