From: Suyuan Wang via B4 Relay <devnull+shyckless.gmail.com@kernel.org>
To: ashish.kalra@amd.com, john.allen@amd.com, thomas.lendacky@amd.com
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: [PATCH] crypto: ccp: Require a writable file for SNP_COMMIT
Date: Wed, 18 Nov 2026 14:21:32 +0000 [thread overview]
Message-ID: <20261118-ccp-sev-v1-1-76894536031f@gmail.com> (raw)
From: Suyuan Wang <stevewong@hust.edu.cn>
sev_ioctl() works out whether the file was opened for writing and passes
that down to every command that changes platform state:
bool writable = file->f_mode & FMODE_WRITE;
...
case SNP_SET_CONFIG:
ret = sev_ioctl_do_snp_set_config(&input, writable);
SNP_COMMIT is the exception. sev_ioctl_do_snp_commit() takes no writable
argument and runs SEV_CMD_SNP_COMMIT unconditionally, so a process that
opened /dev/sev read-only can still commit the SNP firmware version.
Committing the current firmware updates the committed version and the
reported TCB, and prevents rolling back to a previously committed
firmware version -- the kind of state change the FMODE_WRITE check
exists to gate.
Pass writable to sev_ioctl_do_snp_commit() and reject the command with
-EPERM on a read-only file, like the other state-changing commands
(reset, PEK/PDH gen, PEK import, SNP_SET_CONFIG, VLEK_LOAD).
Found with a static analysis tool and checked by hand.
Fixes: fad133c79afa ("crypto: ccp: Add the SNP_COMMIT command")
Cc: stable@vger.kernel.org
Co-developed-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
Signed-off-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
Signed-off-by: Suyuan Wang <stevewong@hust.edu.cn>
---
Compile tested only (x86_64, W=1 and sparse show no new warnings). I
don't have an SEV-SNP platform.
---
drivers/crypto/ccp/sev-dev.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
index 52fb208b71ab..9d1c40a371e3 100644
--- a/drivers/crypto/ccp/sev-dev.c
+++ b/drivers/crypto/ccp/sev-dev.c
@@ -2666,11 +2666,14 @@ static int sev_ioctl_do_snp_platform_status(struct sev_issue_cmd *argp)
return ret;
}
-static int sev_ioctl_do_snp_commit(struct sev_issue_cmd *argp)
+static int sev_ioctl_do_snp_commit(struct sev_issue_cmd *argp, bool writable)
{
struct sev_data_snp_commit buf;
int ret;
+ if (!writable)
+ return -EPERM;
+
buf.len = sizeof(buf);
mutex_lock(&sev_cmd_mutex);
@@ -2796,7 +2799,7 @@ static long sev_ioctl(struct file *file, unsigned int ioctl, unsigned long arg)
ret = sev_ioctl_do_snp_platform_status(&input);
break;
case SNP_COMMIT:
- ret = sev_ioctl_do_snp_commit(&input);
+ ret = sev_ioctl_do_snp_commit(&input, writable);
break;
case SNP_SET_CONFIG:
ret = sev_ioctl_do_snp_set_config(&input, writable);
reply other threads:[~2026-11-18 14:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118-ccp-sev-v1-1-76894536031f@gmail.com \
--to=devnull+shyckless.gmail.com@kernel.org \
--cc=ashish.kalra@amd.com \
--cc=john.allen@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shyckless@gmail.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®