From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.171 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794981361; b=A/mTAbtpOL1m9VnnZkG7ZW7mzIa0Y9QSF7CaJccQDOfWJf1HKLiPhAV0eOqeaDyvVDXo ybB15Nf3nmcpmYicGJ03ghIhJxr3YkExWtIEf1Df5X5uxqf2yCDw0G/yFqjeVjA0hd+BB 6ek7jdWgWMl3Gv7V1K2uJABrQYOck+mo/GpHkoCOlxX5jYS8xILx7Kn5PE2Cxrd2oXEyK Jl6SlmW5bsTQp8JEjFshmYJQAdfQziGrQYTR6iExhJObZRVo5/peiGDSKvVxT2iQO17qT iSuk5mR932lkEj9Ts/eMl74kvIUQPpsHjgVdIZ+N7g102owSzKx/GtakPXahz6aDy1Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794981361; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key; bh=iHpEgxPbFinlelTShydiqMdXL6WmYaYuO85mjvtFPkY=; b=A3Jz6fP1TiRA/1KTR28VTVjW2Xc2rYi+BXXZAQml9q85n6+3Rz1eUQwlAH8TFBmRLmNW +53It1bUUwmPYD8kdMCA5EDCrDIs/vRDKszhSOWSW7cx0IiC7kkolqr01THfTIHbwwAFe m0u2zKaMrl+vOd0fgKgFYNQ2rMGXoNcFtD6gEbO1cF/66GptuTdzkCg9iO1Gc2l1mU+Gp RTwspLr7ugfOWdB0pJCjIPkZcozpNf65U41FZU244hHIWOv3S0+X4LD1MomjSH39qPAiP 5wW19XuXMVodsYtkVQwv3yJNDsaDZo/D+Mv3OgFMfp+jOUjEYofS2+ADc/ld2BxE5+w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=lkChkZT1; arc=none smtp.remote-ip=209.85.215.171 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2240606A32A for ; Wed, 18 Nov 2026 05:56:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B2240606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=lkChkZT1 Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-cdd8c20bccaso24391a12.3 for ; Tue, 17 Nov 2026 21:56:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794981360; x=1795586160; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iHpEgxPbFinlelTShydiqMdXL6WmYaYuO85mjvtFPkY=; b=lkChkZT1D7xLfbiqYrsn3OXmIzGQlqPz2ENGy23WFQZ3VyxduHQekV/Y0EOnot704X LqKHvhuj7zwWUrHOk5Zx5sOAemwhK8QESHP659RJbDByr0R/EV11/AXZh8JGWmtFN1v3 S5MOQWzC9gBzwpUOGBHd60GUuxg1dg8mz0gdSOPmrcQM88vPQpixLyrt/o2A2q2wBV6T 6hBiW/0TGjsmnWWgGxZteLeP6wW6HYisgSsyZGEqoHqXuWZ6fkk2Dy2rNwrBOESP4YiX l7qmsOxi4mNEwv7KRhXriV0oZWbvIJWj9Co5KrNFBhQemciie7vxdbRuy9hABJAYfn5y gWOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794981360; x=1795586160; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iHpEgxPbFinlelTShydiqMdXL6WmYaYuO85mjvtFPkY=; b=ijoylWGI8dUe3PGY+443Qq4s0zy5ZJj974D4te20IfDImq1FSUSoOCWB76myL3R3Eg I+UBDQFg5EvtM3YhVvyqmTK8sugaGGKdWJU3VYXCjjQ8cmCVHt+YxSiV5C1uWiHw4CEt sTBo9ilfe0Qn1qqhHPsXZgxocOttC/GOn1VYuNQVXPblb24jdiLRXTm05wqdbKgcpQFH WAxmtx6Doc7FAzmrZQDndCQP3EqsCg1KKYgqFq0qo/+GocdjeuGdVZFPlsd4NrtwMuGW 1acBvhQzaCrP0ldbDI/DVYgPJeiGT/iGzFoiQJO/3pAaN47x2KjK+eR89FWDQqpX7tmT ffCA== X-Forwarded-Encrypted: i=1; AL+hErE3TKBeyt+FnNgBBKnuqPAXMVND8Hh1kWzJiQHVfoQJJ1Y0RiIUWFtq9EfAPYbWQvyW4uk4W6aVfVMV2UI=@vger.kernel.org X-Gm-Message-State: APuU4Z+ldsIL0+LBywLpZPcbd8kCN/mN5N9C45UeYth7KzfoRaaUIoby TVxX6drRymKZ2iPbO6GURK+GFpfBv23YkmPgC4icuZnh4Z1M1L8Hf1Qc X-Gm-Gg: AYBFou2I4r/GqYdxIPPoyxV+o2RIoo04O3FE4EPhkYXeHwU9+JmCjOhDS0x1UTWQkXo X+7k3s07pKo8sX2fL1IHjQ2xktlJX0DCGbPDPn2LeCYswUCOw+lcSSdF6fViVZHGom3lIDAJdy4 t+5OBLYn2TvQf2sXvO2FU19fxCj6tiNuUMTGihwDBHh/qFl+8V+lCc9Lfl6wv26ePFUH+9nXqAw GlZI/HRPZ0Kq8MHwH+BY1K4Cf7W4DjELn++cIiVx93hDiuw4S4vN0QPynZD/fryaOs564P9JuFr qVgR9cN3hyLOVY0/HDqlY04e6hbF2fSPoOj4hU9JVotmp9WAR3Xm5WDkifPZhoe4Xc9TvOtD0ug MVOqe4DXP4EvTQIUQNRxMOuVzzktKUbv75x1wKL9rwQjZCjWuWQNgCfvWVHiw5Ay2UI4RnBJ1Me 31Gm2+S5wqRxLlTxxVuKFg/ldnKzFB5imma5EGzxibsCan4qe28u34meYtesMKrPa2YDf4zJOgy cSl6fLZhqMJXaVQhVi9A0KVuxucBvE/sQmPI2PpQFN4Ooz5gPRY5PeswGb2vUPp+ZU6PVgfixju uTu/sZtb+//nSMZ4o3UjcKvmXi6V9YuNAPV3JGJPcimBoBf5YVKoXus7S2UzzJ6iZDGRiFGNugW 0PF2jGrpsteoduCE5x3Kn X-Received: by 2002:a05:6300:6bc1:20b0:3ef:2f72:c7e5 with SMTP id adf61e73a8af0-3fe89100d9fmr1650543637.2.1794981359689; Tue, 17 Nov 2026 21:55:59 -0800 (PST) Received: from [127.0.1.1] (211-23-39-77.hinet-ip.hinet.net. [211.23.39.77]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8c5ca5bf959sm569563b3a.20.2026.11.17.21.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 21:55:59 -0800 (PST) From: Jason Yang Date: Wed, 18 Nov 2026 13:55:17 +0800 Subject: [PATCH v7 4/9] phy: rockchip-samsung-dcphy: Always write the rate-dependent registers X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261118-dcphy-rx-v1-v7-4-8de1adac3a74@gmail.com> References: <20261118-dcphy-rx-v1-v7-0-8de1adac3a74@gmail.com> In-Reply-To: <20261118-dcphy-rx-v1-v7-0-8de1adac3a74@gmail.com> To: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Guochun Huang , Philipp Zabel Cc: Michael Riesch , Sebastian Reichel , Bryan O'Donoghue , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jason Yang , Quentin Schulz X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1794981338; l=2791; i=jason98166@gmail.com; s=20260721; h=from:subject:message-id; bh=jOoW884/QWxzl0iQgg361AUaX2tfS/RGrsDEUvgeOSs=; b=VkOIadDSCSCWfnuqRaor/8P7xZ2XT4u0wDDTi479M168RRkokCGNAss3oSGd4blzKFbElD6Bu whowWKt+GmhDXy0qQNwzix6IZpQLJ7M65vCrX2H2rmVHBAv8R8sC34y X-Developer-Key: i=jason98166@gmail.com; a=ed25519; pk=xQmD001Q/ooHl39PxyQtusbUQmgbOsSfpFryRVWZ/k4= The lane timing init functions write DPHY_MC_ANA_CON1, the four data lane ANA_CON1 registers and DPHY_MC_DESKEW_CON0 only above a data rate threshold, and the registers have to be zero below it [1]. Today the APB reset at the start of every power_on provides the zero. A later change moves that reset to runtime resume, so a power_on at a lower rate after a higher one would keep the old values. Write the registers on every power_on, with zero below the threshold. [1] RK3588 TRM: sections 22.4.2 (reset values) and 22.4.3 (DPHY_MC_ANA_CON1, DPHY_MC_DESKEW_CON0) Signed-off-by: Jason Yang Reviewed-by: Michael Riesch Tested-by: Quentin Schulz # RK3588 Tiger CSI1 2-lane IMX219, CSI0 2-lane OV5675+DSI --- drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c | 24 +++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c index ce1bc62497c5..7a009d87a665 100644 --- a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c +++ b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c @@ -1228,7 +1228,10 @@ samsung_mipi_dphy_clk_lane_timing_init(struct samsung_mipi_dcphy *samsung) regmap_write(samsung->regmap, DPHY_MC_ANA_CON0, val); if (lane_hs_rate >= 4500) - regmap_write(samsung->regmap, DPHY_MC_ANA_CON1, 0x0001); + val = 0x0001; + else + val = 0; + regmap_write(samsung->regmap, DPHY_MC_ANA_CON1, val); val = 0; /* @@ -1259,7 +1262,10 @@ samsung_mipi_dphy_clk_lane_timing_init(struct samsung_mipi_dcphy *samsung) * under 1.5Gbps or equal to 1.5Gbps. */ if (lane_hs_rate > 1500) - regmap_write(samsung->regmap, DPHY_MC_DESKEW_CON0, 0x9cb1); + val = 0x9cb1; + else + val = 0; + regmap_write(samsung->regmap, DPHY_MC_DESKEW_CON0, val); } static void @@ -1284,12 +1290,14 @@ samsung_mipi_dphy_data_lane_timing_init(struct samsung_mipi_dcphy *samsung) regmap_write(samsung->regmap, COMBO_MD2_ANA_CON0, val); regmap_write(samsung->regmap, DPHY_MD3_ANA_CON0, val); - if (lane_hs_rate >= 4500) { - regmap_write(samsung->regmap, COMBO_MD0_ANA_CON1, 0x0001); - regmap_write(samsung->regmap, COMBO_MD1_ANA_CON1, 0x0001); - regmap_write(samsung->regmap, COMBO_MD2_ANA_CON1, 0x0001); - regmap_write(samsung->regmap, DPHY_MD3_ANA_CON1, 0x0001); - } + if (lane_hs_rate >= 4500) + val = 0x0001; + else + val = 0; + regmap_write(samsung->regmap, COMBO_MD0_ANA_CON1, val); + regmap_write(samsung->regmap, COMBO_MD1_ANA_CON1, val); + regmap_write(samsung->regmap, COMBO_MD2_ANA_CON1, val); + regmap_write(samsung->regmap, DPHY_MD3_ANA_CON1, val); val = 0; /* -- 2.43.0