mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sascha Bischoff <sascha.bischoff@arm.com>
To: Marc Zyngier <maz@kernel.org>,
	 Lorenzo Pieralisi <lpieralisi@kernel.org>,
	 Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>,
	 Timothy Hayes <timothy.hayes@arm.com>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	 Jonathan Cameron <jic23@kernel.org>,
	 "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,  Fuad Tabba <fuad.tabba@linux.dev>,
	 Sascha Bischoff <sascha.bischoff@arm.com>
Subject: [PATCH v3 08/14] irqchip/gic-v5: Use firmware node name in ITS warning
Date: Wed, 18 Nov 2026 17:35:37 +0000	[thread overview]
Message-ID: <20261118-host_gicv5_fixes-v3-8-13c1859e8aa3@arm.com> (raw)
In-Reply-To: <20261118-host_gicv5_fixes-v3-0-13c1859e8aa3@arm.com>

The common ITS initialiser can be called with an ACPI firmware node.
If firmware leaves the ITS enabled, the warning dereferences the DT
node pointer, which is NULL on that path.

Use the firmware node name for the warning and drop the DT-only
pointer.

Fixes: a97efa5ba5946 ("irqchip/gic-v5: Add ACPI ITS probing")
Signed-off-by: Sascha Bischoff <sascha.bischoff@arm.com>
Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
---
 drivers/irqchip/irq-gic-v5-its.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
index 9e8077dada5ef..876437017ccc5 100644
--- a/drivers/irqchip/irq-gic-v5-its.c
+++ b/drivers/irqchip/irq-gic-v5-its.c
@@ -1109,7 +1109,6 @@ static int gicv5_its_init_domain(struct gicv5_its_chip_data *its, struct irq_dom
 static int __init gicv5_its_init_bases(void __iomem *its_base, struct fwnode_handle *handle,
 				       struct irq_domain *parent_domain, bool noncoherent)
 {
-	struct device_node *np = to_of_node(handle);
 	struct gicv5_its_chip_data *its_node;
 	u32 cr0, cr1;
 	bool enabled;
@@ -1129,7 +1128,8 @@ static int __init gicv5_its_init_bases(void __iomem *its_base, struct fwnode_han
 
 	cr0 = its_readl_relaxed(its_node, GICV5_ITS_CR0);
 	enabled = FIELD_GET(GICV5_ITS_CR0_ITSEN, cr0);
-	if (WARN(enabled, "ITS %s enabled, disabling it before proceeding\n", np->full_name)) {
+	if (WARN(enabled, "ITS %s enabled, disabling it before proceeding\n",
+		 fwnode_get_name(handle))) {
 		ret = gicv5_its_disable(its_node);
 		if (ret)
 			goto out_free_node;

-- 
2.34.1


  parent reply	other threads:[~2026-11-18 17:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 17:35 [PATCH v3 00/14] irqchip/gic-v5: Fix misc IRS and ITS host driver issues Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 01/14] irqchip/gic-v5: Reject SPIs not backed by an IRS Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 02/14] irqchip/gic-v5: Only set IRS DPS when 1ofN routing is supported Sascha Bischoff
2026-11-19 11:50   ` Fuad Tabba
2026-11-18 17:35 ` [PATCH v3 03/14] irqchip/gic-v5: Serialise IRS synchronisation requests Sascha Bischoff
2026-11-19 11:53   ` Fuad Tabba
2026-11-18 17:35 ` [PATCH v3 04/14] irqchip/gic-v5: Retain the L2 IST when mapping times out Sascha Bischoff
2026-11-19 12:00   ` Fuad Tabba
2026-11-18 17:35 ` [PATCH v3 05/14] irqchip/gic-v5: Serialise ITS invalidation commands Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 06/14] irqchip/gic-v5: Use linear DT and ITT when L2 covers all IDs Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 07/14] irqchip/gic-v5: Honour ACPI ITS noncoherent flag Sascha Bischoff
2026-11-18 17:35 ` Sascha Bischoff [this message]
2026-11-18 17:35 ` [PATCH v3 09/14] irqchip/gic-v5: Invalidate ITS device cache before freeing ITT Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 10/14] irqchip/gic-v5: Clean the allocated linear device table size Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 11/14] irqchip/gic-v5: Release ITS MMIO region on DT probe failure Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 12/14] irqchip/gic-v5: Retain the ITT when device invalidation times out Sascha Bischoff
2026-11-19 10:28   ` Lorenzo Pieralisi
2026-11-19 12:07     ` Fuad Tabba
2026-11-18 17:35 ` [PATCH v3 13/14] irqchip/gic-v5: Clean a level 2 device table before making it valid Sascha Bischoff
2026-11-19 10:19   ` Lorenzo Pieralisi
2026-11-18 17:35 ` [PATCH v3 14/14] irqchip/gic-v5: Invalidate the L1 DTE when allocating an L2 device table Sascha Bischoff
2026-11-19 10:13   ` Lorenzo Pieralisi
2026-11-19 12:32     ` Fuad Tabba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118-host_gicv5_fixes-v3-8-13c1859e8aa3@arm.com \
    --to=sascha.bischoff@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=fuad.tabba@linux.dev \
    --cc=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=maz@kernel.org \
    --cc=radu@rendec.net \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tglx@kernel.org \
    --cc=timothy.hayes@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®