From: Conor Dooley <conor@kernel.org>
To: Marcelo Schmitt <marcelo.schmitt@analog.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux@analog.com, jic23@kernel.org,
Michael.Hennerich@analog.com, nuno.sa@analog.com,
eblanc@baylibre.com, dlechner@baylibre.com, andy@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
olivier.moysan@foss.st.com, marcelo.schmitt1@gmail.com
Subject: Re: [PATCH v1 4/5] dt-bindings: iio: adc: Add ADA4355
Date: Wed, 18 Nov 2026 17:39:46 +0000 [thread overview]
Message-ID: <20261118-liver-decompose-434eedb257b8@spud> (raw)
In-Reply-To: <c7be62089d2b54dbf7fb57cdea189bdb1cade7c5.1795003864.git.marcelo.schmitt@analog.com>
[-- Attachment #1: Type: text/plain, Size: 4703 bytes --]
On Wed, Nov 18, 2026 at 10:04:13AM -0300, Marcelo Schmitt wrote:
> The ADA4355 is an integrated analog front-end and 14-bit analog-to-digital
> converter with a serial LVDS data interface.
>
> Document how to describe ADA4355 devices in device tree.
Please explain why the 4356 differs rom the 4355 such that it cannot use
a fallback compatible.
Thanks,
Conor.
pw-bot: changes-requested
>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> ---
> .../bindings/iio/adc/adi,ada4355.yaml | 104 ++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 111 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ada4355.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ada4355.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ada4355.yaml
> new file mode 100644
> index 000000000000..d169619fef25
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ada4355.yaml
> @@ -0,0 +1,104 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ada4355.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices Transimpedance Current to Bits Receiver
> +
> +maintainers:
> + - Marcelo Schmitt <marcelo.schmitt@analog.com>
> +
> +description: |
> + ADA4355 programmable transimpedance, current to bits receiver and similar data
> + converters.
> + Specifications can be found at:
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ada4355.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ada4356.pdf
> +
> +$ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ada4355
> + - adi,ada4356
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 50000000
> +
> + spi-3wire: true
> +
> + spi-cpha: true
> +
> + vcc-supply:
> + description: 3.3V power supply.
> +
> + vea-supply:
> + description: 1.8V analog power supply to ADC.
> +
> + ved-supply:
> + description: 1.8V digital power supply to ADC.
> +
> + clocks:
> + maxItems: 1
> +
> + adi,vld-en-gpios:
> + description: GPIO connected to the VLDEN pin for VLD output enable.
> +
> + adi,gsel-gpios:
> + description:
> + GPIOs connected to the GSEL0 and GSEL1 pins, in that order, for
> + transimpedance gain selection.
> + minItems: 2
> + maxItems: 2
> +
> + adi,lfp-gpios:
> + description:
> + GPIO connected to FSEL for internal low pass filter bandwidth selection.
> +
> + io-backends:
> + description:
> + The AXI ADC IP block connected to the D+/- and DCO+/- lines of the
> + ADC. An example backend can be found at
> + http://analogdevicesinc.github.io/hdl/projects/pulsar_lvds/index.html.
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - vcc-supply
> + - spi-3wire
> + - spi-cpha
> + - clocks
> + - adi,vld-en-gpios
> + - adi,gsel-gpios
> + - adi,lfp-gpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adc@0 {
> + compatible = "adi,ada4355";
> + reg = <0>;
> + spi-max-frequency = <100000>;
> + spi-3wire;
> + spi-cpha;
> + vcc-supply = <&supply_3_3V>;
> + clocks = <&ref_clk>;
> + adi,vld-en-gpios = <&gpio0 89 GPIO_ACTIVE_HIGH>;
> + adi,gsel-gpios = <&gpio0 86 GPIO_ACTIVE_HIGH>,
> + <&gpio0 87 GPIO_ACTIVE_HIGH>;
> + adi,lfp-gpios = <&gpio0 88 GPIO_ACTIVE_HIGH>;
> + io-backends = <&axi_adc>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 02015eaec312..692f1e6d56ec 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1794,6 +1794,13 @@ W: https://ez.analog.com/linux-software-drivers
> F: Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
> F: drivers/iio/amplifiers/ada4250.c
>
> +ANALOG DEVICES INC ADA4355 DRIVER
> +M: Marcelo Schmitt <marcelo.schmitt@analog.com>
> +L: linux-iio@vger.kernel.org
> +S: Supported
> +W: https://ez.analog.com/linux-software-drivers
> +F: Documentation/devicetree/bindings/iio/adc/adi,ada4355.yaml
> +
> ANALOG DEVICES INC ADE9000 DRIVER
> M: Antoniu Miclaus <antoniu.miclaus@analog.com>
> L: linux-iio@vger.kernel.org
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-11-18 17:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:02 [PATCH v1 0/5] Add support for ADA4355 Marcelo Schmitt
2026-11-18 13:03 ` [PATCH v1 1/5] iio: backend: Add calibration source interface Marcelo Schmitt
2026-11-18 13:03 ` [PATCH v1 2/5] dt-bindings: iio: adc: Add AXI ADA4355 IP CORE Marcelo Schmitt
2026-11-18 17:38 ` Conor Dooley
2026-11-18 13:03 ` [PATCH v1 3/5] iio: adc: adi-axi-adc: Support AXI ADA4355 IP core Marcelo Schmitt
2026-11-18 13:04 ` [PATCH v1 4/5] dt-bindings: iio: adc: Add ADA4355 Marcelo Schmitt
2026-11-18 17:39 ` Conor Dooley [this message]
2026-11-18 13:04 ` [PATCH v1 5/5] iio: adc: Add support for ADA4355 and similar ADCs Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118-liver-decompose-434eedb257b8@spud \
--to=conor@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=eblanc@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®