From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=100.103.45.18 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1795039165; b=L8IcDD4MescixT/mcL/2Kj8ilG70luENpKwUYDrG2O/TQZ15LWbzE7oyl4cOGg8nxLRh 7THOGC3zRhwKqKAmrIGNlgJJjlkLsxvRXdNmMk0lnN5oE+sJxd6HevOvOdfvenWk2Xl/6 rlU/1HMXbQ5Z9loX9teGmBLkeXmwOs+dhtJ1m1+Mi0+KrA1d8Z5b1gmoaH5dBKqhZ5jCZ E9RAr4YOXgEoQ9r4pPlKefWd5hU2BOnlDQCk3Bqyp37nkL933rqOTrtcxK9YXX+kYM6RN ay5yLdxnJ/we5BIN3w2qrF2b/IsocfCpddkreHwXgZ8jIzU1oKKJaJDiPY+wEJD81aw== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795039165; h=Received:DKIM-Signature:Received:From:Subject:Date:Message-Id: MIME-Version:Content-Type:Content-Transfer-Encoding:X-B4-Tracking: X-Change-ID:To:Cc:X-Mailer:X-Developer-Signature:X-Developer-Key: X-Endpoint-Received:X-Original-From:Reply-To; bh=Ea27Ot+ehzrAuRSoKcNDt2qvaz6iTBMPzRnS1G4L6jg=; b=Od/gdIr1spPaamtFKOPwyLL8LEPKLvbfJ/gRKKnFxFZ+SngWsgdnFkf4zSLGc1AowLLq 5zKm/y2wFL9xnSuEnLInaYAblZlnMUOgqUY56o4enM5Pj54LrKTSQdhXVSOYZ7JFJIl8l wV3NDIAjpNIHzzwydTBvChz43njeJ40BK1jD/mOU1eRgMpX+NToZcVHeIHxvv1V40Gps+ KrKhwhy2SrO4bt0XLFS+NRRKtBZPZWjDUoLCt0UueL7mDGn3wE7zLz+/sNrVUAD66aYZL o/anyIBdO9zMb8WvEICtQ127kzUhIm3ay5gufbm989k2s0rZV3n33Hjo8Jg9Cop1aGA== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Rm2Hmmb4; arc=pass header.oldest-pass=0 smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61F73606A31C; Wed, 18 Nov 2026 21:59:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Rm2Hmmb4 Authentication-Results: smtp.kernel.org; arc=none smtp.remote-ip=100.80.115.77 ARC-Seal: i=1; d=kernel.org; s=arc20260519; a=rsa-sha256; cv=none; t=1795039165; b=DWTnBk12sZdF8zsdz9gCwZhv+vYWe3lj68ba0afbHF6Efsi5k1vx2XUhEuda9nkIsQ6U 8UUCLzwgTa5yKFOsTIsR8e3ziEYEat/uHxzYc/Ap1Uft0SCK3eO/SfW/sNB30hcF9uuSn H5RGi02ffZ6P92b2XEWEEAg6fMzrwWBkCl0FHKqyqLlos6wk5SE89+iMJCgbGqdQk8rJj CzZ7isjJeChWH8Z6L4MtFvbsuXAaBabQNYgms1OT0HH54Jl/qrWwCuCuLwR1GJxLZgKrY aXJXrDE56BJ0qUVEO/uBpxgsiAu6s733FH7nl+RuliebBTn0ZSbTzItZ27CqtCCWE9g== ARC-Message-Signature: i=1; d=kernel.org; s=arc20260519; a=rsa-sha256; c=relaxed/relaxed; t=1795039165; h=DKIM-Signature:Received:From:Subject:Date:Message-Id:MIME-Version: Content-Type:Content-Transfer-Encoding:X-B4-Tracking:X-Change-ID:To: Cc:X-Mailer:X-Developer-Signature:X-Developer-Key:X-Endpoint-Received: X-Original-From:Reply-To; bh=Ea27Ot+ehzrAuRSoKcNDt2qvaz6iTBMPzRnS1G4L6jg=; b=vnbrzcM0ACGiao2hpRFRi5VeEHM5OehtFUtLvx9I27CA/EcXlrYYWyUSIR39M2awf1VZ SbLxd+LYhSzluoswD5Gg7NjUYrTFqJb+w8fJgW/fYgsB8BWszPlmScYqBnxmaHp80+SXN FKOl/2FKqwOCx4l6ZP28X++XcthHU54GEnbultWoFcG79cYP1Ww6seafWvqyjUD6Bl4Vj wo4Or/VgR//a+utONeWgTh2+UObAsnbDwFLu5En7L70xoS2frXICwG3Ge3roOdJHKYDxS UTlDEs7dF360Kov6l8TU7YDrwZnjcXZ7XF49oieLLQVdZYdtSOJVB7K0/nff02JX3QQ== ARC-Authentication-Results: i=1; smtp.kernel.org; arc=none smtp.remote-ip=100.80.115.77 Received: from lkml.kernel.org (nexus.subspace.kernel.org [100.80.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id A6E8A1F000C4; Wed, 18 Nov 2026 21:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795039165; bh=Ea27Ot+ehzrAuRSoKcNDt2qvaz6iTBMPzRnS1G4L6jg=; h=From:Subject:Date:To:Cc:Reply-To; b=Rm2Hmmb47BdMevLkbFJQUrSi1TWermrXl3QJtZMhr8reX1J3w0EvxDUvIxw1Ac2nG 7xKDUd9UPsF/R7gOFst3/YqYT0S4KpdScvIYnJh221gyUqcoJrVdmr1XRuci4ckfnv 4KihRK1CEH/HWvwMohiYfdG0RSuIKbu9CIQ8HZsU5R/BQL038kNaNf3FKkBOkHUoBl Sf88wMebLLFwrZ0eYM77FkaBr4LomRTHOfThbUSBislJvdyO+ZID4lQcuyliVP9kcK V/Es5yEjQ0S5srs7LItdWvorf9FR3swXDwASJWzUZbmT8L4aBFin91NG8ig2ZUJ9gF RypFw+og+GlBA== Received: from nexus.subspace.kernel.org (localhost [IPv6:::1]) by lkml.kernel.org (Postfix) with ESMTP id 03AD94AFE3; Wed, 18 Nov 2026 21:59:24 +0000 (UTC) From: Harrison Crosse via B4 Relay Subject: [PATCH 0/2] mm/gup: fix mlock() and MAP_POPULATE looping on read errors Date: Wed, 18 Nov 2026 16:56:40 -0500 Message-Id: <20261118-mmpop-populate-v1-0-9c561d178d11@crosse.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAA/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzNDQ0ML3dzcgvwCXSAuzUksSdW1SDS2ME1NSzRPNU9TAmoqKEpNy6wAGxg dC+EXlyZlpSaXgExRqq0FADAipz5yAAAA X-Change-ID: 20261118-mmpop-populate-8a385efa7e7f To: David Hildenbrand , Jason Gunthorpe , John Hubbard , Peter Xu , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Josef Bacik , Johannes Weiner , Jan Kara , Harrison Crosse , stable@vger.kernel.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1795039163; l=2455; i=harrison@crosse.dev; s=20261117; h=from:subject:message-id; bh=/PkZRnZe5tu6LV293Ifp8K0JXLUKyW2KwcahuxQz4ow=; b=OSles3yksDQFXG/3q0tQCEMz+u/knBGbhU4exaXmvxAgSt04CoaGw4td44kcwey09njt++Nuc HjqbxmMiv9fDRR9KESgxdSjanyuJaf+XCzQHDuSAX5Nsnb69pTt5ZLy X-Developer-Key: i=harrison@crosse.dev; a=ed25519; pk=fwi/XME2YaW/BDBQ76FmKgF9xHZwRb+dxlVCbxuyojo= X-Endpoint-Received: by B4 Relay for harrison@crosse.dev/20261117 with auth_id=1552 X-Original-From: Harrison Crosse Reply-To: harrison@crosse.dev If every read of a page in a file mapping fails, mmap(MAP_POPULATE) and mlock() of that mapping retry the read in the kernel until the task gets a fatal signal. A load from the page gets SIGBUS, and MADV_POPULATE_READ fails with EFAULT. Patch 1 makes __mm_populate() pass FOLL_TRIED when retrying the page whose fault released the mmap_lock, as __get_user_pages_locked() does, so that a read error ends the loop. mlock() then fails with ENOMEM, and mmap(MAP_POPULATE) returns the mapping. Patch 2 adds populate_eio, a selftest that serves such a file over FUSE and fails without patch 1. The series is based on v7.4-rc3. The bug was reproduced with the ext4 setup described in patch 1 on v7.4-rc3 (arm64 and x86_64), Debian 6.12.116 (arm64) and 6.6.162 (x86_64). Under QEMU TCG, populate_eio passes its MADV_POPULATE_READ check and fails its mmap(MAP_POPULATE) and mlock() checks without patch 1 on v7.4-rc3 (arm64 and x86_64) and on 6.12.117 (x86_64), and passes all three checks with patch 1 on v7.4-rc3 on both architectures. To reproduce, build and run populate_eio from patch 2 as root on a kernel with CONFIG_FUSE_FS. The fix was tested only on v7.4-rc3, on arm64 and x86_64 with 4K pages. On arm64, only populate_eio was run on the patched kernel. Also not tested: populate_eio in unprivileged user namespaces or on kernels older than 6.12, the ext4 setup on kernels older than 6.6, and populate_eio timing out or getting SIGKILL during a call on the patched kernel, where every call returns at once. The notes in each patch list the other cases that were not tested. The analysis and the patches were prepared with the help of an AI coding assistant (Claude). Signed-off-by: Harrison Crosse --- Harrison Crosse (2): mm/gup: make mlock() and MAP_POPULATE handle VM_FAULT_RETRY properly selftests/mm: add a test for populating a page that cannot be read mm/gup.c | 36 ++- tools/testing/selftests/mm/Makefile | 1 + tools/testing/selftests/mm/config | 1 + tools/testing/selftests/mm/populate_eio.c | 410 ++++++++++++++++++++++++++++++ tools/testing/selftests/mm/run_vmtests.sh | 1 + 5 files changed, 445 insertions(+), 4 deletions(-) --- base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3 change-id: 20261118-mmpop-populate-8a385efa7e7f Best regards, -- Harrison Crosse