From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794990785; b=DO/We5u+ia81PmO9YWLlw/QMK7suhEkMkeKINIxHZchhLAu4zS2zxZUztFGOnTKb7q+o br4NaV8D8Sw0EjTqO4QGNHUjaJcmgR0aBG5AVqa15WGyjQF+cVKqhRPXgMTThll5Hic3/ 2rul+xOxwY6D4lEv8T3bagiO1+Gf9IY+SQJ+OvgUb97s044PGJ3unhkUkHno9i8njK32d YiTiF68l1BGoz6ipfeBxJdOMiVGrNpQqu+FV9SQP1Ix3lKiZ+IzQl1VYN3QgZPi2SUqh6 JjdNX6ukT3y/lOG4tfv/qHxfM4ozkY6IVPqSGBPeGWVZnRKwvVr9VTlIO82vj1cbElA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794990785; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=X5+mrw7HYEFvCvOyayXlxKhQQJlRFubrquRPaak2JSQ=; b=4yu8Q9yPHeZ8pAOf7ytFtpUTgg0IhKbP7xZwwVmvHUij0XxaC+HUVqNupJcLNQ0rSWAL ogoB10kYWASYvlHI5UTSib/YZmD4gELRzrOXRZ7GLkZ/qv0MLSEbQXuAfueq/oQj7HiPM 2LVKndI/2AZoxdfN4VrzHaIWMNPbehM8JaJL/gVu+Wb8O46cVYV4I4z+TU8sKFJBe8afZ GSxxyjg+tpV3LnzLx60LWA0PAFBa5vW4WX715nRLcxlHoGAr2PhtNmpiwkm0+kGngNcL5 GB8RIbbPq98dsNKoj9oNsjYSqN0qjAqSIcR8S0xnCh+7Yp1YF9tEvMVK+eqm2FPLtsg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="L/YSrX82"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38D55606A31C; Wed, 18 Nov 2026 08:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=L/YSrX82 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4929C1F000C7; Wed, 18 Nov 2026 08:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794990784; bh=X5+mrw7HYEFvCvOyayXlxKhQQJlRFubrquRPaak2JSQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=L/YSrX82F8z9WFIi6QltKHwZGwMN9NQr/tSIimA5pPLoYsWlAF5BTwGKkihRQyheA YLF2IWkwSQC7r+xLmiy3V6W5wuayTTpmoY/a90hz541g7Pz/gzttomAVnR4ir0VecV TetLsC1g1dQSm7iry1ygk9dFD7ZDiupt+7o95IO/cfJSVSs2MKtd39cBfE/3G21LCT +t1g0ToEXAycI6B799CKZPYmskaE91lgSCSbqDraH5UXU8e3hIeidJAkAe2um9Fb/C 7RrXRkaYtDayfYMLoqQZDkpPVaVzBCfi3PTLvPcScApK6lEAIRS8e5b/C+Z7pQanFq qQGW4ECbPLdaw== From: "David Hildenbrand (Arm)" Date: Wed, 18 Nov 2026 09:32:38 +0100 Subject: [PATCH net 1/4] net: skbuff: limit folio refcount when copying skb frag references X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261118-skb_refcount_overflow-v1-1-5551b4954c3f@kernel.org> References: <20261118-skb_refcount_overflow-v1-0-5551b4954c3f@kernel.org> In-Reply-To: <20261118-skb_refcount_overflow-v1-0-5551b4954c3f@kernel.org> To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Morton , Kiryl Shutsemau , Song Liu , Johannes Weiner , Rik van Riel , "Matthew Wilcox (Oracle)" , Neal Cardwell , Kuniyuki Iwashima , Pedro Falcato Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "David Hildenbrand (Arm)" , stable@vger.kernel.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=7095; i=david@kernel.org; h=from:subject:message-id; bh=81ha1g6Of6vaYR5pJbvgdvPTEKVuj17huB66s5amVak=; b=owGbwMvMwCF2/OVpCdfQ3ZWMp9WSGLL+Jm3jWfBVwI1jieq5xeETNmc239h0YEpGYcrevxlXD lnuZZXR7yhlYRDjYJAVU2QJCr5v8PLlutpqNz5mmDmsTCBDGLg4BWAiX5cz/M9xmNISKlLackon w+UfF//56dufKeypSW07Wsk19eC1wE0M/wusZ8kVXzgm7vlg/xvmA8cCAtVdq54+Wn/sT1Z6S3P hYkYA X-Developer-Key: i=david@kernel.org; a=openpgp; fpr=1BD9CAAD735C4C3A460DFCCA4DDE10F700FF835A Various networking features copy frag references of an skb, for example when unsharing a cloned skb (AF_PACKET trimming a clone), when copying an skb (nft dup) or when building NFQUEUE messages. This is an effective way for multiplying folio references held by an skb, allowing for exceeding folio refcount limits. This is not specific to large pagecache folios, but with them it is a lot easier to reach the refcount limit, as page table mappings can cheaply create many references. Let's introduce skb_frag_try_ref() and skb_frags_try_ref(), which use try_get_page(), and use them in pskb_expand_head(), __pskb_copy_fclone(), skb_zerocopy() and pskb_carve_inside_*(). All of these can already fail, and their callers handle that. Fixes: 800d8c63b2e9 ("shmem: add huge pages support") Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS") Fixes: 793917d997df ("mm/readahead: Add large folio readahead") Cc: stable@vger.kernel.org Acked-by: Pedro Falcato Signed-off-by: David Hildenbrand (Arm) --- include/linux/skbuff_ref.h | 53 ++++++++++++++++++++++++++++++++++++++++++++++ net/core/skbuff.c | 35 +++++++++++++++++++----------- 2 files changed, 76 insertions(+), 12 deletions(-) diff --git a/include/linux/skbuff_ref.h b/include/linux/skbuff_ref.h index b6f6da556ee90..560ddc863bbec 100644 --- a/include/linux/skbuff_ref.h +++ b/include/linux/skbuff_ref.h @@ -44,6 +44,33 @@ static __always_inline void skb_frag_ref(struct sk_buff *skb, int f) skb->pp_recycle); } +/** + * skb_frag_try_ref - try to acquire a reference on a paged fragment of an skb + * @skb: the buffer + * @f: the fragment offset + * + * Like skb_frag_ref(), but acquires non-page_pool page references using + * try_get_page(), refusing additional references to a page whose refcount is + * at its limit. + * + * Return: True if a reference was acquired, otherwise false. + */ +static __always_inline __must_check bool skb_frag_try_ref(struct sk_buff *skb, + int f) +{ + netmem_ref netmem = skb_frag_netmem(&skb_shinfo(skb)->frags[f]); + +#ifdef CONFIG_PAGE_POOL + if (skb->pp_recycle && napi_pp_get_page(netmem)) + return true; +#endif + if (netmem_is_net_iov(netmem)) { + net_iov_inc_ref(netmem_to_net_iov(netmem)); + return true; + } + return try_get_page(netmem_to_page(netmem)); +} + bool napi_pp_put_page(netmem_ref netmem); /** @@ -83,4 +110,30 @@ static __always_inline void skb_frag_unref(struct sk_buff *skb, int f) skb->pp_recycle); } +/** + * skb_frags_try_ref - try to acquire references on all paged fragments + * @skb: the buffer + * + * Try to acquire a reference on each paged fragment of @skb using + * skb_frag_try_ref(). On failure, acquired references are dropped. + * + * Must not be used on skbs with managed frag references. + * + * Return: True if all references were acquired, otherwise false. + */ +static inline __must_check bool skb_frags_try_ref(struct sk_buff *skb) +{ + int i; + + DEBUG_NET_WARN_ON_ONCE(skb_zcopy_managed(skb)); + for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) { + if (unlikely(!skb_frag_try_ref(skb, i))) { + while (i--) + skb_frag_unref(skb, i); + return false; + } + } + return true; +} + #endif /* _LINUX_SKBUFF_REF_H */ diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 1ac1e327ac4c6..447099b39deeb 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -2266,7 +2266,13 @@ struct sk_buff *__pskb_copy_fclone(struct sk_buff *skb, int headroom, n->pp_recycle = skb->pp_recycle; for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) { skb_shinfo(n)->frags[i] = skb_shinfo(skb)->frags[i]; - skb_frag_ref(n, i); + if (!skb_frag_try_ref(n, i)) { + /* Drop the references acquired so far. */ + skb_shinfo(n)->nr_frags = i; + kfree_skb(n); + n = NULL; + goto out; + } } skb_shinfo(n)->nr_frags = i; skb_shinfo(n)->flags |= skb_shinfo(skb)->flags & SKBFL_SHARED_FRAG; @@ -2310,7 +2316,6 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail, unsigned int size = osize + nhead + ntail; long off; u8 *data; - int i; if (unlikely(nhead < 0)) { DEBUG_NET_WARN_ON_ONCE(1); @@ -2347,12 +2352,10 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail, * be since all we did is relocate the values */ if (skb_cloned(skb)) { - if (skb_orphan_frags(skb, gfp_mask)) + if (skb_orphan_frags(skb, gfp_mask) || !skb_frags_try_ref(skb)) goto nofrags; if (skb_zcopy(skb)) net_zcopy_get(skb_uarg(skb)); - for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) - skb_frag_ref(skb, i); if (skb_has_frag_list(skb)) skb_clone_fraglist(skb); @@ -3908,7 +3911,8 @@ EXPORT_SYMBOL_GPL(skb_zerocopy_headlen); * * Return value: * 0: everything is OK - * -ENOMEM: couldn't orphan frags of @from due to lack of memory + * -ENOMEM: couldn't orphan frags of @from due to lack of memory, or + * couldn't take additional references to the frags of @from * -EFAULT: skb_copy_bits() found some problem with skb geometry, or readable head * payload would be mixed with unreadable frags. */ @@ -3973,7 +3977,11 @@ skb_zerocopy(struct sk_buff *to, struct sk_buff *from, int len, int hlen) len); skb_frag_size_set(&skb_shinfo(to)->frags[j], size); len -= size; - skb_frag_ref(to, j); + if (!skb_frag_try_ref(to, j)) { + /* The caller frees @to, dropping the acquired refs. */ + skb_shinfo(to)->nr_frags = j; + return -ENOMEM; + } j++; } skb_shinfo(to)->nr_frags = j; @@ -7004,7 +7012,6 @@ static void skb_carve_reset_headers(struct sk_buff *skb) static int pskb_carve_inside_header(struct sk_buff *skb, const u32 off, const int headlen, gfp_t gfp_mask) { - int i; unsigned int size = skb_end_offset(skb); int new_hlen = headlen - off; u8 *data; @@ -7032,14 +7039,12 @@ static int pskb_carve_inside_header(struct sk_buff *skb, const u32 off, frags[skb_shinfo(skb)->nr_frags])); if (skb_cloned(skb)) { /* drop the old head gracefully */ - if (skb_orphan_frags(skb, gfp_mask)) { + if (skb_orphan_frags(skb, gfp_mask) || !skb_frags_try_ref(skb)) { skb_kfree_head(data); return -ENOMEM; } if (skb_zcopy(skb)) net_zcopy_get(skb_uarg(skb)); - for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) - skb_frag_ref(skb, i); if (skb_has_frag_list(skb)) skb_clone_fraglist(skb); skb_release_data(skb, SKB_CONSUMED); @@ -7169,7 +7174,13 @@ static int pskb_carve_inside_nonlinear(struct sk_buff *skb, const u32 off, skb_frag_off_add(&shinfo->frags[0], off - pos); skb_frag_size_sub(&shinfo->frags[0], off - pos); } - skb_frag_ref(skb, i); + if (!skb_frag_try_ref(skb, i)) { + /* We referenced frags i - k ... i - 1 so far. */ + while (k--) + skb_frag_unref(skb, --i); + skb_kfree_head(data); + return -ENOMEM; + } k++; } pos += fsize; -- 2.43.0