From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.161.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795022381; b=VeoknhDigfUA6cRVanybI0q0DGHbtmBxxE1ECuE6bgCNHaZLkxdJ9c0t9RHML7KJrnce fp/4ZQ9z1Ogb29/6zHbJHhUXNJhWx8IHzN1JDxaJb5AdHvgCbTljKIpLMx+SPCitkN6Nj +ZLZQT9bWrDNLId0qLMvZbY0JjpGT5dtPG834EZGj6UZPhivswPimxtuM+sx/vpfwiuaQ WG6rmua8Br8BPlAw7Vv2cTnu7BrdyEtJeeNTbWt+3He38V6FpjZ6T7h+owndaUeam0aLt 7dJKqA2G2bhznYxtw0jKca8z7b0uMj+wWDzbpY+0OZq0Biz8d6WOa+FZFwj9ITlIlSA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795022381; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:X-B4-Tracking:X-Change-ID:To:Cc:X-Mailer; bh=6gP6svfhzOhB+3p01vqjLTOkJSkqMxk4Z3G7OPboewU=; b=uLCuWph6B0atAWrICPRR/5A0iqjudNHTeNORiw6yhlGzprtPKejL67Qv88eKupGanZSh uykO1cqhAcpfXu7+i0lxnfH7Sme2ZwGSE0vVLX8Dkmj4m/k1Uk1a2fLIhj8ZYrggmcTQc AfEKColQinGsvHRpkBCEaeQbMPvJOhkXZ2Ns3n/5ObYLwYO3VM2XayR6MepE1rn3PJUkd 0Y7MFYH4Z8JOb/CFOSxFaFJtD+K0T+EgFp9qx79X9c8CySUmFXBbJ4BbKJ4PGoQxHBEo2 0m7jGtlc+W0lhdAnpzW2M0Rja2DmYr5koTWAfJuq8uco+hSSlIVJgA3aXYmr95RBBNQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=ySryMbre; arc=none smtp.remote-ip=209.85.161.53 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50BBD606A325 for ; Wed, 18 Nov 2026 17:19:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 50BBD606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=ySryMbre Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-716d052dc23so678867eaf.1 for ; Wed, 18 Nov 2026 09:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795022379; x=1795627179; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=6gP6svfhzOhB+3p01vqjLTOkJSkqMxk4Z3G7OPboewU=; b=ySryMbrerU2OL5LMFOG00781tRrBu4NNWGf6VTub9ChTa3BRCTAIfRf25dhoc/5vkn Zp1s5aI4rfuyxXxA89jB9pmB7gE8VDz5zp0Ox2v/vwC9Qqq9Bshc+jssSsdnfOPUCkFY lN3kCayeLN5tu3X4g9+DFj1m3r/sATfyaRm6E8FWlgTRA7fwzFg4Nnu1a4yt5Y7QBkeQ EZlBADO3E+48yoWXnhjaFLfx7CBnrCuhBO2f0VC54T62hC24JdYIIRXQy5lOFCANjyL4 5t0J4kJn0HpR30ic0AOGIcdKOfBxxB7vwsUrionTKEyrm6kOcVOFIKETsR663vRwRcOy 3WfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795022379; x=1795627179; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=6gP6svfhzOhB+3p01vqjLTOkJSkqMxk4Z3G7OPboewU=; b=w21a3up0tW6aAWx8FRPZ7HXozgQQcrGVQB8ATOyKiRSNrEaZbIPQ8d7F+os0SMgzJB WofwxT9Esxgb7F8AcgfWM8X38BfLN9jNE/xN2y0PeY2IFE4UdOd3C3MwxyUf4DjIGbU7 X4ymTYrT5vl0hBuL1zn1JSpOh2GotelQsptWI0khEbK3TGQF683i1rNFT8TZYcLpGphJ JmtEjReAKLxjRw/77iC+RbmfksHCR8Fwq/0iYDReh9I42NGz2wyuFQkbCMpHOJOasFlU xbw1WIWGAtVgXjlFf5anSASNGW4cGRP+H8JSKRSIUvwd5J8A1+kZiH1B82b4a6TH9H2B RQqQ== X-Forwarded-Encrypted: i=1; AL+hErEGrFxVSM3a2lrAGIUOfc9JiEOvkrivt2wBytGtdC7ZpHgNBc4pqjRHtd1hOc/uit2YCC2BjnYflUca/7E=@vger.kernel.org X-Gm-Message-State: APuU4Z8K2uStjuVJX4rZnnmFTx8g39Kdzp+fMzCnAeDbe9vzPNDB6c1I 7l8MriLMvrd1J1+KFKozDd+Jpv9xRA3RFcjj2XaexxtlEXSWiwqOU1UtfUe5A0wW X-Gm-Gg: AYBFou3sN94Q5ENsgQWKFGlhxtKUcMDrj8v5JjBwUYDMz0Rl7DNRdQmTpXLk3HNNYvO uWiqHG4ir5A+bRXK3GDtyoGsCOefqdFML2iVq3vySGx+3r+rZMY721K/DPVqxx3KWsTNwYrJ8dj VGWNm86R5IIlekyzmx9W8NTYoTegEALVmh10foB/eDcUwsobrNqXKXxA7KLF3iQ2ToFhZSoS5Sm J8IC/JWg6lPbJL+XlGOH00rc/j2D6guNa9HNw4wEFioKc7GMnCxiaRIU9yU6uxEx6W4gv9s7Z70 nua867puEhkILewx201wbKMwgFncGD+4+qooHLRtXRG/X75nR5YFP+YPPCKtlHpXawb1BaQTwcs nIAxmDzIwfNGt8jrbOTv34qtbkCafDhdfI+3+FDWodN4C9GzkCktLbbwjYPUhsusjMxiVBIv2yz UzpPr9BcO4hU/HIA0vAu9N8pwGNGKL7mFqh8NPKV1PhwoOSOQXqGPX2mjXco6Luebaij1L+Z69a En6TsT+EmdCUv1xUmP9vrQeEumz9QqMbR2i6PKGn4riiPdevzy4RlD6W65rAeFDUkVuPN8Qkilt UQUAC3Ls35v0qpt7Zu/XpkChj3NZQfR8Htqb439sPvZY2w9KTeMwsSkXWpthZ37RyjmlzEeeTJZ +fvCIfqfEm2u9I4OZvnWsN31AoZlVvVvGsRHiQB0jR2FpCx8Vd8FfpdDOAW/K/ecwTrl6MY93kq ak90cDwWAJPx2eZYeITVKCERX1bEuJmFHPIdQwfEYS4RM/4Fqr10I= X-Received: by 2002:a05:6820:c3c8:b0:6f5:217:b0a2 with SMTP id 006d021491bc7-71b1827bc1fmr1617469eaf.12.1795022379086; Wed, 18 Nov 2026 09:19:39 -0800 (PST) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-862f021298dsm2495575a34.16.2026.11.18.09.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 09:19:38 -0800 (PST) From: James Hilliard Date: Wed, 18 Nov 2026 10:18:36 -0700 Subject: [PATCH v2] mtd: core: skip empty read and write requests X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261118-submit-mtd-empty-io-v1-v2-1-b980927931ef@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/4WNQQ6CMBBFr0K6dgxTmmpceQ/DopQBxlhK2kokh Ltb8AAmf/OS//5fRaTAFMWtWEWgmSP7MYM8FcIOZuwJuM0sZCk1YqkgvhvHCVxqgdyUFmAPM4I 2pW6bq1ZYocjyFKjjzzH8qH+czSfZtK/tjYFj8mE5nmfce39PchCqTje2UxdF0tx7Z/h1tt6Je tu2L/6wvzPOAAAA X-Change-ID: 20261104-submit-mtd-empty-io-v1-6a06db864131 To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Boris Brezillon Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, James Hilliard X-Mailer: b4 0.17-dev When mtd_read() and mtd_write() became wrappers around the OOB helpers, they lost their zero-length checks. An empty read at the end of a raw NAND device can then compute a die index one past the last die and hit the WARN_ON() in nand_select_target(). Return success from the common helpers without calling the driver when the request is valid but has neither data nor OOB bytes to transfer. Fixes: 2431c4f5b46c ("mtd: Implement mtd_{read,write}() as wrappers around mtd_{read,write}_oob()") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/sashiko-outbox-198544@kernel.org Signed-off-by: James Hilliard --- Changes in v2: - Clarify that the invalid die index triggers a warning at EOF. - Link to v1: https://patch.msgid.link/20261104-submit-mtd-empty-io-v1-v1-1-3f6bcf474e2a@gmail.com --- drivers/mtd/mtdcore.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index b170c3144ca8..ea21dc1bb5de 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -1805,6 +1805,9 @@ int mtd_read_oob(struct mtd_info *mtd, loff_t from, struct mtd_oob_ops *ops) if (ops->stats) memset(ops->stats, 0, sizeof(*ops->stats)); + if (!ops->len && !ops->ooblen) + return 0; + if (mtd->flags & MTD_SLC_ON_MLC_EMULATION) ret_code = mtd_io_emulated_slc(mtd, from, true, ops); else @@ -1849,6 +1852,9 @@ int mtd_write_oob(struct mtd_info *mtd, loff_t to, if (!master->_write_oob && (!master->_write || ops->oobbuf)) return -EOPNOTSUPP; + if (!ops->len && !ops->ooblen) + return 0; + if (mtd->flags & MTD_SLC_ON_MLC_EMULATION) return mtd_io_emulated_slc(mtd, to, false, ops); --- base-commit: 760d2efe91a84363d25c1051a10572242e75fe86 base-tree: git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes change-id: 20261104-submit-mtd-empty-io-v1-6a06db864131 Best regards, -- James Hilliard