From: James Hilliard <james.hilliard1@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
James Hilliard <james.hilliard1@gmail.com>
Subject: [PATCH v2] mtd: rawnand: propagate non-ECC errors when reading the BBT
Date: Wed, 18 Nov 2026 10:51:15 -0700 [thread overview]
Message-ID: <20261118-submit-rawnand-bbt-read-error-v1-v2-1-1a3f5d121c5f@gmail.com> (raw)
When loading a bad block table from flash, check_create() invalidates a
copy on -EBADMSG and schedules a scrub on -EUCLEAN. It ignores other
read errors, so it can report success with an incomplete table in RAM.
Propagate those errors when reading either copy.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
Changes in v2:
- Explain how a failed BBT read differs from the ECC recovery cases.
- Link to v1: https://patch.msgid.link/20261103-submit-rawnand-bbt-read-error-v1-v1-1-2ff0abffaf2e@gmail.com
---
drivers/mtd/nand/raw/nand_bbt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mtd/nand/raw/nand_bbt.c b/drivers/mtd/nand/raw/nand_bbt.c
index 93f162805f31..f3a1fd31ca03 100644
--- a/drivers/mtd/nand/raw/nand_bbt.c
+++ b/drivers/mtd/nand/raw/nand_bbt.c
@@ -1024,6 +1024,8 @@ static int check_create(struct nand_chip *this, uint8_t *buf,
i--;
continue;
}
+ if (res < 0 && !mtd_is_bitflip(res))
+ return res;
}
/* If they weren't versioned, read both */
if (rd2) {
@@ -1035,6 +1037,8 @@ static int check_create(struct nand_chip *this, uint8_t *buf,
i--;
continue;
}
+ if (res2 < 0 && !mtd_is_bitflip(res2))
+ return res2;
}
/* Scrub the flash table(s)? */
---
base-commit: 292f737382d3913d0d9addf220b7170fedd7a04f
base-tree: git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
change-id: 20261103-submit-rawnand-bbt-read-error-v1-eacbdd1e7970
Best regards,
--
James Hilliard <james.hilliard1@gmail.com>
reply other threads:[~2026-11-18 17:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118-submit-rawnand-bbt-read-error-v1-v2-1-1a3f5d121c5f@gmail.com \
--to=james.hilliard1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®