From: Olivier Moysan <olivier.moysan@foss.st.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Philipp Stanner" <phasta@kernel.org>,
"Arnaud Pouliquen" <arnaud.pouliquen@foss.st.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<linaro-mm-sig@lists.linaro.org>, <linux-sound@vger.kernel.org>,
"Olivier Moysan" <olivier.moysan@foss.st.com>
Subject: [PATCH v2 04/11] iio: adc: stm32-mdf: add serial interfaces support
Date: Wed, 18 Nov 2026 16:17:49 +0100 [thread overview]
Message-ID: <20261118-upstream_mdf_v2-v2-4-7939d3c3720a@foss.st.com> (raw)
In-Reply-To: <20261118-upstream_mdf_v2-v2-0-7939d3c3720a@foss.st.com>
The MDF serial interfaces receive the bitstreams from external sigma delta
modulators supporting SPI and Manchester protocols.
Select an external serial clock or an MDF CCK output, validate the clock
requirements of each mode and program the serial interface.
Expose reference-counted start and stop helpers so that multiple filters
can share an interface.
Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
---
drivers/iio/adc/Makefile | 2 +-
drivers/iio/adc/stm32-mdf-core.c | 34 +++++-
drivers/iio/adc/stm32-mdf-serial.c | 223 +++++++++++++++++++++++++++++++++++++
drivers/iio/adc/stm32-mdf.h | 49 ++++++++
4 files changed, 306 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile
index d5fc809c33ca..811ef85a88fb 100644
--- a/drivers/iio/adc/Makefile
+++ b/drivers/iio/adc/Makefile
@@ -147,7 +147,7 @@ obj-$(CONFIG_STM32_ADC) += stm32-adc.o
obj-$(CONFIG_STM32_DFSDM_ADC) += stm32-dfsdm-adc.o
obj-$(CONFIG_STM32_DFSDM_CORE) += stm32-dfsdm-core.o
obj-$(CONFIG_STM32_MDF_CORE) += stm32-mdf.o
-stm32-mdf-y := stm32-mdf-core.o
+stm32-mdf-y := stm32-mdf-core.o stm32-mdf-serial.o
obj-$(CONFIG_STMPE_ADC) += stmpe-adc.o
obj-$(CONFIG_SUN20I_GPADC) += sun20i-gpadc-iio.o
obj-$(CONFIG_SUN4I_GPADC) += sun4i-gpadc-iio.o
diff --git a/drivers/iio/adc/stm32-mdf-core.c b/drivers/iio/adc/stm32-mdf-core.c
index 4e462c6c42bc..5b5d2d4cbb5c 100644
--- a/drivers/iio/adc/stm32-mdf-core.c
+++ b/drivers/iio/adc/stm32-mdf-core.c
@@ -748,8 +748,13 @@ static int stm32_mdf_core_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
+ INIT_LIST_HEAD(&priv->mdf.sitf_list);
INIT_LIST_HEAD(&priv->mdf.filter_list);
+ ret = stm32_mdf_sitf_init(&pdev->dev, &priv->mdf);
+ if (ret)
+ return ret;
+
platform_set_drvdata(pdev, priv);
pm_runtime_get_noresume(&pdev->dev);
@@ -785,8 +790,15 @@ static int stm32_mdf_core_suspend(struct device *dev)
{
struct stm32_mdf *mdf = dev_get_drvdata(dev);
struct stm32_mdf_priv *priv = to_stm32_mdf_priv(mdf);
+ struct stm32_mdf_sitf *sitf;
int ret;
+ list_for_each_entry(sitf, &mdf->sitf_list, entry) {
+ ret = regmap_read(sitf->regmap, MDF_SITFCR_REG, &sitf->sitfcr);
+ if (ret)
+ return ret;
+ }
+
ret = pm_runtime_force_suspend(dev);
if (ret)
return ret;
@@ -794,7 +806,9 @@ static int stm32_mdf_core_suspend(struct device *dev)
regcache_cache_only(priv->regmap, true);
regcache_mark_dirty(priv->regmap);
- /* Balance regmap_mmio_attach_clk() clk_prepare() */
+ /* Balance regmap_mmio_attach_clk() for the SITFs and the core. */
+ list_for_each_entry(sitf, &mdf->sitf_list, entry)
+ clk_unprepare(priv->kclk);
clk_unprepare(priv->kclk);
return pinctrl_pm_select_sleep_state(dev);
@@ -804,6 +818,8 @@ static int stm32_mdf_core_resume(struct device *dev)
{
struct stm32_mdf *mdf = dev_get_drvdata(dev);
struct stm32_mdf_priv *priv = to_stm32_mdf_priv(mdf);
+ struct stm32_mdf_sitf *sitf;
+ unsigned int prepared = 0;
int ret;
ret = pinctrl_pm_select_default_state(dev);
@@ -825,8 +841,24 @@ static int stm32_mdf_core_resume(struct device *dev)
goto err_cache;
}
+ list_for_each_entry(sitf, &mdf->sitf_list, entry) {
+ ret = clk_prepare(priv->kclk);
+ if (ret)
+ goto err_sitf;
+ prepared++;
+
+ ret = regmap_write(sitf->regmap, MDF_SITFCR_REG, sitf->sitfcr);
+ if (ret)
+ goto err_sitf;
+ }
+
return pm_runtime_force_resume(dev);
+err_sitf:
+ while (prepared) {
+ clk_unprepare(priv->kclk);
+ prepared--;
+ }
err_cache:
clk_unprepare(priv->kclk);
err_clk:
diff --git a/drivers/iio/adc/stm32-mdf-serial.c b/drivers/iio/adc/stm32-mdf-serial.c
new file mode 100644
index 000000000000..6ba3be019847
--- /dev/null
+++ b/drivers/iio/adc/stm32-mdf-serial.c
@@ -0,0 +1,223 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * This file is part of STM32 MDF driver
+ *
+ * Copyright (C) 2023-2026, STMicroelectronics - All Rights Reserved
+ */
+
+#include <linux/cleanup.h>
+#include <linux/clk.h>
+#include <linux/clk/clk-conf.h>
+#include <linux/clk-provider.h>
+#include <linux/device.h>
+#include <linux/export.h>
+#include <linux/list.h>
+#include <linux/of.h>
+#include <linux/regmap.h>
+#include <linux/slab.h>
+#include <linux/spinlock.h>
+#include <linux/string.h>
+
+#include "stm32-mdf.h"
+
+enum {
+ STM32_MDF_SCKSRC_CCK0,
+ STM32_MDF_SCKSRC_CCK1,
+ STM32_MDF_SCKSRC_CLK,
+ STM32_MDF_SCKSRC_NONE,
+};
+
+static const char * const stm32_mdf_sitf_modes[] = {
+ [STM32_MDF_MODE_SPI] = "spi",
+ [STM32_MDF_MODE_LF_SPI] = "lf_spi",
+ [STM32_MDF_MODE_MANCHESTER_R] = "manchester_r",
+ [STM32_MDF_MODE_MANCHESTER_F] = "manchester_f",
+};
+
+static const struct regmap_config stm32_sitf_regmap_cfg = {
+ .reg_bits = 32,
+ .val_bits = 32,
+ .reg_stride = sizeof(u32),
+ .max_register = MDF_SITFCR_REG,
+ .fast_io = true,
+ /* Do not use regcache as it does not support single register map */
+};
+
+/**
+ * stm32_mdf_sitf_start() - Enable an MDF serial interface
+ * @sitf: Serial interface to enable
+ *
+ * Enable the serial interface and increment its active-user count on success.
+ * Each successful call must be balanced by stm32_mdf_sitf_stop().
+ *
+ * Return: 0 on success, or a negative error code on failure.
+ */
+int stm32_mdf_sitf_start(struct stm32_mdf_sitf *sitf)
+{
+ int ret;
+
+ guard(spinlock)(&sitf->lock);
+
+ ret = regmap_set_bits(sitf->regmap, MDF_SITFCR_REG, MDF_SITFCR_SITFEN);
+ if (!ret)
+ sitf->refcnt++;
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(stm32_mdf_sitf_start);
+
+/**
+ * stm32_mdf_sitf_stop() - Release an MDF serial interface user
+ * @sitf: Serial interface to release
+ *
+ * Decrement the active-user count and disable the serial interface when the
+ * last user releases it.
+ *
+ * Return: 0 on success, -EPERM if there are no active users, or a negative
+ * error code if disabling the interface fails.
+ */
+int stm32_mdf_sitf_stop(struct stm32_mdf_sitf *sitf)
+{
+ int ret = 0;
+
+ guard(spinlock)(&sitf->lock);
+
+ if (!sitf->refcnt) {
+ dev_err(sitf->dev, "Unbalanced serial interface stop ?\n");
+ return -EPERM;
+ }
+
+ sitf->refcnt--;
+
+ if (!sitf->refcnt)
+ ret = regmap_clear_bits(sitf->regmap, MDF_SITFCR_REG, MDF_SITFCR_SITFEN);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(stm32_mdf_sitf_stop);
+
+static int stm32_mdf_sitf_get_clk(struct device *dev, struct device_node *np,
+ struct stm32_mdf_sitf *sitf)
+{
+ struct clk *sck;
+ int ret;
+
+ /* SITF nodes have no device to apply their assigned clock configuration. */
+ ret = of_clk_set_defaults(np, false);
+ if (ret)
+ return dev_err_probe(dev, ret, "Can't configure serial clock for %pOF\n", np);
+
+ sitf->scksrc = STM32_MDF_SCKSRC_NONE;
+ /* Optional clock. Clock not needed in Manchester mode. */
+ if (!of_property_present(np, "clocks"))
+ return 0;
+
+ sck = devm_get_clk_from_child(dev, np, NULL);
+ if (IS_ERR(sck))
+ return dev_err_probe(dev, PTR_ERR(sck), "Can't get serial clock for %pOF\n", np);
+
+ sitf->sck = sck;
+ if (!strncmp(__clk_get_name(sck), STM32_MDF_CCK0, sizeof(STM32_MDF_CCK0)))
+ sitf->scksrc = STM32_MDF_SCKSRC_CCK0;
+ else if (!strncmp(__clk_get_name(sck), STM32_MDF_CCK1, sizeof(STM32_MDF_CCK1)))
+ sitf->scksrc = STM32_MDF_SCKSRC_CCK1;
+ else
+ sitf->scksrc = STM32_MDF_SCKSRC_CLK;
+
+ return 0;
+}
+
+static int stm32_mdf_sitf_parse(struct device *dev, struct device_node *np,
+ struct stm32_mdf_sitf *sitf)
+{
+ const char *str;
+ int ret, mode;
+ u32 idx, sitfcr;
+
+ ret = of_property_read_u32(np, "reg", &idx);
+ if (ret)
+ return dev_err_probe(dev, ret, "Could not get interface index for %pOF\n", np);
+
+ if (idx % 0x80) {
+ dev_err(dev, "Unexpected reg property value [%x]\n", idx);
+ return -EINVAL;
+ }
+
+ idx = (idx >> 7) - 1;
+ if (idx > sitf->mdf->nbf) {
+ dev_err(dev, "Interface index [%d] exceeds maximum [%d]\n", idx, sitf->mdf->nbf);
+ return -EINVAL;
+ }
+
+ ret = of_property_read_string(np, "st,sitf-mode", &str);
+ if (ret)
+ return dev_err_probe(dev, ret, "Could not get interface mode for %pOF\n", np);
+
+ mode = match_string(stm32_mdf_sitf_modes, ARRAY_SIZE(stm32_mdf_sitf_modes), str);
+ if (mode < 0) {
+ dev_err(dev, "Unknown serial interface mode [%s]\n", str);
+ return mode;
+ }
+
+ sitf->mode = mode;
+ sitfcr = FIELD_PREP(MDF_SITFCR_SITFMOD_MASK, mode);
+
+ ret = stm32_mdf_sitf_get_clk(dev, np, sitf);
+ if (ret)
+ return ret;
+
+ if (mode == STM32_MDF_MODE_SPI && sitf->scksrc == STM32_MDF_SCKSRC_NONE) {
+ dev_err(dev, "Missing clock for serial interface [%d] in SPI mode\n", idx);
+ return -EINVAL;
+ }
+
+ if (mode == STM32_MDF_MODE_LF_SPI && (sitf->scksrc != STM32_MDF_SCKSRC_CCK0 &&
+ sitf->scksrc != STM32_MDF_SCKSRC_CCK1)) {
+ dev_err(dev, "Missing CCKx clock for serial interface [%d] in LF_SPI mode\n", idx);
+ return -EINVAL;
+ }
+
+ sitf->id = idx;
+ sitf->node = of_fwnode_handle(np);
+ spin_lock_init(&sitf->lock);
+
+ sitfcr |= FIELD_PREP(MDF_SITFCR_SCKSRC_MASK, sitf->scksrc);
+
+ return regmap_set_bits(sitf->regmap, MDF_SITFCR_REG, sitfcr);
+}
+
+int stm32_mdf_sitf_init(struct device *dev, struct stm32_mdf *mdf)
+{
+ struct stm32_mdf_sitf *sitf;
+ void __iomem *base;
+ int ret;
+
+ for_each_available_child_of_node_scoped(dev->of_node, child) {
+ if (!of_node_name_eq(child, "sitf"))
+ continue;
+
+ sitf = devm_kzalloc(dev, sizeof(*sitf), GFP_KERNEL);
+ if (!sitf)
+ return -ENOMEM;
+ sitf->dev = dev;
+ sitf->mdf = mdf;
+
+ base = devm_of_iomap(dev, child, 0, NULL);
+ if (IS_ERR(base))
+ return PTR_ERR(base);
+
+ sitf->regmap = stm32_mdf_regmap_init(dev, mdf->kclk, base,
+ &stm32_sitf_regmap_cfg);
+ if (IS_ERR(sitf->regmap))
+ return dev_err_probe(dev, PTR_ERR(sitf->regmap),
+ "Failed to init SITF regmap\n");
+
+ ret = stm32_mdf_sitf_parse(dev, child, sitf);
+ if (ret)
+ return ret;
+
+ list_add(&sitf->entry, &mdf->sitf_list);
+ }
+
+ return 0;
+}
diff --git a/drivers/iio/adc/stm32-mdf.h b/drivers/iio/adc/stm32-mdf.h
index e3617b181e28..fa689954d7c1 100644
--- a/drivers/iio/adc/stm32-mdf.h
+++ b/drivers/iio/adc/stm32-mdf.h
@@ -19,6 +19,9 @@
#define MDF_IPIDR_REG 0xff8
#define MDF_SIDR_REG 0xffc
+/* Registers offsets relative to sitf base address */
+#define MDF_SITFCR_REG 0x00 /* 0x80 * x + offset */
+
/* Registers offsets relative to filter base address */
#define MDF_BSMXCR_REG 0x00 /* 0x84 * x + offset */
#define MDF_DFLTCR_REG 0x04
@@ -177,8 +180,49 @@
#define STM32_MDF_CCK0 "clk_cck0"
#define STM32_MDF_CCK1 "clk_cck1"
+enum stm32_sitf_mode {
+ STM32_MDF_MODE_LF_SPI,
+ STM32_MDF_MODE_SPI,
+ STM32_MDF_MODE_MANCHESTER_R,
+ STM32_MDF_MODE_MANCHESTER_F,
+ STM32_MDF_MODE_NB,
+};
+
+/*
+ * struct stm32_mdf_sitf - STM32 MDF serial interface data
+ * @entry: serial interface list head
+ * @dev: pointer to parent device
+ * @regmap: regmap for register read/write
+ * @mdf: mdf common data pointer
+ * @node: serial interface node handle
+ * @sck: sitf clock handle
+ * @base: sitf registers base cpu addr
+ * @lock: sitf state manegement lock
+ * @refcnt: sitf usage reference counter
+ * @scksrc: sitf clock source
+ * @id: serial interface index
+ * @mode: sitf mode
+ * @sitfcr: sitf configuration register backup
+ */
+struct stm32_mdf_sitf {
+ struct list_head entry;
+ struct device *dev;
+ struct regmap *regmap;
+ struct stm32_mdf *mdf;
+ struct fwnode_handle *node;
+ struct clk *sck;
+ void __iomem *base;
+ spinlock_t lock; /* Manage race conditions on sitf state */
+ unsigned int refcnt;
+ unsigned int scksrc;
+ u32 id;
+ u32 mode;
+ u32 sitfcr;
+};
+
/*
* struct stm32_mdf - STM32 MDF driver common data (for all instances)
+ * @sitf_list: pointer to serial interfaces list
* @filter_list: pointer to filter interfaces list
* @kclk: kernel clock shared by the core and its children
* @fproc: processing clock frequency
@@ -186,6 +230,7 @@
* @nb_interleave: number of interleaved filters
*/
struct stm32_mdf {
+ struct list_head sitf_list;
struct list_head filter_list;
struct clk *kclk;
unsigned long fproc;
@@ -224,3 +269,7 @@ int stm32_mdf_core_lock_kclk_rate(struct stm32_mdf *mdf);
void stm32_mdf_core_unlock_kclk_rate(struct stm32_mdf *mdf);
unsigned long stm32_mdf_core_get_cck(struct stm32_mdf *mdf);
+int stm32_mdf_sitf_init(struct device *dev, struct stm32_mdf *mdf);
+int stm32_mdf_sitf_start(struct stm32_mdf_sitf *sitf);
+int stm32_mdf_sitf_stop(struct stm32_mdf_sitf *sitf);
+
--
2.43.0
next prev parent reply other threads:[~2026-11-18 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:17 [PATCH v2 00/11] iio: adc: stm32: add mdf support for stm32mp2 Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 01/11] dt-bindings: iio: adc: add stm32mp2 mdf filter Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 02/11] iio: adc: stm32-mdf: add core registration Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 03/11] iio: adc: stm32-mdf: add cck clocks provider Olivier Moysan
2026-11-18 15:17 ` Olivier Moysan [this message]
2026-11-18 15:17 ` [PATCH v2 05/11] iio: adc: stm32-mdf: add digital filter device support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 06/11] iio: adc: stm32-mdf: configure cic filters and sample rates Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 07/11] iio: adc: stm32-mdf: add direct iio conversion support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 08/11] iio: adc: stm32-mdf: add dma buffered acquisition support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 09/11] iio: adc: stm32-mdf: add external timer trigger support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 10/11] iio: adc: stm32-mdf: add dmic audio filter support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 11/11] ASoC: stm32: add mdf dai support Olivier Moysan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118-upstream_mdf_v2-v2-4-7939d3c3720a@foss.st.com \
--to=olivier.moysan@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andy@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=broonie@kernel.org \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nuno.sa@analog.com \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=phasta@kernel.org \
--cc=robh@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®