From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=202.12.124.144 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794953188; b=fQJrB8qWWFzdeKSubkc0AL31UT6YuEwBb1L9q6hi2knbDgmAHqJJ+AfKKnWnHi/qe8PU jlm3phR6oPzxX1Wh0LBPM+ElH3+t31a4G+0Iizprw9N4h6ANvXsjuAgD+TGdr67o6/yWm tSUwbOKKRG7L+07Xtum7g5UAsPcyjj1r3mfhmuJcrXeCzQXyrbTpm2OyAVT6bCLVMs7ew 4s0AqO7DeU440ytSwQsFME+lCjwdoBfhUX8bx7sOLXmAkph2m1hlQQg67EH2qbi3GSw17 9Edy9xh40kb/fAyXIVU8K3m83UTMNo11f8YN/gzHrbcIX+hcBpfTIf3VT2vGv1jmnmw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794953188; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:Date:Message-Id:To:Cc:Subject:From:In-Reply-To:References: Mime-Version:Content-Type:Content-Transfer-Encoding; bh=ygy/EyAf0W1UdMvHNYbKmsjNOyLB/rxm+C1CVbXru9s=; b=B6fZJhde2LMRWm9q/smilDRj6egThu81eKWHUZXeelUNpAPNURS9DrhtGCK52FW0MAbQ FdiyJ2ApuIjA4CEutObWcQTy0yvAg1RWaOtjO/sNlLu4mtSqAJPUp2nC9yEkv8ECGkmkY ctX+ZZEtEvLN+m/8S3avjd/Kp59uRF9E6DeHGTUVQRdaOI6IS9B7BBKeRJ2gU37TZcTAU gAe1/NDvKKSYzekIYMSxyBEYr+akmlEALc5ScYzuoEV8+USEQQ4pu6gWmIF97fGTUthJL C9BBcPnSao9cywHKGn8oiiMiD7n3Jzlo2M3jGufvI+IE0pOBgx82Te6+awsbs/Dkvaw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=flapping.org; spf=pass smtp.mailfrom=flapping.org; dkim=pass header.d=flapping.org header.i=@flapping.org header.a=rsa-sha256 header.s=fm2 header.b=G121a1Y8; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=txFulTox; arc=none smtp.remote-ip=202.12.124.144 Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F657606A32F for ; Tue, 17 Nov 2026 22:06:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3F657606A32F Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=flapping.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flapping.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=flapping.org header.i=@flapping.org header.a=rsa-sha256 header.s=fm2 header.b=G121a1Y8; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=txFulTox Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 1305D1D0028A for ; Tue, 17 Nov 2026 17:06:26 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Tue, 17 Nov 2026 17:06:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flapping.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1794953183; x=1795039583; bh=ygy/EyAf0W1UdMvHNYbKmsjNOyLB/rxm+C1CVbXru9s=; b= G121a1Y8/0uM3w0nEs29wkoTvNSuBQjZFUcJtTed1QGRd6HfUczndaSd2v6CN36y r3EyXPB4QUtN2Hhji0V8u0U2vzZ29c52jPL5Q2pHopgVerUjIlMyl3fRMmnwSRH3 vBZ4No2gqcqfeJiLq5yxP0BwQt0gXVBNwfjbCC47Itz6Exafv4h8FwiztDIcgMzY ldPpCWbnlbh73c8mXGsuULhN56fnS2kLyFmfgYCk/dD0Y6s4S17TZ688vmZC9bWr OSY6wNoGaIzUsh2xNZoQ0n9y10+6OQFpT9IHMNDXtyz1l+7CSS6mGKhckALMO2TG oYQMOAahKUH2H4kltfBLWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1794953183; x= 1795039583; bh=ygy/EyAf0W1UdMvHNYbKmsjNOyLB/rxm+C1CVbXru9s=; b=t xFulToxWD8Kyjcwpp2qtvywA+dmST6mYl+62/TNKbnJZkPa9foilulG3G1nTYiHA xOoywPO2XcTHZony7D4f0w57CnAG3kAhuetgSKENGNn+oq0q0WTbsPKCQuXqqRhG 5ccsx8kHwztr33mXHHGrOo7MeJ3LLwO7unAE1lnRqgCTkie2K6f0te+OdvVHwNx0 TcGMBXam+CZ6QbgStQif0LFf58xPNSH6kYAqDArte7PIqqqJWEcpKZ/WwMfBazp8 854MF7CDdyyCwUffmRe/nkCMnmW1my54cJNR/TUSpAcEn0Lo2fKiqVKf5hANKu2A Zmw+1YkVFIHAnPo06TfdA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=flapping.org a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794953183; d=flapping.org; mf=PHRvbW9AZmxhcHBpbmcub3JnPg==; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm2:rsa-sha256:ryRAFFfUAuvQUqNB3iHYv0grq64abWtTlBT/sixd2wGyjaC fyN1LrFwKeezUbkehIy99PIjDAztzK4PmSPJYFsyk6c0+tf3K2sDTZYj4oPPhHqT IXVHS0Xfn0348O0SPJxToCNuqvSsAx8GdZZSew7w7tQuDMEvoK13fcWwEgunjzZ9 P/QmHCEDYycRtbu41T7UyapqNFVzsAar2SYHiIdYuvfpKAhMvOYSwXtCtXyMaB2t CFanXxSwnfDVS+cVC8Y4c4wAmo3xHxi5FZrkIsN2EWEqH9i07kXdPCGGgb9H2vXZ 0r7nBrN0gp5Lv/FEEm/iYmi4kOY4fV7MIaxJKog==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:2Tb1pSwErTgeSPF9fdAxkhBNeg7qsCKbQa3UnyjpHKE=:eqdSGfVVdOx4CGbTW//ANSk5CtWV6ls4JphNeLvrvl4=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFL5mZp+mTX6WVoBC0YPiYwbLINyUT1n441b0vqnathugDg1rVMsVsRRzhLkJP+57 Ot0TXwORG1TM2AEh2E44VOxlhrRYLZXrkB1XYc+Mx91FeQUaaLUlbgggrAAKe2QWdw1m/9 sasBo/8b5PW3pVQYk9Oaljvf+ZOEwy9gqQW5V1jVhk+YhV2a4GFTWaMjWPyZsyYb6XoqMr U+6jWvK6G4YiY3q/1oY8qVkRj7F5b1ddWNdG6qJylKGDhEbNkvFdZx5VFKeJ90dCes2Djk ZPg5LOD9aZU2ECwndj9YfIYwYk98iuha5s8ftVBnsftMMFpZ2BIqmVuPjf+95Pr5/U4xa/ k7Uv6lLFs/U3yo9FA5h2bQCMznOuwfF0kSsH7Tb+ddw7sqkMSr+dFqsA6oYLIL0U/oXGkr piCfhH6m4SloU7DQGh/8Rc/mUeT36cA86i6coKhMpM+1lDMc6bw0uA9QNz0GTE/lg+Se9M y+lurogFT6UmutAM41KCA9EbqbgUNsh2QNfOLLPpoV/UU+ImPaMehzfSdUeXC8rHUgFbOm xd2leKeNTCSx/fXOx0FG/oj3WtlUwcOPrS9vy7W2n71+0SfHun0UnMXTVT9snogQxX2Ltx Iylcek7f/qD0lM7rR5CjCdBSni9twAnWZix1mUt/r7h2NRa5w1VHcIiY5EhA X-ME-Proxy: Feedback-ID: i51fe4b43:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Nov 2026 17:06:18 -0500 (EST) Date: Wed, 18 Nov 2026 07:06:13 +0900 (JST) Message-Id: <20261118.070613.2130514405871522599.tomo@flapping.org> To: aliceryhl@google.com Cc: dakr@kernel.org, boqun@kernel.org, gary@garyguo.net, lyude@redhat.com, daniel.almeida@collabora.com, work@onurozkan.dev, ojeda@kernel.org, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, tmgross@umich.edu, tamird@kernel.org, acourbot@nvidia.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v3 4/5] rust: sync: condvar: use task::schedule_timeout() From: FUJITA Tomonori In-Reply-To: <20261117141652.2992350-1-aliceryhl@google.com> References: <20261117001507.1611984-1-dakr@kernel.org> <20261117001507.1611984-5-dakr@kernel.org> <20261117141652.2992350-1-aliceryhl@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit On Tue, 17 Nov 2026 14:16:52 +0000 Alice Ryhl wrote: > On Tue, Nov 17, 2026 at 01:14:45AM +0100, Danilo Krummrich wrote: >> @@ -122,7 +121,11 @@ fn wait_internal( >> /// [`CondVar::notify_one`] or [`CondVar::notify_all`]. Note that it may also wake up >> /// spuriously. >> pub fn wait(&self, guard: &mut Guard<'_, T, B>) { >> - self.wait_internal(TASK_UNINTERRUPTIBLE, guard, MAX_SCHEDULE_TIMEOUT); >> + self.wait_internal( >> + TASK_UNINTERRUPTIBLE, >> + guard, >> + Delta::from_jiffies(task::MAX_SCHEDULE_TIMEOUT), >> + ); >> } > > Now that `CondVar` uses `task::schedule_timeout()`, all remaining uses of > `task::MAX_SCHEDULE_TIMEOUT` wrap it in `Delta::from_jiffies(...)`, so we > could also change `MAX_SCHEDULE_TIMEOUT` itself to `Delta` (either > if you spin a v4 or as a follow-up). Either way: > > Reviewed-by: Alice Ryhl serdev users need this value too. I was going to add Delta::::MAX for it, but this looks better.