mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tim Douglas <me@timdoug.com>
To: mkp@kernel.org, James.Bottomley@HansenPartnership.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] scsi: esp_scsi: report the residual byte count
Date: Tue, 17 Nov 2026 19:37:46 -0500	[thread overview]
Message-ID: <20261118003746.61659-1-me@timdoug.com> (raw)

The ESP core tracks the number of bytes left to transfer in tot_residue
but does not report that count to the SCSI midlayer. As a result, SG_IO
returns a residual of zero even when a target transfers fewer bytes than
requested, as can happen with INQUIRY and MODE SENSE.

Report tot_residue with scsi_set_resid() when a command with a data
buffer completes with DID_OK. Initialize the scatterlist DMA length
on the identity-mapped PIO/pseudo-DMA path so the residual starts
from the buffer length on architectures with a separate DMA length.

On a Performa 6200CD with an out-of-tree ESP front end, an SG_IO
INQUIRY with an allocation length of 255 returns 36 bytes from the
internal CD-ROM drive. The residual is 219 with the fix and 0 before it.

AI assistance was used to investigate ESP transfer accounting and draft
the fix.

Signed-off-by: Tim Douglas <me@timdoug.com>
---
 drivers/scsi/esp_scsi.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index 9993b0ae9..162f8fe14 100644
--- a/drivers/scsi/esp_scsi.c
+++ b/drivers/scsi/esp_scsi.c
@@ -388,6 +388,7 @@ static void esp_map_dma(struct esp *esp, struct scsi_cmnd *cmd)
 
 		scsi_for_each_sg(cmd, s, spriv->num_sg, i) {
 			s->dma_address = (uintptr_t)sg_virt(s);
+			sg_dma_len(s) = s->length;
 			total += sg_dma_len(s);
 		}
 	} else {
@@ -907,8 +908,11 @@ static void esp_cmd_is_done(struct esp *esp, struct esp_cmd_entry *ent,
 	esp_free_lun_tag(ent, dev->hostdata);
 	cmd->result = 0;
 	set_host_byte(cmd, host_byte);
-	if (host_byte == DID_OK)
+	if (host_byte == DID_OK) {
 		set_status_byte(cmd, ent->status);
+		if (cmd->sc_data_direction != DMA_NONE)
+			scsi_set_resid(cmd, ESP_CMD_PRIV(cmd)->tot_residue);
+	}
 
 	if (ent->eh_done) {
 		complete(ent->eh_done);

base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
-- 
2.39.5


                 reply	other threads:[~2026-11-18  0:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118003746.61659-1-me@timdoug.com \
    --to=me@timdoug.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkp@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®