From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.17 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794966742; b=doq6hsxO2TMMOo8DQgAKI/bTT8xa00rkIhNaIqaZo/eAMHVWDLgb4tZgHS6wUIXMlLTF S/neh5hdT48qYfYyU76s7dO0kjpC/Q6/InSu1Qu0KVEpPfhw5Wysnuhh/3CyeAI97sLd0 1bwGwLEXjx9e6RiL9rJLdHjFjj7+C+C8/l0LBsq2NYiqN/bhIOp8/yhXSfkbslxeRpm/R 1PHCTrB5DiiErSjaGLbNzZMDtOdGPbshbivWJ/2ILK1H9Sn8pdFS+QYRePgxzoDV3rkV/ xNXvcXP61ORsJcBgUbrbY9/FcitH0zrJLn4Y0BC6SkbiYwfLFl8A4sP82s17iGM9nNA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794966742; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:MIME-Version:Content-Transfer-Encoding; bh=yv5J3gvYonX/6FqSmk7sOMY4JB7byW72QtOkwWKI6Hs=; b=0Bl3/NYdC6lUq7vDsPlole79wK9PdSS5MK/kzsPHI3MkcRxVMo+i+HX/I+JOyHxW96AY StcJCUw/9SqfIWGR6FDeh7S+wI/Y1z0yxFYuLbEUSuxQNe4fvLoRkVzhN4N0TaP0xvVF4 vfmhUIJ25s1SlJdAym4E/xE+LReWdj/iY23370LxKKqssno7Njb44KtOUqthjI5Wn2383 vFawlbgb3Xg3fDdNtZFZyWUNsMph9ARe1xgsAjVssIzW/HikeIFo9DvD/ZaNLiOF/xShx 5s5lND3yp2wWVmst/KTwILrrR5dmRyZvlVhKXDNB77eHPm+nvrofJ/e4UhwN+JYx/LQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=GgCgaVpC; arc=none smtp.remote-ip=198.175.65.17 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 923F8606A31C for ; Wed, 18 Nov 2026 01:52:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 923F8606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=GgCgaVpC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794966742; x=1826502742; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=JzvAYy+mMgwCByAroYj9N8rDne/Z6sbblIq4Fe1MpRs=; b=GgCgaVpC8IFJbkd8qYEHQJJbBdx4ERZk00zupOrrH2ZeN9qOgpz0MnH1 tBAjnee40gFiA8bgRTzY3YxOAPuy9go0quHLxRs6QQOMASpaXev5x/MBH NhOY6XvnuHfz6HXbzfB+Knn6/kvo3CuX5dmV3TncLMjav7l5LjGisofiG 3/CPvaMmskLfZMHRpAo8tEIts3QgnXqKvUcYctB6c2LTI+BTzY+CHN5Ti A4k6Oj9rsQgqhsMT6LZL7reRn+Q2f9SksIqvTzzXTwJ79FDI0QZ5HMm5L wK8Cte6LRFfl6G/CR8/H9lmxlP5RTmh7q9nARW2z9zo1JFHulqx28oMse Q==; X-CSE-ConnectionGUID: qxzunt5rRlan7vCUJjeMcA== X-CSE-MsgGUID: 9vwfujWNQp2trQYC8e/i4A== X-IronPort-AV: E=McAfee;i="6800,10657,11969"; a="3777422" X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="3777422" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2026 17:52:21 -0800 X-CSE-ConnectionGUID: IHmTfrMeRRGkZVF1+ha2cg== X-CSE-MsgGUID: /vNDjvkrTpyMqpQemnh5+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="10172462" Received: from fred-panther-lake-client-platform.sh.intel.com ([10.239.144.227]) by fmviesa002.fm.intel.com with ESMTP; 17 Nov 2026 17:52:18 -0800 From: Fred Gao To: intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com, tursulin@ursulin.net, ville.syrjala@linux.intel.com, Fred Gao , Chenchen Wang Subject: [PATCH v2] drm/i915/panel: Restrict highest mode to DRRS-compatible modes Date: Wed, 18 Nov 2026 09:49:49 +0800 Message-ID: <20261118014949.399026-1-fred.gao@intel.com> X-Mailer: git-send-email 2.43.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit intel_dp_mode_clock() uses intel_panel_highest_mode() when seamless M/N updates are supported so the link configuration can accommodate every seamless DRRS refresh rate. The panel fixed mode list can also contain modes with the same active size but different blanking timings. Such modes require a full modeset and cannot participate in a seamless M/N switch. Letting them affect the highest clock can unnecessarily reduce the selected bpp. On a 5120x2160 panel, the preferred DisplayID mode uses 717260 kHz, while a CTA mode with different blanking uses 742500 kHz. HBR2 x4 can carry the preferred mode at 24 bpp, but not the CTA clock. The latter therefore makes the link configuration fall back to 18 bpp. The firmware state is 24 bpp, so the mismatch forces a full modeset and an eDP backlight and panel power cycle during driver takeover. Use is_alt_drrs_mode() to consider only fixed modes whose timings and flags match the adjusted mode. This preserves bandwidth reservation for genuine seamless DRRS alternatives while excluding modes that would require a full modeset. Fixes: 74d6f31fa427 ("drm/i915: Add intel_panel_highest_mode()") Signed-off-by: Fred Gao Reviewed-by: Chenchen Wang --- v2: - Resubmit as requested by the CI team to trigger a fresh CI run. No code changes. The previous IGT failures were caused by unrelated patches. drivers/gpu/drm/i915/display/intel_panel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c index 81e638d0c7b3..e82082adb4c0 100644 --- a/drivers/gpu/drm/i915/display/intel_panel.c +++ b/drivers/gpu/drm/i915/display/intel_panel.c @@ -192,7 +192,8 @@ intel_panel_highest_mode(struct intel_connector *connector, /* pick the fixed_mode that has the highest clock */ list_for_each_entry(fixed_mode, &connector->panel.fixed_modes, head) { - if (fixed_mode->clock > best_mode->clock) + if (is_alt_drrs_mode(fixed_mode, adjusted_mode) && + fixed_mode->clock > best_mode->clock) best_mode = fixed_mode; } -- 2.43.0