From: Jia Jia <physicalmtea@gmail.com>
To: "Martin K . Petersen" <mkp@kernel.org>,
Jan Engelhardt <jengelh@inai.de>, Hannes Reinecke <hare@suse.de>,
James Bottomley <James.Bottomley@suse.de>,
Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, Jia Jia <physicalmtea@gmail.com>
Subject: [PATCH v2 4/8] scsi: target: copy a DIF insert tuple across prot sgs
Date: Wed, 18 Nov 2026 12:13:07 +0800 [thread overview]
Message-ID: <20261118041311.19011-5-physicalmtea@gmail.com> (raw)
In-Reply-To: <20261118041311.19011-1-physicalmtea@gmail.com>
sbc_dif_generate() writes a complete eight-byte t10_pi_tuple whenever
any bytes remain in a protection sg. A tuple split across entries can
therefore be written past the end of the first entry.
Copy each tuple through a stack object, walking the protection sgs as
needed. Read the existing tuple before updating it to preserve ref_tag
for protection types other than Type 1. This also checks that the full
tuple is available before writing any of it.
Stop generation on a truncated final tuple without changing the
caller's completion status.
KASAN reports:
BUG: KASAN: use-after-free in sbc_dif_generate+0x20c/0x640 [target_core_mod]
Write of size 4
sbc_dif_generate
target_complete_ok_work
Fixes: 66a3d5bc47d2 ("target/sbc: Add sbc_dif_generate software emulation")
Signed-off-by: Jia Jia <physicalmtea@gmail.com>
---
drivers/target/target_core_sbc.c | 180 ++++++++++++++++++++++---------
1 file changed, 131 insertions(+), 49 deletions(-)
diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
index adef903652ac2..780f526c4d931 100644
--- a/drivers/target/target_core_sbc.c
+++ b/drivers/target/target_core_sbc.c
@@ -1250,72 +1250,154 @@ err:
return ret;
}
+/*
+ * Copy one 8 byte PI tuple to or from the prot sg. The data page sits
+ * above the prot map, so a prot sg change drops and restores it. A
+ * short tail releases both maps and returns false.
+ */
+static bool
+sbc_dif_prot_copy(struct scatterlist **psgp, void **paddrp,
+ unsigned int *poffp, struct scatterlist *dsg,
+ void **daddrp, void *buf, bool to_prot)
+{
+ struct scatterlist *psg = *psgp;
+ void *paddr = *paddrp;
+ void *daddr = *daddrp;
+ unsigned int poff = *poffp;
+ unsigned int len = sizeof(struct t10_pi_tuple);
+ u8 *p = buf;
+
+ while (len) {
+ unsigned int take;
+
+ if (!psg || poff >= psg->length) {
+ if (daddr)
+ kunmap_atomic(daddr - dsg->offset);
+ if (paddr)
+ kunmap_atomic(paddr - psg->offset);
+ daddr = NULL;
+ paddr = NULL;
+ psg = psg ? sg_next(psg) : NULL;
+ if (!psg) {
+ *psgp = NULL;
+ *paddrp = NULL;
+ *daddrp = NULL;
+ return false;
+ }
+ poff = 0;
+ if (!psg->length)
+ continue;
+ paddr = kmap_atomic(sg_page(psg)) + psg->offset;
+ daddr = kmap_atomic(sg_page(dsg)) + dsg->offset;
+ }
+
+ take = min_t(unsigned int, len, psg->length - poff);
+ if (to_prot)
+ memcpy(paddr + poff, p, take);
+ else
+ memcpy(p, paddr + poff, take);
+ p += take;
+ poff += take;
+ len -= take;
+ }
+
+ *psgp = psg;
+ *paddrp = paddr;
+ *poffp = poff;
+ *daddrp = daddr;
+ return true;
+}
+
void
sbc_dif_generate(struct se_cmd *cmd)
{
struct se_device *dev = cmd->se_dev;
- struct t10_pi_tuple *sdt;
- struct scatterlist *dsg = cmd->t_data_sg, *psg;
+ struct scatterlist *dsg = cmd->t_data_sg;
+ struct scatterlist *psg = cmd->t_prot_sg;
sector_t sector = cmd->t_task_lba;
void *daddr, *paddr;
- int i, j, offset = 0;
+ unsigned int poff = 0;
+ int offset = 0;
unsigned int block_size = dev->dev_attrib.block_size;
- for_each_sg(cmd->t_prot_sg, psg, cmd->t_prot_nents, i) {
- paddr = kmap_atomic(sg_page(psg)) + psg->offset;
- daddr = kmap_atomic(sg_page(dsg)) + dsg->offset;
+ if (!psg || !dsg)
+ return;
- for (j = 0; j < psg->length;
- j += sizeof(*sdt)) {
- __u16 crc;
- unsigned int avail;
+ paddr = kmap_atomic(sg_page(psg)) + psg->offset;
+ daddr = kmap_atomic(sg_page(dsg)) + dsg->offset;
- if (offset >= dsg->length) {
- offset -= dsg->length;
- kunmap_atomic(daddr - dsg->offset);
- dsg = sg_next(dsg);
- if (!dsg) {
- kunmap_atomic(paddr - psg->offset);
- return;
- }
- daddr = kmap_atomic(sg_page(dsg)) + dsg->offset;
- }
+ for (;;) {
+ struct t10_pi_tuple sdt;
+ struct scatterlist *mark_psg;
+ unsigned int mark_off;
+ __u16 crc;
+ unsigned int avail;
- sdt = paddr + j;
- avail = min(block_size, dsg->length - offset);
- crc = crc_t10dif(daddr + offset, avail);
- if (avail < block_size) {
- kunmap_atomic(daddr - dsg->offset);
- dsg = sg_next(dsg);
- if (!dsg) {
- kunmap_atomic(paddr - psg->offset);
- return;
- }
- daddr = kmap_atomic(sg_page(dsg)) + dsg->offset;
- offset = block_size - avail;
- crc = crc_t10dif_update(crc, daddr, offset);
- } else {
- offset += block_size;
- }
+ if (poff >= psg->length && !sg_next(psg))
+ break;
- sdt->guard_tag = cpu_to_be16(crc);
- if (cmd->prot_type == TARGET_DIF_TYPE1_PROT)
- sdt->ref_tag = cpu_to_be32(sector & 0xffffffff);
- sdt->app_tag = 0;
+ mark_psg = psg;
+ mark_off = poff;
+ if (!sbc_dif_prot_copy(&psg, &paddr, &poff, dsg, &daddr,
+ &sdt, false))
+ return;
+
+ if (offset >= dsg->length) {
+ offset -= dsg->length;
+ kunmap_atomic(daddr - dsg->offset);
+ dsg = sg_next(dsg);
+ if (!dsg) {
+ kunmap_atomic(paddr - psg->offset);
+ return;
+ }
+ daddr = kmap_atomic(sg_page(dsg)) + dsg->offset;
+ }
- pr_debug("DIF %s INSERT sector: %llu guard_tag: 0x%04x"
- " app_tag: 0x%04x ref_tag: %u\n",
- (cmd->data_direction == DMA_TO_DEVICE) ?
- "WRITE" : "READ", (unsigned long long)sector,
- sdt->guard_tag, sdt->app_tag,
- be32_to_cpu(sdt->ref_tag));
+ avail = min(block_size, dsg->length - offset);
+ crc = crc_t10dif(daddr + offset, avail);
+ if (avail < block_size) {
+ kunmap_atomic(daddr - dsg->offset);
+ dsg = sg_next(dsg);
+ if (!dsg) {
+ kunmap_atomic(paddr - psg->offset);
+ return;
+ }
+ daddr = kmap_atomic(sg_page(dsg)) + dsg->offset;
+ offset = block_size - avail;
+ crc = crc_t10dif_update(crc, daddr, offset);
+ } else {
+ offset += block_size;
+ }
- sector++;
+ sdt.guard_tag = cpu_to_be16(crc);
+ if (cmd->prot_type == TARGET_DIF_TYPE1_PROT)
+ sdt.ref_tag = cpu_to_be32(sector & 0xffffffff);
+ sdt.app_tag = 0;
+
+ pr_debug("DIF %s INSERT sector: %llu guard_tag: 0x%04x"
+ " app_tag: 0x%04x ref_tag: %u\n",
+ (cmd->data_direction == DMA_TO_DEVICE) ?
+ "WRITE" : "READ", (unsigned long long)sector,
+ sdt.guard_tag, sdt.app_tag,
+ be32_to_cpu(sdt.ref_tag));
+
+ if (psg != mark_psg) {
+ kunmap_atomic(daddr - dsg->offset);
+ kunmap_atomic(paddr - psg->offset);
+ psg = mark_psg;
+ paddr = kmap_atomic(sg_page(psg)) + psg->offset;
+ daddr = kmap_atomic(sg_page(dsg)) + dsg->offset;
}
+ poff = mark_off;
+ if (!sbc_dif_prot_copy(&psg, &paddr, &poff, dsg, &daddr,
+ &sdt, true))
+ return;
- kunmap_atomic(daddr - dsg->offset);
- kunmap_atomic(paddr - psg->offset);
+ sector++;
}
+
+ kunmap_atomic(daddr - dsg->offset);
+ kunmap_atomic(paddr - psg->offset);
}
static sense_reason_t
next prev parent reply other threads:[~2026-11-18 4:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 4:13 [PATCH v2 0/8] scsi: target: keep command bytes inside the sg Jia Jia
2026-11-18 4:13 ` [PATCH v2 1/8] scsi: target: take COMPARE AND WRITE data from the write half Jia Jia
2026-11-18 4:13 ` [PATCH v2 2/8] scsi: target: keep REPORT REFERRALS stores inside the buffer Jia Jia
2026-11-18 4:13 ` [PATCH v2 3/8] scsi: target: reject a short SET TARGET PORT GROUPS list Jia Jia
2026-11-18 4:13 ` Jia Jia [this message]
2026-11-18 4:13 ` [PATCH v2 5/8] scsi: target: copy a DIF verify tuple across prot sgs Jia Jia
2026-11-18 4:13 ` [PATCH v2 6/8] scsi: target: limit DIF block CRC to each data sg Jia Jia
2026-11-18 4:13 ` [PATCH v2 7/8] scsi: target: keep pscsi mode bytes inside the data sgs Jia Jia
2026-11-18 4:13 ` [PATCH v2 8/8] scsi: target: advance past escaped DIF blocks across " Jia Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118041311.19011-5-physicalmtea@gmail.com \
--to=physicalmtea@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=akinobu.mita@gmail.com \
--cc=hare@suse.de \
--cc=jengelh@inai.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®