From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.231.133 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794991104; b=MXWO00QgAF56bB8SUMy90YvFCKXy+Aitvy+RAzCjTShJmeMsktUuaoMRMFSN7x/nWJbm lrmugHaR1/xN0JaSFUODKbc2v0nlesQ5fzosNpTQpqa1puMjF9wx52KCU5tsTWU4lsk0a mrJrpNAxT2//Ve0r1m17nF4BcMWqheech7rbGmmFzGz0eYrqYLgkllOt7PpZ7Hr9CiOhO 11cerF256AfMbYJvO20s8U84fr45N22ueJfza8NQK965IEdcfZVoMB83kzRKYgp1CP4Et wEsL9gJlaDezBpAaExD6s4men5xib09wpu08cdHqBzj9CywAoODzl/RROl/DjWn/UQg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794991104; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=vMKeyOZcK3q18Yw2MNqKYKjsEME0sggs4rjvagocBak=; b=nEoNaf7B+6u7mgHrK9b0Yzqkp+RqQwQMUKO5Lcj/B8tZ9guVcx4fGW2w3BLdI8zw0rYj 35Jt6pZieFCFkOzv1GUabV1/85t2aRppdscrAZUE0qlMabmNhqoKI1tJdntMJx/BGWrBh 5kCKhI8nY1NxhlrNl3I62hvq6Dxo0VBP3cxvf16MJ6fPlAW4Kf3CDWCmGid2sgkuocPNk Iaj1osdM3MnDvDY5kYFkpFNHQXNVYilm4eoBmfy1uoudM/lc6hhMvErly3sK6cCAK5bzg oVaohgbXkcZrp5zOyiJqegTUOtRaTzpmCuVnwjI1hzg3445Bm4RkkohrV/muPx/u5jA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=FKI8d9MU; arc=none smtp.remote-ip=74.125.231.133 Received: from mail-oo2-f5.google.com (mail-oo2-f5.google.com [74.125.231.133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D902D606A31C for ; Wed, 18 Nov 2026 08:38:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D902D606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=FKI8d9MU Received: by mail-oo2-f5.google.com with SMTP id 46e09a7af769-862a05abb95so134664a34.1 for ; Wed, 18 Nov 2026 00:38:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794991103; x=1795595903; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=vMKeyOZcK3q18Yw2MNqKYKjsEME0sggs4rjvagocBak=; b=FKI8d9MUzkUbNdnN8QuOvsu6gjuzjotYn7+lzQJRBwIH+4t5OcEvcg8yr5xq1Mj18/ UEDlJg58pIl2ikt3lfgIJQN2Ut5ld4oFeBPcVfE2Ce9yNkrqlUYSr8Up1nSae2Ih7B9F zoLseKBDn0StWUum8symXoT/QHFacANkj6zGg/2OflNiYgk122D40RvVkC3g7Qwf9Io8 I4S0Ju/K3qvDJPva7j2ONjlLiB59Fr1LiY4CvImd1FMpMuHmijT0f1nbHbgXej0pWM39 tuQRjudolrUMfgiayZ7L3z6fPMxx71n6I6wCeUe/oPIUFIfOiBYboaZdRNz2LoR2UCqk WQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794991103; x=1795595903; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vMKeyOZcK3q18Yw2MNqKYKjsEME0sggs4rjvagocBak=; b=Q9n+PZN+1/7eo/JgEG/+xKPnnkBNvBhodz4XzfB9IBuo4xxf4MLXYnhPgU1z9WCr3S BmZvCLheUrwRYzFcFajiBeBUoM0vnf/NkCy26MyxzwR+sN/+dMikh0PIkHhilbKF542k 5XybP7PogPYUHFPByDlAUc4p/20xTNErfYlE7SAfsTEHizeW7mDh1p1+rFaPJ+ZtSGAI 2PGL4qCUgVFS6QHlOJ9A+Jt+KyAmFM7T9RdLwzKF5lvKx2giDT1UoWvyG5X/MoS7AWUi orAeBc3CWyqRKkQaZBGELEkWK/iZsoX69HqmDlvhMyNyWIpuDmwNdJJ1EbMOiAx+hr0N oEWQ== X-Forwarded-Encrypted: i=1; AL+hErE/1THu7JPXJ8zahAkyrlS0IBqRtw2k2B7vhy8nS4qigQF4Ka64Y8Ra6guiBFUGinYl4y46VYpqoAo131A=@vger.kernel.org X-Gm-Message-State: APuU4Z+hgx5sF8Jqa/Srz5ZcDCCwtTTfThQ24jGvmvMw8OHrwa1ACLkV w1NmUSg9gyvOtIrHOVgdRZPt44ATc9vuqWo5qj32woXgbp5JfAatIe3a X-Gm-Gg: AYBFou3pLxdYNt9WrD1iAclsFjxpP9RVYAsc5oeWvX7BWj5PmPVxaryfQMMvVPUxQdy 53cQx/f2YQ0Itl7gOE4CfgBhWIPYhO3dEzxoBubYRTc3D0Jj7gVobkpfhgd2DS/Y5/vajbRf0cy /K3OlTDnt5/iHrLwRgFfTac2IDXV8t97c8xpWKFNaMAJvSttXaYhoFx0861Ub5xfcK7zFVLHDeF P8Uq8v8ABSDGN4AmZpKrtb0Vv0XgxhSYFut3x4oyGgXWECrGp9g9QkI87EXsDRewi4cuX7M+iGs aDZIe0rgJ4MSgf6XDwxQYznVE+7X3AgFfoxzzP0Dq4VJqYe2jTr+eMLrOKHrJWODuQ/wkAbxFFw 2MqKuqVs5+1CzclM/wF3z308BggB6bhLAfwTTag6XZQf3KJ7RlA710XeX+lfxjTzOgbcfmRM6Wi CSz/NHZA4vPNuh0Iqyxl+4G7MIsOUTnrg2nHwBUPt9fRE3ElaMIxvDGVYUiiolbGY9qcBac1/QL 9C9qWxL+B2qNIbkxfKN6LGDroh8P7M+KTordSh5jOvXHF1v6Hd/gi24tuheV0Vv+I/oDXc06bn7 PNTzBveyvgzpogew3R1l/ldjmt9ztCa/Mj/utck73ZKnJbQWIzTlK8wbYwP1DB0KfRzNfEtbJkj ANVhq+eHlEGZQ X-Received: by 2002:a05:6820:a70a:20b0:713:da3b:9530 with SMTP id 006d021491bc7-71b187889e8mr789320eaf.44.1794991102733; Wed, 18 Nov 2026 00:38:22 -0800 (PST) Received: from localhost.localdomain ([14.22.11.165]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-71b1945800asm1516812eaf.5.2026.11.18.00.38.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 00:38:21 -0800 (PST) From: Henry Martin To: David Heidelberg , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: oe-linux-nfc@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Henry Martin , stable@vger.kernel.org Subject: [PATCH] nfc: llcp: walk the accept queue under the socket lock Date: Wed, 18 Nov 2026 16:38:11 +0800 Message-ID: <20261118083811.1721010-1-bsdhenrymartin@gmail.com> X-Mailer: git-send-email 2.43.7 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit llcp_accept_poll() walks parent->accept_queue and reads each child's sk_state without holding the socket lock. nfc_llcp_accept_dequeue() unlinks closed children and drops their creation reference under that lock, and the last sock_put() frees the child. A poll() racing with accept() therefore reads a freed child: BUG: KASAN: slab-use-after-free in llcp_sock_poll+0x440/0x4e0 Read of size 1 at addr ffff888112387812 by task poc.bin/528 Allocated by task 198: nfc_llcp_sock_alloc nfc_llcp_rx_skb Freed by task 529: __sk_destruct nfc_llcp_accept_dequeue Take the listener lock around the accept queue walk. This issue was discovered by Tencent CodeBuddy Security. Fixes: d646960f7986 ("NFC: Initial LLCP support") Cc: stable@vger.kernel.org Signed-off-by: Henry Martin --- net/nfc/llcp_sock.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c index 1e5ee4bcde68..3503f1a7a7cc 100644 --- a/net/nfc/llcp_sock.c +++ b/net/nfc/llcp_sock.c @@ -584,8 +584,16 @@ static __poll_t llcp_sock_poll(struct file *file, struct socket *sock, sock_poll_wait(file, sock, wait); - if (sk->sk_state == LLCP_LISTEN) - return llcp_accept_poll(sk); + if (sk->sk_state == LLCP_LISTEN) { + /* nfc_llcp_accept_dequeue() unlinks and frees closed children + * under the listener lock, so the queue can only be walked + * with that lock held. + */ + lock_sock(sk); + mask = llcp_accept_poll(sk); + release_sock(sk); + return mask; + } if (sk->sk_err || !skb_queue_empty_lockless(&sk->sk_error_queue)) mask |= EPOLLERR | -- 2.43.7