From: "Vítor Hugo Silva" <vitorhg20080@gmail.com>
To: linux@roeck-us.net
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
"Vítor Hugo Silva" <vitorhg20080@gmail.com>
Subject: [PATCH v2] hwmon: (ads7871) Add error handle from spi_setup()
Date: Wed, 18 Nov 2026 09:29:28 +0000 [thread overview]
Message-ID: <20261118092928.163553-1-vitorhg20080@gmail.com> (raw)
The ads7871 probe() ignores the spi_setup() error return value
and it attempts to write to registers even if spi_setup() fails.
Return the setup error before accessing any registers.
AI was used for peer-review the patch.
Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")
Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
---
Changes in v2:
- Clarify what happens when spi_setup() fails.
- Describe the fix in imperative mood.
drivers/hwmon/ads7871.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
index 36297bc6d047..a1ffc35d9272 100644
--- a/drivers/hwmon/ads7871.c
+++ b/drivers/hwmon/ads7871.c
@@ -187,7 +187,9 @@ static int ads7871_probe(struct spi_device *spi)
/* Configure the SPI bus */
spi->mode = (SPI_MODE_0);
spi->bits_per_word = 8;
- spi_setup(spi);
+ ret = spi_setup(spi);
+ if (ret)
+ return ret;
pdata = devm_kzalloc_obj(dev, *pdata);
if (!pdata)
--
2.56.1
reply other threads:[~2026-11-18 9:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118092928.163553-1-vitorhg20080@gmail.com \
--to=vitorhg20080@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®