From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: Sudeep Holla <sudeep.holla@kernel.org>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org,
linux-doc@vger.kernel.org, james.quinlan@broadcom.com,
f.fainelli@gmail.com, vincent.guittot@linaro.org,
etienne.carriere@st.com, peng.fan@oss.nxp.com,
michal.simek@amd.com, d-gole@ti.com, elif.topuz@arm.com,
lukasz.luba@arm.com, philip.radford@arm.com, david@kernel.org,
souvik.chakravarty@arm.com, leitao@kernel.org, kas@kernel.org,
puranjay@kernel.org, usama.arif@linux.dev, kernel-team@meta.com
Subject: Re: [PATCH v15 00/35] Introduce SCMI Telemetry support
Date: Wed, 18 Nov 2026 09:32:03 -0800 [thread overview]
Message-ID: <20261118093203.000069f1@oss.qualcomm.com> (raw)
In-Reply-To: <20261118-poetic-robust-raptor-bcff2b@sudeepholla>
On Wed, 18 Nov 2026 09:33:44 +0000
Sudeep Holla <sudeep.holla@kernel.org> wrote:
> On Tue, Nov 17, 2026 at 05:07:09PM -0800, Jonathan Cameron wrote:
> > On Mon, 9 Nov 2026 09:11:46 +0000
> > Cristian Marussi <cristian.marussi@arm.com> wrote:
> >
> > > Hi all,
> > >
> > > [TLDR Summary]
> > > [V15 highlights]
> > > - general cleanup and hardening driven by reviews
> > > - improved TDCF access routines to minimize lost samples under load
> > > - completed ABI docs
> > >
> > > [V16 TODO]
> > > - address any remaining V15 outstanding Sashiko/reviewers issues
> > >
> > > The upcoming SCMI v4.0 specification [0] introduces a new SCMI protocol
> > > dedicated to System Telemetry.
> >
> > This is one from the family of issues you find when reviewing ones own
> > (well LLM generated) emulation, realizing it doesn't match the spec,
> > and yet works.
> >
> > This works fine without the required SCMI protocol property in ACPI.
> > 2.2.2 of ACPI for System Control and Management Interface 1.0
> > Platform Design Document. 111115A 1.0
> >
> > Now, in here is an informative statement...
> >
> > Protocols not listed using a property may not be enumerate by the operating system.
> >
> > But they are...
> >
>
> Correct, I intentionally left that out. I do have a patch that restricts it
> strictly to the listed property. However, I held off on pushing it because of
> an issue we saw on an internal test platform.
>
> On that platform, the firmware advertised the protocol to the OSPM via the
> base protocol, even though it wasn't functional at all. Once they realized
> this, they simply dropped the entry from the ACPI SCMI device as a workaround
> instead of properly fixing the base protocol discovery. While understandable,
> relying on that workaround delays proper firmware fixes.
>
> That is why I went with the non-mandatory "may not be" wording. I am happy to
> merge that restriction patch if a real production platform actually needs it,
> but until then, leaving it open helps catch and fix broken firmware
> implementations 😄.
You can't merge it safely as at a later date because chances are high
someone is relying on the current behavior and not presenting that
(currently pointless) package in ACPI for some protocol or other.
I'm fine with a permanent decision not to check this but I don't see it
as a thing that can ever change (except maybe now whilst there are not
that many platforms out there using it!)
Jonathan
>
> > So, obviously we can ignore informative spec lines but that is a pretty strong
> > sentence. I can't immediately think of what would go wrong if we ignored it
> > - maybe we'd not pick an exclusive PCC and fallback to a common one the firmware
> > doesn't want us to use? But if it doesn't want us to use it why make Telemetry
> > discoverable on it.
> >
>
> Indeed, falling back to the common channel lets us uncover any underlying
> issues in the firmware implementation. That is the exact scenario we hit on
> the test platform, which convinced me to hold back the patch.
>
> > Should that be wired through from the ACPI parsing code?
> >
>
>
> As mentioned, we certainly can, though I'm not sure we should. The "may not
> be" phrasing simply leaves the choice up to the OSPM rather than mandating a
> strict restriction.
>
> > Anyhow, not something I care that much about but thought I'd call it out
> > as an oddity.
> >
>
> Thanks and well spotted. Much appreciated as it brought the information out
> which otherwise would have just got lost.
>
next prev parent reply other threads:[~2026-11-18 17:32 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 9:11 Cristian Marussi
2026-11-09 9:11 ` [PATCH v15 01/35] firmware: arm_scmi: Harden iterators state parsing Cristian Marussi
2026-11-09 21:57 ` Jonathan Cameron
2026-11-10 8:19 ` Cristian Marussi
2026-11-09 9:11 ` [PATCH v15 02/35] firmware: arm_scmi: Add new SCMIv4.0 error codes definitions Cristian Marussi
2026-11-09 9:11 ` [PATCH v15 03/35] firmware: arm_scmi: Introduce a dedicated SCMI Errors header Cristian Marussi
2026-11-09 22:01 ` Jonathan Cameron
2026-11-10 8:23 ` Cristian Marussi
2026-11-09 9:11 ` [PATCH v15 04/35] firmware: arm_scmi: Allow registration of unknown-size events/reports Cristian Marussi
2026-11-09 22:07 ` Jonathan Cameron
2026-11-10 8:27 ` Cristian Marussi
2026-11-09 9:11 ` [PATCH v15 05/35] firmware: arm_scmi: Refactor __scmi_event_handler_get_ops helper Cristian Marussi
2026-11-09 9:11 ` [PATCH v15 06/35] firmware: arm_scmi: Introduce protocol instance notifiers Cristian Marussi
2026-11-09 23:32 ` Jonathan Cameron
2026-11-09 9:11 ` [PATCH v15 07/35] dt-bindings: firmware: arm,scmi: Add support for telemetry protocol Cristian Marussi
2026-11-09 9:11 ` [PATCH v15 08/35] include: trace: Add Telemetry trace events Cristian Marussi
2026-11-09 9:11 ` [PATCH v15 09/35] firmware: arm_scmi: Add Telemetry basic attributes enumeration Cristian Marussi
2026-11-09 23:57 ` Jonathan Cameron
2026-11-09 9:11 ` [PATCH v15 10/35] firmware: arm_scmi: Add Telemetry resources enumeration Cristian Marussi
2026-11-10 1:36 ` Jonathan Cameron
2026-11-10 15:33 ` Cristian Marussi
2026-11-12 18:01 ` Jonathan Cameron
2026-11-12 19:56 ` Cristian Marussi
2026-11-16 21:36 ` Jonathan Cameron
2026-11-18 9:09 ` Cristian Marussi
2026-11-18 17:26 ` Jonathan Cameron
2026-11-18 18:43 ` Cristian Marussi
2026-11-09 9:11 ` [PATCH v15 11/35] firmware: arm_scmi: Add Telemetry groups initialization Cristian Marussi
2026-11-10 1:53 ` Jonathan Cameron
2026-11-09 9:11 ` [PATCH v15 12/35] firmware: arm_scmi: Add Telemetry update intervals enumeration Cristian Marussi
2026-11-10 2:07 ` Jonathan Cameron
2026-11-09 9:11 ` [PATCH v15 13/35] firmware: arm_scmi: Add Telemetry SHMTI areas enumeration Cristian Marussi
2026-11-10 2:26 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 14/35] firmware: arm_scmi: Add Telemetry TDCF areas parsing support Cristian Marussi
2026-11-10 18:15 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 15/35] firmware: arm_scmi: Add Telemetry TDCF parsing for BLK_TS lines Cristian Marussi
2026-11-10 18:33 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 16/35] firmware: arm_scmi: Add Telemetry TDCF parsing for UUID lines Cristian Marussi
2026-11-10 18:49 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 17/35] firmware: arm_scmi: Add Telemetry configuration operations Cristian Marussi
2026-11-10 20:07 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 18/35] firmware: arm_scmi: Add Telemetry DataEvent read capabilities Cristian Marussi
2026-11-10 21:59 ` Jonathan Cameron
2026-11-12 4:30 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 19/35] firmware: arm_scmi: Add Telemetry reset logic Cristian Marussi
2026-11-10 22:07 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 20/35] firmware: arm_scmi: Add Telemetry notification support Cristian Marussi
2026-11-10 22:16 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 21/35] firmware: arm_scmi: Add Telemetry boot-on support Cristian Marussi
2026-11-10 22:25 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 22/35] firmware: arm-scmi: Add Telemetry generic event support Cristian Marussi
2026-11-10 22:33 ` Jonathan Cameron
2026-11-12 19:58 ` Cristian Marussi
2026-11-09 9:12 ` [PATCH v15 23/35] firmware: arm_scmi: Add Telemetry generation counter event Cristian Marussi
2026-11-10 22:46 ` Jonathan Cameron
2026-11-12 20:17 ` Cristian Marussi
2026-11-12 21:44 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 24/35] firmware: arm_scmi: Add common per-protocol debugfs support Cristian Marussi
2026-11-10 22:50 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 25/35] firmware: arm_scmi: Add Telemetry debugfs SHMTI dump support Cristian Marussi
2026-11-10 22:54 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 26/35] firmware: arm_scmi: Add Telemetry debugfs ABI documentation Cristian Marussi
2026-11-10 22:55 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 27/35] firmware: arm_scmi: Expose per-instance identifier Cristian Marussi
2026-11-10 22:57 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 28/35] firmware: arm_scmi: Add un-managed methods to get/put protocols operations Cristian Marussi
2026-11-10 23:01 ` Jonathan Cameron
2026-11-10 23:18 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 29/35] uapi: Add ARM SCMI Telemetry definitions Cristian Marussi
2026-11-10 23:13 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 30/35] firmware: arm_scmi: Add System Telemetry driver Cristian Marussi
2026-11-10 23:46 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 31/35] firmware: arm_scmi: Enable autoloading for " Cristian Marussi
2026-11-09 9:12 ` [PATCH v15 32/35] docs: ioctl-number: Add SCMI Ioctls Cristian Marussi
2026-11-09 9:12 ` [PATCH v15 33/35] Documentation: Add SCMI System Telemetry documentation Cristian Marussi
2026-11-10 23:54 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 34/35] [RFC] kselftest/arm64: Add SCMI Telemetry UAPI compliance testcases Cristian Marussi
2026-11-11 0:13 ` Jonathan Cameron
2026-11-09 9:12 ` [PATCH v15 35/35] [RFC] tools/testing/scmi: Add SCMI Telemetry testing tool Cristian Marussi
2026-11-11 0:16 ` Jonathan Cameron
2026-11-11 0:38 ` [PATCH v15 00/35] Introduce SCMI Telemetry support Jonathan Cameron
2026-11-11 9:51 ` Sudeep Holla
2026-11-11 10:15 ` Cristian Marussi
2026-11-11 18:39 ` Jonathan Cameron
2026-11-17 12:43 ` Sudeep Holla
2026-11-17 13:10 ` Cristian Marussi
2026-11-18 1:07 ` Jonathan Cameron
2026-11-18 9:14 ` Cristian Marussi
2026-11-18 9:33 ` Sudeep Holla
2026-11-18 17:32 ` Jonathan Cameron [this message]
2026-11-18 18:39 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118093203.000069f1@oss.qualcomm.com \
--to=jonathan.cameron@oss.qualcomm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=d-gole@ti.com \
--cc=david@kernel.org \
--cc=elif.topuz@arm.com \
--cc=etienne.carriere@st.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=leitao@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=michal.simek@amd.com \
--cc=peng.fan@oss.nxp.com \
--cc=philip.radford@arm.com \
--cc=puranjay@kernel.org \
--cc=souvik.chakravarty@arm.com \
--cc=sudeep.holla@kernel.org \
--cc=usama.arif@linux.dev \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®