From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.216.248.207 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794995908; b=ElrIC8z430oopCEbiFYKaUua0D93Z4KpBiooEsNAVNLCFqQ6uwrYh0VYT6yjMwaI0d+a ILubQC2uvMHrmTGB8zna/LG8C2B+zxnsqmb8GvtYi+hi9xhyQaCVeNXqTDtWbo7B3p/un Q00ybcXJZo9Ouka3rFcxCVmRzTMxw7L9vPi3das/JtAISItimi64latrkAnHiXov6ABIl GCk+pP5pUiyc8ka+u2NJmjwLByIowoSnhcBS6yYlGatlFys5sZOqF9HKGPPOoekb298M/ iM+kvK5gnOOg+TAFVn2IV3pBKVptnDCmkDoBWJpYWFOiOhEspvnEQvhRa/LdcBn/DfA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794995908; h=DMARC-Filter:Date:X-Lima-ML-UUID:DKIM-Signature:From:To:Cc:Subject: Message-ID:In-Reply-To:References:Organization:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding; bh=jcs67+Lv+U9upOUf4i1JrBoRc0VrRzju4wtU72Tt0uo=; b=x1FjeesEv1dPAN1KJQoxOlHMHha+qL8/vTrXOerWXk4Mun40Yc4MpaNNs4qXHBWTu/7m Xi9fD0F+E0ENLp/4pI14pAsubeD2s4KSbjR/H+QaJ9QZCPF/IhKt+XAxfgwgwrXAaYKhS WnZ/k4nff+JDOXkHjjsFAg8Pf7xpET07S9MDOtMRjryEqdF1vNCKKEvzpDKQEvon/U8AC 5ZEEygY3+60YH6Yv+vO1iUt3L86eWvKtAVwU6g/L5T7exjDS3dqyUgFHwG2oL5DTnAmaC tPiOYfxcHKq1MKwOnIrGMOiB6pmlYDVltbMOKehsG0cRXwpl6rebyi6FyDGE9OHRf5A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=deq.rocks; spf=none smtp.mailfrom=deq.rocks; dkim=pass header.d=deq.rocks header.i=@deq.rocks header.a=rsa-sha256 header.s=securedbylima-20251205 header.b=b8ruWdf1; arc=none smtp.remote-ip=91.216.248.207 Received: from mx5.mail-out.lima-city.de (mx5.mail-out.lima-city.de [91.216.248.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF536606A330; Wed, 18 Nov 2026 09:58:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AF536606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=deq.rocks Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=deq.rocks Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=deq.rocks header.i=@deq.rocks header.a=rsa-sha256 header.s=securedbylima-20251205 header.b=b8ruWdf1 Date: Wed, 18 Nov 2026 10:42:04 +0100 X-Lima-ML-UUID: e48ff96b-0f23-405e-b3e9-272f618e95ab DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=deq.rocks; s=securedbylima-20251205; t=1794995899; bh=jcs67+Lv+U9upOUf4i1JrBoRc0VrRzju4wtU72Tt0uo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b8ruWdf1TRi2fFxA/guW7LfgkkkYoNBZ9wE+VBDdIO35Tl02BfCBP7yNDq91ZhEh1 FpIUGwEsuXayrj4cJ1io+NOy8PnHoooHrtSbNpvan1WPEM4I76XBY9JSiS0aRiaQGo PdM6Z0AJFslSYK82z/s4qzQCgxDO6PhkUjwyg5uIfDwKKBWEHywkObZbsOTHtYcVdi i/tF3Xp0Fn7jGQKPcTGkLJvje7UApILifVyWZRHG/lBE10ZJfhZ5Uxd2kKUwm6L3mh XfpWj36ZOCA2vlVsOtZo1Sb+mnwV+qsDJCnCNwE7zlhtdVzkCQTAl+JugYhgTEt/wF Xr0OXgnF0krQQ== From: =?UTF-8?B?QW5kcsOp?= Eikmeyer To: Arend van Spriel Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Yossef Osman , Aditya Garg Subject: Re: [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364 Message-ID: <20261118104049.39e4d3a2@kait2en-mbp15-1> In-Reply-To: <20261116203719.281605-1-arend.vanspriel@broadcom.com> References: <20261104151620.70671-1-dev@deq.rocks> <20261116203719.281605-1-arend.vanspriel@broadcom.com> Organization: KaiT2en X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 16 Nov 2026 21:37:17 +0100 Arend van Spriel wrote: > 1) The measurements only implicate ndoe. Do you have data showing > arpoe also needs to be off? Otherwise please limit this to ND offload. Well, scratching my head here as well. The throughput drop is ND alone, with only ND offload off the MacBookPro 15,1 reaches the full 120 Mbit/s as well. I keep ARP offload off anyway because that is how macOS runs this firmware. The macOS trace shows arpoe, nd_hostip_clear and ndoe set to 0 together on wake, and both offloads are only enabled on entry to associated sleep. Apple checks emails, Siri and whatnots on sleep.I can't look into the firmware, and with ARP offload on while awake we would run it in a configuration Apple does not use. With both off it has run on the community machines for weeks without problems.We can enable it but may require another few weeks until we can confirm it's stable. > 2) [...] Please restrict the quirk to the affected platform, e.g. with > the Apple board type (settings->board_type) [...] The same applies to > the other chip ID quirks of this batch (txbf and FWAUTH). Will do! > 3) This looks like a bug fix. Please add a Fixes: tag and Cc: stable > (as Aditya suggested), and mark the target tree in the subject. Yes, v2 goes to wireless with both. Andre