mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: Carlos Llamas <cmllamas@google.com>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Christian Brauner" <brauner@kernel.org>,
	kernel-team@android.com, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust_binder: disallow binder fd transfers
Date: Wed, 18 Nov 2026 11:29:32 +0000	[thread overview]
Message-ID: <20261118112933.477541-1-aliceryhl@google.com> (raw)
In-Reply-To: <20261117231927.2200674-1-cmllamas@google.com>

On Tue, Nov 17, 2026 at 11:19:26PM +0000, Carlos Llamas wrote:
> @@ -182,6 +182,13 @@ pub(crate) fn info_add_fd(
>          buffer_offset: usize,
>          close_on_free: bool,
>      ) -> Result {
> +        // SAFETY: `file` is valid; read `f_op` with `READ_ONCE` semantics.
> +        let f_op = unsafe { (&raw const (*file.as_ptr()).f_op).read_volatile() };
> +        if core::ptr::eq(f_op, &crate::rust_binder_fops.0) {
> +            // Binder FD transfers are not allowed.
> +            return Err(EINVAL);
> +        }

We have moved to using atomic_load instead of a volatile read when the C side
uses READ_ONCE. For example:

	// SAFETY: `file` is valid, so `f_op` is valid and aligned, and any
	// concurrent writes are atomic under LKMM.
	let f_op = unsafe { atomic_load(&raw mut (*file.as_ptr()).f_op, Relaxed) };

however the f_op field isn't read/modified with READ/WRITE_ONCE on the C
side, so I think we can use a bare access.

	let f_op = unsafe { (*file.as_ptr()).f_op };

Alice

      reply	other threads:[~2026-11-18 11:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 23:19 Carlos Llamas
2026-11-18 11:29 ` Alice Ryhl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118112933.477541-1-aliceryhl@google.com \
    --to=aliceryhl@google.com \
    --cc=arve@android.com \
    --cc=brauner@kernel.org \
    --cc=cmllamas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®