From: Herve Codina <herve.codina@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Andi Shyti <andi.shyti@kernel.org>,
Peter Rosin <peda@lysator.liu.se>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
Allan Nielsen <allan.nielsen@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
Steen Hegelund <steen.hegelund@microchip.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>
Subject: [PATCH v10 1/6] media: rtl2832: Use I2C client device as mux device
Date: Wed, 18 Nov 2026 14:39:10 +0100 [thread overview]
Message-ID: <20261118133927.366482-2-herve.codina@bootlin.com> (raw)
In-Reply-To: <20261118133927.366482-1-herve.codina@bootlin.com>
rtl2832_probe() currently passes &i2c->dev, the driverless parent adapter
device, to i2c_mux_alloc().
This leads to the mux device set to this adapter device instead of the
physical device handling the mux, the rtl2832 device.
This is an issue when consumer/supplier devlink are involved. Indeed,
the physical device with a driver attached need to be pointed to by
devlink.
Use the rtl2832 device &client->dev instead, as done by the other DVB
demodulator drivers.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
drivers/media/dvb-frontends/rtl2832.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
index b31cdb44b383..57707d84701b 100644
--- a/drivers/media/dvb-frontends/rtl2832.c
+++ b/drivers/media/dvb-frontends/rtl2832.c
@@ -1075,7 +1075,7 @@ static int rtl2832_probe(struct i2c_client *client)
goto err_regmap_exit;
/* create muxed i2c adapter for demod tuner bus */
- dev->muxc = i2c_mux_alloc(i2c, &i2c->dev, 1, 0, I2C_MUX_LOCKED,
+ dev->muxc = i2c_mux_alloc(i2c, &client->dev, 1, 0, I2C_MUX_LOCKED,
rtl2832_select, rtl2832_deselect);
if (!dev->muxc) {
ret = -ENOMEM;
--
2.56.0
next prev parent reply other threads:[~2026-11-18 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:39 [PATCH v10 0/6] lan966x pci device: Add support for SFPs, i2c part Herve Codina
2026-11-18 13:39 ` Herve Codina [this message]
2026-11-18 13:39 ` [PATCH v10 2/6] i2c: core: Introduce i2c_get_adapter_physdev() Herve Codina
2026-11-18 13:39 ` [PATCH v10 3/6] i2c: mux: Set adapter physical device Herve Codina
2026-11-18 13:39 ` [PATCH v10 4/6] i2c: mux: Create missing devlink between mux and " Herve Codina
2026-11-18 13:39 ` [PATCH v10 5/6] i2c: atr: Set " Herve Codina
2026-11-18 13:39 ` [PATCH v10 6/6] i2c: atr: Create missing devlink between ATR and " Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118133927.366482-2-herve.codina@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andi.shyti@kernel.org \
--cc=andrew@lunn.ch \
--cc=daniel.machon@microchip.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mchehab@kernel.org \
--cc=peda@lysator.liu.se \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
--cc=steen.hegelund@microchip.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®