From: Svyatoslav Ryhel <clamor95@gmail.com>
To: "Hans de Goede" <hansg@kernel.org>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Svyatoslav Ryhel" <clamor95@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 2/2] platform/asus: Add driver for ASUS Transformer's Dock of Tegra based devices
Date: Wed, 18 Nov 2026 15:45:47 +0200 [thread overview]
Message-ID: <20261118134555.195479-3-clamor95@gmail.com> (raw)
In-Reply-To: <20261118134555.195479-1-clamor95@gmail.com>
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
The ASUS Transformer dock used by Tegra-based devices has an extended I2C
bus where certain devices are hot-pluggable and their presence
is indicated by a GPIO line. The set of hot-pluggable devices must be
predetermined and static.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/platform/asus/Kconfig | 11 +
drivers/platform/asus/Makefile | 1 +
drivers/platform/asus/asus-transformer-dock.c | 260 ++++++++++++++++++
3 files changed, 272 insertions(+)
create mode 100644 drivers/platform/asus/asus-transformer-dock.c
diff --git a/drivers/platform/asus/Kconfig b/drivers/platform/asus/Kconfig
index 0219418ce3523..af670a3c0d014 100644
--- a/drivers/platform/asus/Kconfig
+++ b/drivers/platform/asus/Kconfig
@@ -113,6 +113,17 @@ config ASUS_ARMOURY
To compile this driver as a module, choose M here: the module will
be called asus-armoury.
+config ASUS_TRANSFORMER_DOCK
+ tristate "ASUS Transformer Dock for Tegra based devices"
+ depends on GPIOLIB
+ depends on OF
+ help
+ Say Y here if you want support for ASUS Transformer Dock for
+ Tegra devices.
+
+ This driver can also be built as a module. If so, the module
+ will be called asus-transformer-dock.
+
config ASUS_WMI
tristate "ASUS WMI Driver"
depends on ACPI_WMI
diff --git a/drivers/platform/asus/Makefile b/drivers/platform/asus/Makefile
index 7bb25cba4853d..f130141dda534 100644
--- a/drivers/platform/asus/Makefile
+++ b/drivers/platform/asus/Makefile
@@ -10,5 +10,6 @@ obj-$(CONFIG_ASUS_ARMOURY) += asus-armoury.o
obj-$(CONFIG_ASUS_WMI) += asus-wmi.o
obj-$(CONFIG_ASUS_NB_WMI) += asus-nb-wmi.o
obj-$(CONFIG_ASUS_TF103C_DOCK) += asus-tf103c-dock.o
+obj-$(CONFIG_ASUS_TRANSFORMER_DOCK) += asus-transformer-dock.o
obj-$(CONFIG_EEEPC_LAPTOP) += eeepc-laptop.o
obj-$(CONFIG_EEEPC_WMI) += eeepc-wmi.o
diff --git a/drivers/platform/asus/asus-transformer-dock.c b/drivers/platform/asus/asus-transformer-dock.c
new file mode 100644
index 0000000000000..7c9346af5e1f3
--- /dev/null
+++ b/drivers/platform/asus/asus-transformer-dock.c
@@ -0,0 +1,260 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/i2c.h>
+#include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+
+#define ASUS_TF_DOCK_ATTACHED 0
+
+struct asus_tf_dock_priv {
+ struct i2c_adapter adap;
+ struct i2c_adapter *parent;
+ struct device *dev;
+ struct gpio_desc *gpio;
+ unsigned long state_flags;
+};
+
+static inline struct i2c_adapter *asus_tf_dock_parent(struct i2c_adapter *adap)
+{
+ struct asus_tf_dock_priv *priv =
+ container_of(adap, struct asus_tf_dock_priv, adap);
+
+ return priv->parent;
+}
+
+static int asus_tf_dock_master_xfer(struct i2c_adapter *adap,
+ struct i2c_msg msgs[], int num)
+{
+ struct i2c_adapter *parent = asus_tf_dock_parent(adap);
+
+ return parent->algo->master_xfer(parent, msgs, num);
+}
+
+static int asus_tf_dock_smbus_xfer(struct i2c_adapter *adap, u16 addr,
+ unsigned short flags, char read_write,
+ u8 command, int protocol,
+ union i2c_smbus_data *data)
+{
+ struct i2c_adapter *parent = asus_tf_dock_parent(adap);
+
+ return parent->algo->smbus_xfer(parent, addr, flags, read_write,
+ command, protocol, data);
+}
+
+static u32 asus_tf_dock_functionality(struct i2c_adapter *adap)
+{
+ u32 parent_func = i2c_get_functionality(asus_tf_dock_parent(adap));
+
+ return parent_func & ~I2C_FUNC_SLAVE;
+}
+
+static const struct i2c_algorithm asus_tf_dock_algo_i2c = {
+ .master_xfer = asus_tf_dock_master_xfer,
+ .functionality = asus_tf_dock_functionality,
+};
+
+static const struct i2c_algorithm asus_tf_dock_algo_smbus = {
+ .smbus_xfer = asus_tf_dock_smbus_xfer,
+ .functionality = asus_tf_dock_functionality,
+};
+
+static const struct i2c_algorithm asus_tf_dock_algo_both = {
+ .master_xfer = asus_tf_dock_master_xfer,
+ .smbus_xfer = asus_tf_dock_smbus_xfer,
+ .functionality = asus_tf_dock_functionality,
+};
+
+static const struct i2c_algorithm *const asus_tf_dock_algo[2][2] = {
+ /* non-I2C */
+ { NULL, &asus_tf_dock_algo_smbus },
+ /* I2C */
+ { &asus_tf_dock_algo_i2c, &asus_tf_dock_algo_both }
+};
+
+static void asus_tf_dock_lock_bus(struct i2c_adapter *adap, unsigned int flags)
+{
+ i2c_lock_bus(asus_tf_dock_parent(adap), flags);
+}
+
+static int asus_tf_dock_trylock_bus(struct i2c_adapter *adap,
+ unsigned int flags)
+{
+ return i2c_trylock_bus(asus_tf_dock_parent(adap), flags);
+}
+
+static void asus_tf_dock_unlock_bus(struct i2c_adapter *adap,
+ unsigned int flags)
+{
+ i2c_unlock_bus(asus_tf_dock_parent(adap), flags);
+}
+
+static const struct i2c_lock_operations asus_tf_dock_lock_ops = {
+ .lock_bus = asus_tf_dock_lock_bus,
+ .trylock_bus = asus_tf_dock_trylock_bus,
+ .unlock_bus = asus_tf_dock_unlock_bus,
+};
+
+static int asus_tf_dock_recover_bus(struct i2c_adapter *adap)
+{
+ return i2c_recover_bus(asus_tf_dock_parent(adap));
+}
+
+static struct i2c_bus_recovery_info asus_tf_dock_recovery_info = {
+ .recover_bus = asus_tf_dock_recover_bus,
+};
+
+static int asus_tf_dock_activate(struct asus_tf_dock_priv *priv)
+{
+ int ret;
+
+ if (test_bit(ASUS_TF_DOCK_ATTACHED, &priv->state_flags))
+ return 0;
+
+ /*
+ * Store the dev data in adapter dev, since
+ * previous i2c_del_adapter might have wiped it.
+ */
+ priv->adap.dev.parent = priv->dev;
+ priv->adap.dev.of_node = priv->dev->of_node;
+
+ dev_dbg(priv->adap.dev.parent, "connection detected");
+
+ ret = i2c_add_adapter(&priv->adap);
+ if (!ret)
+ set_bit(ASUS_TF_DOCK_ATTACHED, &priv->state_flags);
+
+ return ret;
+}
+
+static void asus_tf_dock_deactivate(struct asus_tf_dock_priv *priv)
+{
+ if (!test_bit(ASUS_TF_DOCK_ATTACHED, &priv->state_flags))
+ return;
+
+ dev_dbg(priv->adap.dev.parent, "disconnection detected");
+
+ i2c_del_adapter(&priv->adap);
+ clear_bit(ASUS_TF_DOCK_ATTACHED, &priv->state_flags);
+}
+
+static irqreturn_t asus_tf_dock_interrupt(int irq, void *dev_id)
+{
+ struct asus_tf_dock_priv *priv = dev_id;
+
+ /* debounce */
+ msleep(20);
+
+ if (gpiod_get_value_cansleep(priv->gpio))
+ asus_tf_dock_activate(priv);
+ else
+ asus_tf_dock_deactivate(priv);
+
+ return IRQ_HANDLED;
+}
+
+static void wrap_i2c_put_adapter(void *adapter)
+{
+ i2c_put_adapter(adapter);
+}
+
+static void wrap_asus_tf_dock_deactivate(void *priv)
+{
+ asus_tf_dock_deactivate(priv);
+}
+
+static int asus_tf_dock_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct device_node *parent_np;
+ struct i2c_adapter *parent;
+ struct asus_tf_dock_priv *priv;
+ bool is_i2c, is_smbus;
+ int err;
+
+ priv = devm_kzalloc_obj(dev, struct asus_tf_dock_priv);
+ if (!priv)
+ return -ENOMEM;
+
+ platform_set_drvdata(pdev, priv);
+ priv->dev = dev;
+
+ parent_np = of_parse_phandle(dev->of_node, "i2c-parent", 0);
+ if (IS_ERR(parent_np))
+ return dev_err_probe(dev, PTR_ERR(parent_np),
+ "Failed to parse i2c-parent\n");
+
+ parent = of_find_i2c_adapter_by_node(parent_np);
+ of_node_put(parent_np);
+ if (IS_ERR(parent))
+ return dev_err_probe(dev, PTR_ERR(parent),
+ "Failed to get parent I2C adapter\n");
+ priv->parent = parent;
+
+ err = devm_add_action_or_reset(dev, wrap_i2c_put_adapter, parent);
+ if (err)
+ return err;
+
+ priv->gpio = devm_gpiod_get(dev, "detect", GPIOD_IN);
+ if (IS_ERR(priv->gpio))
+ return dev_err_probe(dev, PTR_ERR(priv->gpio),
+ "Failed to get detect GPIO\n");
+
+ is_i2c = parent->algo->master_xfer;
+ is_smbus = parent->algo->smbus_xfer;
+
+ priv->adap.algo = asus_tf_dock_algo[is_i2c][is_smbus];
+ if (!priv->adap.algo)
+ return -EINVAL;
+
+ snprintf(priv->adap.name, sizeof(priv->adap.name),
+ "asus-transformer-dock (master i2c-%d)", i2c_adapter_id(parent));
+ priv->adap.owner = THIS_MODULE;
+ priv->adap.lock_ops = &asus_tf_dock_lock_ops;
+ priv->adap.class = parent->class;
+ priv->adap.retries = parent->retries;
+ priv->adap.timeout = parent->timeout;
+ priv->adap.quirks = parent->quirks;
+ if (parent->bus_recovery_info)
+ priv->adap.bus_recovery_info = &asus_tf_dock_recovery_info;
+
+ err = devm_add_action_or_reset(dev, wrap_asus_tf_dock_deactivate, priv);
+ if (err)
+ return err;
+
+ err = devm_request_threaded_irq(dev, gpiod_to_irq(priv->gpio), NULL,
+ asus_tf_dock_interrupt,
+ IRQF_TRIGGER_RISING |
+ IRQF_TRIGGER_FALLING |
+ IRQF_ONESHOT | IRQF_SHARED,
+ "asus-transformer-dock", priv);
+ if (err)
+ return dev_err_probe(dev, err, "Failed to register IRQ %d\n",
+ gpiod_to_irq(priv->gpio));
+
+ irq_wake_thread(gpiod_to_irq(priv->gpio), priv);
+
+ return 0;
+}
+
+static const struct of_device_id asus_tf_dock_of_match[] = {
+ { .compatible = "asus,transformer-dock" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, asus_tf_dock_of_match);
+
+static struct platform_driver asus_tf_dock_driver = {
+ .driver = {
+ .name = "asus-transformer-dock",
+ .of_match_table = asus_tf_dock_of_match,
+ },
+ .probe = asus_tf_dock_probe,
+};
+module_platform_driver(asus_tf_dock_driver);
+
+MODULE_DESCRIPTION("ASUS Transformer's Dock for Tegra based devices");
+MODULE_AUTHOR("Michał Mirosław <mirq-linux@rere.qmqm.pl>");
+MODULE_LICENSE("GPL");
--
2.53.0
prev parent reply other threads:[~2026-11-18 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:45 [PATCH v1 0/2] platform/asus: Add driver for ASUS Transformer's Dock Svyatoslav Ryhel
2026-11-18 13:45 ` [PATCH v1 1/2] dt-bindings: i2c: Document " Svyatoslav Ryhel
2026-11-18 14:40 ` Wolfram Sang
2026-11-18 14:42 ` Svyatoslav Ryhel
2026-11-18 13:45 ` Svyatoslav Ryhel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118134555.195479-3-clamor95@gmail.com \
--to=clamor95@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®