From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.71 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795009671; b=EbdDqek0KBsn0qbkxmPrPvt1HvrwT8Ni+PLgXRgqLbOFIg/mVqgnBo0qH8H0bOrTropC DLQLbUbgD30PG8KXxG59QtuObBGxLgGrulCFR/DB7I/dBtWyHjS7YeWw5nPxFYE9F9QL0 7AGhDQNBO7dxP4tC+yhL/vlusRAv2zFCmKnk1ej9/d10R+Zm4mckbwOt5GTRi2UzwVng9 kef6I8gwGMFjYQFv1lmA6j60EmqEmkCxIHrWtFyyMUG8wltrYJTN0lXdM+6GP/D3E2IvO GVxW3wYGJQESSzUNSxIiRuaLVBZQ2KGUenaBYjuCn9Pfiu3WHVw4J55/482kFuLq7qw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795009671; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=tbHSrCrWbtManjiZm8yvLdlzikeM8PecjfjtsmyrzGk=; b=4Uq2KL7xckFdZiZ+Rxq+FoyEzKcNH4F7cqGNmKDNh/4KJiOXXMinXAI1crYWL2+iP01y UUdNP5kJfl7CLOLpkTukYj03MHVOQg7gIsOWsOR/xdH5Vx5B2cGSv+QfJG+REGLDv7aJB Ahnaw5YSjbbfW9wFqgoKTlcGiFcXAK+tL3MxJfh4f2nnKiacv0akxEaTmudM4qREAZj6S sNmybfdZ66m6HtPUP9O9RaRh+/3pB9RgJAqYDYVqkYT5tgBBb3hywC13dqhhET3cozGpE 4rLbcfhTITDZfE0RxdrX+DEFZG8mfdMajwCq7hr8T9wbYyU9Bnit8iol1n9+AGyP1oQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=JbPHYrLm; arc=none smtp.remote-ip=209.85.221.71 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBBAE606A325 for ; Wed, 18 Nov 2026 13:47:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DBBAE606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=JbPHYrLm Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-49337a224a8so714076f8f.3 for ; Wed, 18 Nov 2026 05:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795009669; x=1795614469; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tbHSrCrWbtManjiZm8yvLdlzikeM8PecjfjtsmyrzGk=; b=JbPHYrLmilie8tim6UMjJw3y4D2agEMcgJhzkH6d6H1xauaURr5MM7N+XZPWoQN1V9 JOVnnVBHfON5uLr4iZ9N29pvVyHIP3Zp2uTXc8nIU26s4mf3KUa3WUwkP2/r7ww570sn 6eY4B7G0Ar8vsyDOhjyN/mj7Od4s+NY0Z87HQVmNXVvlITGAOSIGyasPji3a5NDM11rc S1HC55SFRG1U3OddKseqb2KQCT4uIdFOWnfZFC/dC9kyymV5AZsvwe6mFs8p4YRDGlPs 7wHZSTU/8Vym+5q/IqfvTVUgOux1W3DtW7lkAeOl9hLxiGo7NaT2G1q78jA4gGWQxwqK 78nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795009669; x=1795614469; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tbHSrCrWbtManjiZm8yvLdlzikeM8PecjfjtsmyrzGk=; b=XJZp7IcFnzoWpSLlzMapHa5wEs4f+BTbuc3BTBlqoH4YsmjR7Diuw2Er6UxSi9xAUd 9AEQVLn8HS15aXlUsFZiDMdFNo/jYaNsQWeXAswJdnRgqZts2kSscAKGAZkUWop5s3sb ec+sWSHlRa8FhtwIqgUGgDV7yPwkxigmbM0Ho/lhwfkYA+NLlY4L9PJKhgSwVxxbjJsp qFAEo5aOg5AtXs+7eRnXDJFyuyrLTFQ3rOo9ER8Mfqy30X0h5dZ0P4t/YiijU5lsWGHz hQarCo+/lvZre+i+5C8A6J52aoT+cb7Dk29jlaPbzsGlHyBNHoSbGToocQUdX+Q2XWzo w7oQ== X-Forwarded-Encrypted: i=1; AL+hErGun4EP/tKBOJqtRGcBIrruPzCETgzgNUwScsxFgdJNR3xrJxyXCBK623/BB15Muuq2vTK58vdouOtUpxs=@vger.kernel.org X-Gm-Message-State: APuU4Z95gX+CUWMbfN4pPLoC9U+iwwPwldsLeOh+8UlgeDnk3War9Mwr uOIWESul3JYgQY3J4ppNBrqKj8nnkNkqYlC4hWmIqvdnMdLiSaGVRIp5/OqXzc2tRP6kljn88dB XuHBSWC17zGYuDJzBkQ== X-Received: from wrop10.prod.google.com ([2002:adf:f20a:0:b0:4a7:5aab:c222]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:41c9:b0:492:b1c5:6db4 with SMTP id ffacd0b85a97d-4a63bbc379bmr5187806f8f.26.1795009668616; Wed, 18 Nov 2026 05:47:48 -0800 (PST) Date: Wed, 18 Nov 2026 13:47:47 +0000 In-Reply-To: <20261013-clk-type-state-v6-2-a5e9977b3509@collabora.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261013-clk-type-state-v6-0-a5e9977b3509@collabora.com> <20261013-clk-type-state-v6-2-a5e9977b3509@collabora.com> X-Mailer: git-send-email 2.56.1.703.gf848ed807c-goog Message-ID: <20261118134747.658063-1-aliceryhl@google.com> Subject: Re: [PATCH v6 2/7] rust: clk: replace `OptionalClk` with `Clk::get_optional()` From: Alice Ryhl To: Daniel Almeida Cc: Alice Ryhl , "Rafael J. Wysocki" , Viresh Kumar , Danilo Krummrich , David Airlie , Simona Vetter , Michal Wilczynski , Drew Fustini , Guo Ren , Fu Wei , "=?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?=" , Stephen Boyd , Brian Masney , Jerome Brunet , Miguel Ojeda , Boqun Feng , Gary Guo , "=?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , Tamir Duberstein , Alexandre Courbot , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org, linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, Boris Brezillon , "=?UTF-8?q?Onur=20=C3=96zkan?=" , Maurice Hieronymus Content-Type: text/plain; charset="UTF-8" On Tue, Oct 13, 2026 at 02:07:41PM -0300, Daniel Almeida wrote: > + /// Behaves the same as [`Self::get`], except when there is no clock > + /// producer. In this case, instead of returning [`ENOENT`], it returns > + /// a dummy [`Clk`]. > + /// > + /// Equivalent to the kernel's [`clk_get_optional`] API. > + /// > + /// [`clk_get_optional`]: > + /// https://docs.kernel.org/core-api/kernel-api.html#c.clk_get_optional > + pub fn get_optional(dev: &Device, name: Option<&CStr>) -> Result { rustdoc appears broken here (putting the URL on the same line as `[`clk_get_optional`]:` avoids splitting the link definition). Otherwise LGTM: Reviewed-by: Alice Ryhl Alice