mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Magnus Leatti <magnusleatti@kernelriot.com>
To: rafael@kernel.org
Cc: Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Kees Cook <kees+treewide@kernel.org>,
	Kaushlendra Kumar <kaushlendra.kumar@intel.com>,
	Jean Delvare <jdelvare@suse.de>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] thermal: intel: intel_pch_thermal: Add 200 series PCH-H device ID
Date: Wed, 18 Nov 2026 12:53:13 -0300	[thread overview]
Message-ID: <20261118155313.2067857-1-magnusleatti@kernelriot.com> (raw)

The PCH thermal sensor on 200 series boards (Z270, Z370, X299, ...) is
8086:a2b1 and it's not in the ID table, so these boards, including mine,
get no PCH temperature at all. The 100 series (Skylake) and 300 series
(Cannon Lake) are there, Kaby belongs perfectly in between, I see no
reason to not have it there.

It's the same sensor. Intel's own datasheet (335193, chapter 21.2) has
the register layout the driver already uses, so just add the ID and
point it at PCH_BOARD_SKL like a131.

Tested on an ASRock X299 Taichi, Kernel @ 7.4-rc3 with this patch. The
driver loads by itself and the BIOS already turns the sensor on, so it
just reads it. The zone shows 66°C / 115°C Crit, the readings look
correct.

Adding the ID has one more effect. I am not going to call it a side
effect but more, an intended effect? AFAICS these boards were just
missing the s2idle cooling delay that the 100 and 300 series already
have, and now they get it. X299 usually runs above the 50 C threshold,
it would wait the full 60s. Meaning that the wait *WILL* be present.

The reason I am saying it *WILL* be present, is that I could not put
this specific box to suspend, due to the GPU not allowing it under Linux
and X299 not having onboard GPU on the CPU. But I manually followed the
path (intel_pch_thermal_suspend_noirq()) and it seems to be precisely
what will happen.

I am not the first to notice this. Henry Bent put a patch in bugzilla
back in 2024, and Jean Delvare asked about it on linux-pm last year.

Link: https://cdrdv2-public.intel.com/335193/200-series-chipset-pch-datasheet-vol-2.pdf
Link: https://bugzilla.kernel.org/show_bug.cgi?id=219197
Link: https://lore.kernel.org/linux-pm/20251222154444.496284d9@endymion/
Signed-off-by: Magnus Leatti <magnusleatti@kernelriot.com>
---

Thanks,
Magnus

 drivers/thermal/intel/intel_pch_thermal.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
index 074bc8ca5f0f..7d8803608486 100644
--- a/drivers/thermal/intel/intel_pch_thermal.c
+++ b/drivers/thermal/intel/intel_pch_thermal.c
@@ -24,6 +24,7 @@
 #define PCH_THERMAL_DID_WPT	0x9CA4 /* Wildcat Point */
 #define PCH_THERMAL_DID_SKL	0x9D31 /* Skylake PCH */
 #define PCH_THERMAL_DID_SKL_H	0xA131 /* Skylake PCH 100 series */
+#define PCH_THERMAL_DID_KBL_H	0xA2B1 /* Kaby Lake PCH 200 series */
 #define PCH_THERMAL_DID_CNL	0x9Df9 /* CNL PCH */
 #define PCH_THERMAL_DID_CNL_H	0xA379 /* CNL-H PCH */
 #define PCH_THERMAL_DID_CNL_LP	0x02F9 /* CNL-LP PCH */
@@ -372,6 +373,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
 		.driver_data = PCH_BOARD_SKL, },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_SKL_H),
 		.driver_data = PCH_BOARD_SKL, },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_KBL_H),
+		.driver_data = PCH_BOARD_SKL, },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CNL),
 		.driver_data = PCH_BOARD_CNL, },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CNL_H),

base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
-- 
2.56.1


                 reply	other threads:[~2026-11-18 15:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118155313.2067857-1-magnusleatti@kernelriot.com \
    --to=magnusleatti@kernelriot.com \
    --cc=daniel.lezcano@kernel.org \
    --cc=jdelvare@suse.de \
    --cc=kaushlendra.kumar@intel.com \
    --cc=kees+treewide@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®