mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "S. Biplab Raut" <Biplab.Raut@amd.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Wilczynski <m.wilczynski@samsung.com>,
	Gao Xiang <xiang@kernel.org>,
	hsiangkao@linux.alibaba.com, Nick Terrell <terrelln@meta.com>,
	Yann Collet <yann.collet.73@gmail.com>,
	guoxuenan@huawei.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib/lz4: backport upstream fast decode loop
Date: Wed, 18 Nov 2026 18:28:25 +0000	[thread overview]
Message-ID: <20261118182825.1641673-1-Biplab.Raut@amd.com> (raw)
In-Reply-To: <20261114171452.1484344-1-Biplab.Raut@amd.com>

Hi Andrew,

Please drop this patch.  As you suggested, I compared notes with Michal
Wilczynski's series [1], and I'll contribute there instead of carrying
a parallel backport.  His series vendors upstream LZ4 v1.10.0, which
brings the same fast decode loop together with the in-place margin
change this patch lacked, so it supersedes this one.

On the three review points against this patch, two are real bugs in
this v2 and the third is a divergence from upstream.

I've posted KUnit tests for lib/lz4 on top of Michal's series, in his v2
thread ("lib/lz4: add KUnit tests for compression and decompression").
They cover the first two points.  They also port upstream's worst-case
in-place test: upstream has since raised its own margin to + 65 for the
64-byte wild copies its decoder makes since v1.11.0 [2], so the kernel's
margin will need the same change if lib/lz4 is re-synced past v1.10.0.

[1] https://lore.kernel.org/r/20261106-lz4-vendor-upstream-v2-0-ee04c3f0d7dc@samsung.com
[2] https://github.com/lz4/lz4/pull/2104

Thanks,
Biplab

      reply	other threads:[~2026-11-18 18:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 17:14 S. Biplab Raut
2026-11-18 18:28 ` S. Biplab Raut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118182825.1641673-1-Biplab.Raut@amd.com \
    --to=biplab.raut@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=guoxuenan@huawei.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.wilczynski@samsung.com \
    --cc=terrelln@meta.com \
    --cc=xiang@kernel.org \
    --cc=yann.collet.73@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®